From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tirumala Marri <tmarri@apm.com>
Date: Thu, 9 Sep 2010 09:43:31 -0700
Subject: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support
In-Reply-To: <20100909145320.AD2B81506AA@gemini.denx.de>
References: <1283911581-16085-1-git-send-email-tmarri@apm.com>
	<201009091645.16076.sr@denx.de>
	<20100909145320.AD2B81506AA@gemini.denx.de>
Message-ID: <761e2a44969fc6900a6e773118255351@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> > >  include/apm821xx.h                      |  493
> +++++++++++++++++++++++++++++++
> >
> > I know that Wolfgang specifically asked you to add this file for this
> > "new" SoC. But I'm not so sure if this is the right way. Most of the
> > defines in this new file are a plain copy from include/ppc440.h.
> >
> > Wolfgang, do you really think this is better than adding support for
> > this SoC into ppc440.h? After all, the CPU core of this SoC is still
> > a PPC4xx PowerPC.
>
> It makes no sense to duplicate common parts. Only different code
> should be moved to separate files.
>
[Marri] It is only few lines of code is different. Any way I will make a
change and
Send it.
Regards,
Marri