Re: [PATCHv10 01/15] submodule: add lwIP as git submodule

Tom Rini
2023-09-26T14:24:38Z

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On Tue, Sep 26, 2023 at 08:16:35AM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Tue, 26 Sept 2023 at 07:41, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Sep 26, 2023 at 05:37:25AM -0600, Simon Glass wrote:
> > > Hi Maxim,
> > >
> > > On Tue, 26 Sept 2023 at 03:43, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> > > >
> > > > add external lwIP library as a git submodule.
> > > > Use STABLE-2_2_0_RELEASE tag.
> > > >
> > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> > > > ---
> > > > .gitmodules | 3 +++
> > > > net/lwip/lwip-external | 1 +
> > > > 2 files changed, 4 insertions(+)
> > > > create mode 100644 .gitmodules
> > > > create mode 160000 net/lwip/lwip-external
> >
> > Do you have comments on the rest of the series?
>
> Not yet, but I should be able to review the rest in a few days. My
> main comments before were minor - return codes, tests, error checking.

OK, thanks. I don't know how exactly I want to proceed with the core of
lwip itself, but that doesn't block reviewing and testing the rest of it
as we'll move forward with it one way or another.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]