Re: [PATCHv10 01/15] submodule: add lwIP as git submodule

Tom Rini
2023-10-04T16:02:41Z

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Wed, Oct 04, 2023 at 01:52:53PM +0600, Maxim Uvarov wrote:
> On Mon, 2 Oct 2023 at 20:46, Simon Glass <sjg@google.com> wrote:
>
> > Hi Maxim,
> >
> > On Mon, 2 Oct 2023 at 05:23, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> > >
> > > I found what was missing. (reproduced with CI docker.)
> >
> > How about adding a script that copies in the lwip code needed for
> > U-Boot, that you (or whoever the maintainer is) can run each quarter?
> >
> > Alternatively, I think just sending a patch with the code would be
> > helpful, so we can see what you are wanting to include.
> >
> > Regards,
> > Simon
> >
>
> Hello Simon,
>
> That might also work. lwIP is a little bit special library which we can not
> just connect as an external library from the repo, because it has
> platform implementation specifics (U-Boot here).
> At this time I'm trying to pass all CI tests. And even if they pass for me
> locally CI has some interesting combinations where the test fails and I'm
> not even sure that it's related to lwip code.
> Once CI will pass all the things I want to take more attention on submodule
> support or patch support. I really hope that submodule will work for us,
> but that also will require Makefile and CI changes.
>
> However, review of lwIP code here might be helpful. But I think the mailing
> list will not allow me to send such a big patch, and it's almost impossible
> to do a review project in one email.
> I guess it's better to do a git clone
> https://git.savannah.nongnu.org/git/lwip.git and see what is there.

Yes, the mailing list will hold the message for moderation until I, or
one of the other people with the password approve it. That's not a
consideration for how we handle the initial lwip integration. It does
need to be a "just the import" patch as there's no real way to review
the code itself.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]