Re: [PATCHv10 14/15] net/lwip: replace original net commands with lwip

Simon Glass
2023-10-02T01:39:28Z

On Tue, 26 Sept 2023 at 03:46, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> Replace original commands: ping, tftp, dhcp and wget.
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
> boot/bootmeth_efi.c | 18 +++++++---
> boot/bootmeth_pxe.c | 21 ++++++-----
> cmd/net.c | 86 +++++----------------------------------------
> cmd/pxe.c | 19 +++++-----
> include/net.h | 8 +++--
> include/net/ulwip.h | 64 +++++++++++++++++++++++++++++++++
> 6 files changed, 113 insertions(+), 103 deletions(-)
> create mode 100644 include/net/ulwip.h

Reviewed-by: Simon Glass <sjg@chromium.org>

I don't really understand the error handling. I'm not sure why we have
void functions everywhere?