Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID

[<Tudor.Ambarus@microchip.com>]

On 4/25/22 00:39, Marek Vasut wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
> Tested on W25Q128JWPIM part.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
> NOTE: This has been incorrectly marked in PW as Changes Requested
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 763bab04c60..393a24b3162 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
>                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },
> +       {
> +               INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,

We can update the name later on if needed, so:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>


> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +       },
>         {
>                 INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
>                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> --
> 2.35.1
>