public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: trini@konsulko.com
Cc: xypron.glpk@gmx.de, u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] sandbox: disable tracing before unmapping RAM
Date: Tue, 25 Apr 2023 16:43:19 +0300	[thread overview]
Message-ID: <784b2991-d612-c063-3fc3-66f656bb328b@gmail.com> (raw)
In-Reply-To: <CAPnjgZ0WDO_zfBJcAQ5o4TmJdyda+zY=DCt1CS9HQBymGtGdjQ@mail.gmail.com>

Hi Simon,

Simon Glass <sjg@chromium.org> says:
> On Wed, 12 Apr 2023 at 12:55, Pavel Skripkin <paskripkin@gmail.com> wrote:
>>
>> Currently doing 'reset' command in sandbox with tracing enabled causes
>> SIGSEV
>>
>> ```
>> Hit any key to stop autoboot:  0
>> =>
>> =>
>> => reset
>> resetting ...
>> Segmentation fault (core dumped)
>>
>> ```
>>
>> Tracing callback uses RAM buffer for storing tracing reports, but
>> state_uninit() function unmaps whole RAM, which causes SIGSEV on umapped
>> memory inside tracing subsystem.
>>
>> Fix it by disabling tracing before unmapping memory
>>
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>> ---
>>  arch/sandbox/cpu/state.c | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thank you for review!

+Tom, I guess?

@Tom, could you, please, pick following patch?


https://lists.denx.de/pipermail/u-boot/2023-April/515192.html




With regards,
Pavel Skripkin

  reply	other threads:[~2023-04-25 13:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 18:55 [PATCH] sandbox: disable tracing before unmapping RAM Pavel Skripkin
2023-04-19  1:45 ` Simon Glass
2023-04-25 13:43   ` Pavel Skripkin [this message]
2023-04-25 13:59     ` Tom Rini
2023-04-25 14:00       ` Pavel Skripkin
2023-04-28 19:20         ` Simon Glass
2023-04-28 19:21           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=784b2991-d612-c063-3fc3-66f656bb328b@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox