From: Aaron Williams <awilliams@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: [RFC PATCH 13/29] arch: include: octeontx: add headers for OcteonTX
Date: Wed, 20 Nov 2019 05:47:48 +0000 [thread overview]
Message-ID: <7858878.Ac3pANyQ8F@flash> (raw)
In-Reply-To: <CAPnjgZ3Nv5CXSPJaoRBkoixFu_A8XGnqp3AaeQjpexcnwe9h7w@mail.gmail.com>
Hi Simon,
On Tuesday, November 19, 2019 7:00:23 PM PST Simon Glass wrote:
> External Email
>
> ----------------------------------------------------------------------
> Hi,
>
> On Tue, 29 Oct 2019 at 14:08, Suneel Garapati <suneelglinux@gmail.com>
wrote:
> > From: Suneel Garapati <sgarapati@marvell.com>
> >
> > Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
> > ---
> >
> > arch/arm/include/asm/arch-octeontx/board.h | 121 ++
> > arch/arm/include/asm/arch-octeontx/clock.h | 25 +
> > .../asm/arch-octeontx/csrs/csrs-mio_emm.h | 1193 +++++++++++++++++
> > .../include/asm/arch-octeontx/csrs/csrs-xcv.h | 428 ++++++
> > arch/arm/include/asm/arch-octeontx/gpio.h | 6 +
> > arch/arm/include/asm/arch-octeontx/smc.h | 20 +
> > arch/arm/include/asm/arch-octeontx/soc.h | 31 +
> > 7 files changed, 1824 insertions(+)
> > create mode 100644 arch/arm/include/asm/arch-octeontx/board.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/clock.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-mio_emm.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-xcv.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/gpio.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/smc.h
> > create mode 100644 arch/arm/include/asm/arch-octeontx/soc.h
>
> I think we try to avoid bitfields, but I'm not sure if there is a
> rule, and this is arch-specific code.
These bitfields are arch specific and often are created by scripts directly
from the hardware definitions. We specifically strip out the comments in our
register bitfields because otherwise the files would be huge. What would
normally be in the comments would match what is in our hardware reference
manual.
>
> +Tom Rini who will know
>
> Please remember to comment your structs and members.
>
> Regards,
> SImon
Regards,
Aaron
next prev parent reply other threads:[~2019-11-20 5:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 21:07 [U-Boot] [RFC PATCH 00/29] arm: Introduce Marvell/Cavium OcteonTX Suneel Garapati
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 01/29] include: pci_ids: add vendor ID for Cavium Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 02/29] include: pci: Increase max pci region limit Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 03/29] fdtdec: add API to read pci bus-range property Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 04/29] drivers: pci-uclass: fix incorrect argument in map_sysmem Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 05/29] drivers: pci-uclass: make DT subnode parse optional Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 06/29] drivers: pci-uclass: add multi entry support for pci regions Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:07 ` [U-Boot] [RFC PATCH 07/29] drivers: pci-uclass: add support for Enhanced Allocation in Bridges Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 08/29] drivers: pci-uclass: add support for Single-Root I/O Virtualizaiton Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 09/29] drivers: pci-uclass: add VF map_bar support for Enhanced Allocation Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 10/29] drivers: pci-uclass: Add support for Alternate-RoutingID capability Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 11/29] include: arm: asm: io: add 64bit clrbits and setbits helpers Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 12/29] drivers: rtc: ds1337: add driver model support Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 13/29] arch: include: octeontx: add headers for OcteonTX Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-11-20 5:47 ` Aaron Williams [this message]
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 14/29] arch: include: octeontx2: add headers for OcteonTX2 Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 15/29] drivers: ata: ahci: update max id if it is more than available ports Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 16/29] drivers: ata: ahci: fill upper 32bit buffer address in sg descriptor Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 17/29] drivers: ata: ahci: add BAR index quirk for OcteonTX Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 18/29] drivers: pci: add PCI controller driver " Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 19/29] drivers: gpio: add GPIO " Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 20/29] drivers: i2c: add I2C " Suneel Garapati
2019-11-20 3:00 ` Simon Glass
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 21/29] drivers: spi: add SPI " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 22/29] drivers: mmc: remove static qualifier on mmc_power_init Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 23/29] drivers: mmc: add MMC controller driver for OcteonTX Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 24/29] drivers: mtd: nand: add NAND " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 25/29] drivers: net: add NIC " Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 26/29] drivers: net: add NIC controller driver for OcteonTX2 Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 27/29] drivers: watchdog: add reset support for OcteonTX Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 28/29] octeontx: Add support for OcteonTX SoC platforms Suneel Garapati
2019-10-29 21:08 ` [U-Boot] [RFC PATCH 29/29] octeontx2: Add support for OcteonTX2 " Suneel Garapati
2019-10-30 17:06 ` [U-Boot] [RFC PATCH 00/29] arm: Introduce Marvell/Cavium OcteonTX Tim Harvey
2019-10-31 0:04 ` [U-Boot] [EXT] " Aaron Williams
2019-10-31 19:12 ` Tim Harvey
2019-10-31 19:22 ` Chandrakala Chavva
2019-11-05 1:09 ` Aaron Williams
2019-11-05 16:07 ` Tim Harvey
2019-10-31 19:46 ` [U-Boot] " Suneel Garapati
2019-10-31 22:14 ` Tim Harvey
2019-10-31 22:40 ` Suneel Garapati
2019-11-01 16:07 ` Tim Harvey
2019-11-19 18:55 ` Tim Harvey
2019-11-20 3:00 ` Simon Glass
2019-11-20 20:41 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7858878.Ac3pANyQ8F@flash \
--to=awilliams@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox