public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Simona Toaca <simona.toaca@oss.nxp.com>
Cc: uboot-imx@nxp.com, u-boot@lists.denx.de,
	Stefano Babic <sbabic@nabladev.com>,
	festevam@gmail.com, peng.fan@nxp.com, alice.guo@nxp.com,
	simona.toaca@nxp.com, ye.li@nxp.com, viorel.suman@nxp.com,
	ping.bai@nxp.com, sebastien.szymanski@armadeus.com,
	ravi@prevas.dk, joao.goncalves@toradex.com, ji.luo@nxp.com,
	tharvey@gateworks.com, qijian.guo@nxp.com
Subject: Re: [PATCH v2 5/5] doc: board: nxp: Add Quickboot documentation
Date: Wed, 18 Mar 2026 21:32:33 +0100	[thread overview]
Message-ID: <78c40910-a90c-4cef-ba72-4e4cdfd5abe2@nabladev.com> (raw)
In-Reply-To: <becryuzd7ohecs7vq2goxhfv5fsrjh6a3ctav77y4uxrszzecd@wsnoc3muqoit>

On 3/18/26 3:20 PM, Simona Toaca wrote:

>>>> Can QB data be saved to arbitrary SPI NOR ?
>>>>
>>>
>>> No, this SPI NOR refers to the SPI controller selected by
>>> the CONFIG_SF_DEFAULT_BUS and CONFIG_SF_DEFAULT_CS options.
>>
>> Maybe the user would want to make a backup of the QB data to another SPI NOR
>> (e.g. if the device has two, which is not unheard of) ? They should not be
>> prevented from doing so.
>>
>>> The point is that the device we save the data to is also an
>>> option to boot from, otherwise the qb data is useless.
>>
>> The QB data could be stored for backup purposes, that is not useless.
>>
> There is one thing that might make this clearer, and I forgot to
> mention it explicitly:
> 
> The get_qbdata_offset method searches for a 64KB hole in the bootloader,
> so it can save the data there. OEI knows that's where the data
> should be saved. On an arbitrary non-boot device, or, on a filesystem
> partition, the hole would not exist. It is mkimage that puts that
> hole in the bootloader, and U-Boot explicitly checks for container
> header tags.

Uh, is there any danger that this might accidentally corrupt the 
surrounding bootloader ?

> If one wants to store the data elsewhere, they could use
> the generic fs methods to make the backup wherever they want, and re-load
> it themselves to the QB_SAVED_STATE_BASE address, so that U-Boot can save
> it from there.

It would be good to document this mechanism, esp. how to locate the QB 
data in RAM and how much data have to be saved into backup storage.

>>> And the
>>> board will boot from the selected configs if one boots from spi.
>> Please see above.
>>
>>>> Looking at this, why can this QB not use the same interface to select
>>>> arbitrary block storage device/partition/... that e.g. FS_GENERIC does use ?
>>>
>>> There is a limited list of boot devices. By keeping things the way they are
>>> we limit the usage of this command to the actually useful boot devices (and
>>> that we also test this command on).
>>
>> I would argue that it is better to use generic code instead of hand-writing
>> local ad-hoc implementation which is a limited version of the same.
> 
> In the above context, using filesystem methods might not
> be feasible.
Look at cmd/blk_common.c , that is not filesystem, that is generic 
interface for block devices.

  reply	other threads:[~2026-03-19  0:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:15 [PATCH v2 0/5] imx9{4,5}: Add Quickboot support Simona Toaca (OSS)
2026-03-16  8:15 ` [PATCH v2 1/5] imx9: Add support for saving DDR training data to NVM Simona Toaca (OSS)
2026-03-16 12:13   ` Marek Vasut
2026-03-17 12:36     ` Simona Toaca
2026-03-17 12:45       ` Marek Vasut
2026-03-16  8:15 ` [PATCH v2 2/5] arm: mach-imx: Add command to expose QB functionality Simona Toaca (OSS)
2026-03-16 12:20   ` Marek Vasut
2026-03-17 15:28     ` Simona Toaca
2026-03-17 17:13       ` Marek Vasut
2026-03-16  8:15 ` [PATCH v2 3/5] imx9: Enable QB data saving for iMX9{4,5} EVK Simona Toaca (OSS)
2026-03-16  8:15 ` [PATCH v2 4/5] board: nxp: imx9{4,5}_evk: Add qb save option in SPL Simona Toaca (OSS)
2026-03-16 12:22   ` Marek Vasut
2026-03-17 12:40     ` Simona Toaca
2026-03-17 12:47       ` Marek Vasut
2026-03-16  8:15 ` [PATCH v2 5/5] doc: board: nxp: Add Quickboot documentation Simona Toaca (OSS)
2026-03-16 12:32   ` Marek Vasut
2026-03-17 12:53     ` Simona Toaca
2026-03-17 17:10       ` Marek Vasut
2026-03-18 14:20         ` Simona Toaca
2026-03-18 20:32           ` Marek Vasut [this message]
2026-03-19 15:17             ` Simona Toaca
2026-03-19 18:02               ` Marek Vasut
2026-03-20 15:29                 ` Simona Toaca
2026-03-20 16:29                   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78c40910-a90c-4cef-ba72-4e4cdfd5abe2@nabladev.com \
    --to=marex@nabladev.com \
    --cc=alice.guo@nxp.com \
    --cc=festevam@gmail.com \
    --cc=ji.luo@nxp.com \
    --cc=joao.goncalves@toradex.com \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=qijian.guo@nxp.com \
    --cc=ravi@prevas.dk \
    --cc=sbabic@nabladev.com \
    --cc=sebastien.szymanski@armadeus.com \
    --cc=simona.toaca@nxp.com \
    --cc=simona.toaca@oss.nxp.com \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=viorel.suman@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox