From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C6EFC433EF for ; Sun, 5 Dec 2021 14:03:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 08C5483018; Sun, 5 Dec 2021 15:03:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=t2data.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=t2datacom.onmicrosoft.com header.i=@t2datacom.onmicrosoft.com header.b="hcuDCLC6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 222CA82DB4; Sun, 5 Dec 2021 15:03:42 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0620.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::620]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1487F83025 for ; Sun, 5 Dec 2021 15:03:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=t2data.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=christian.melki@t2data.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMCnoDJJYvQArZsAad5BXI4XQr1USojdgN6F/v6ND9pg6JZDJh2uqNC6OVp1c6Hm2Z1mzXt7KQFoD+5xc0jnCI2OPnA7YHXn3vRt+EomHus1DapiOO43gNSJZt5qEb2zLjl+Djr8pgcr7U5N+pWjwJG5ADB+4S21KeV8ZKeunD6Yubxraniji43pQc2yVJUIisGiOI7QCgEfXc6Q6ZojY6spWFEaAmzS0kHPH7kGAFzUQddytNwplA8DBixLVITHwAMgYXbY01lC9cX3qyNHF/t4f9TqkoftHlBSebeDCEdIK9YVaqVwuYewCKPXVmNj27rjxiYXehqXR2Khn0mAZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoVIGdiJNcGUIXEodFuIeEyaS2tTo55vx0PJyBaXttk=; b=dd4rNQ+KmlvTFAe/sZ4Y2/AM+SS9l8G0nYIkqYLxpoELzisHBouf/3IebZ2Fl5d6t6LRDs6ao3qXx4e+JAsBGyR7ezAFQ2ReFCYR3unETQS+HHcR49vZyyh1Awq4rRkEPrn1dOumc1b9IjT1XNUi9R0tleW2QOr7NGCA9dy5FPyZYU0sT32HT69si1Fzsm6KNyxbcnec29KpTjFhCbP0o3Ppg/QmP4aq++40Rj6EQyZXG0SgPTRIyJo1YDqAeZLo0j9CjzQyNe1WgvPl2a1DxBAQUpqAOXAj8g7u3yB3k8OD7rAUTZ1BWxWcW1L7Ki1xWQb6L9gHHWvcj4Zc/ON7Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GoVIGdiJNcGUIXEodFuIeEyaS2tTo55vx0PJyBaXttk=; b=hcuDCLC6JmbUl2t7QEKlVRYTc4R7OLAY5JqbNyAew2Uuaybz/xlROvmlmSGZtkLdFCurn3pgU6vZGtf4lVZhG1yr/qFQmrYmtAYsn4/ghjbB1a50Lx3xBxNCU4vrD5+gJKxjzTKB9Ut9jPnQky/Ii0Vire7zWj0SO5dyA3IFaT8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=t2data.com; Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by DB9P251MB0403.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:327::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Sun, 5 Dec 2021 14:03:37 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::cc24:927c:bd00:a0cf]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::cc24:927c:bd00:a0cf%9]) with mapi id 15.20.4734.024; Sun, 5 Dec 2021 14:03:37 +0000 Message-ID: <78eb5d86-5a1d-9823-46df-68fc3f9f153d@t2data.com> Date: Sun, 5 Dec 2021 15:03:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v5 27/28] x86: efi: Set the correct link flags for the 64-bit EFI app Content-Language: en-US To: Simon Glass , U-Boot Mailing List References: <20211204155657.2913911-1-sjg@chromium.org> <20211204085647.v5.27.Id52316b4a3898ba8dff4c085a2c320173e7b35ea@changeid> From: Christian Melki In-Reply-To: <20211204085647.v5.27.Id52316b4a3898ba8dff4c085a2c320173e7b35ea@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: GV3P280CA0110.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::17) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 Received: from [192.168.7.217] (81.234.39.46) by GV3P280CA0110.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Sun, 5 Dec 2021 14:03:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 037a8dbb-72c1-4cc4-b196-08d9b7f8087c X-MS-TrafficTypeDiagnostic: DB9P251MB0403: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WEgpE7H8hQMMUNBx9XAVE/BEANJPNekJ28GH9Y+i64EePCPS2amsqF2MC6xVh3K2TujOWjJUxENnpiAi1rRCesCR2cijGGUdqEcssGUCpFDfeeQj2U4+wooOiNKbjab7Bsb6IR1HAT4CZZy2anNtep2Is49bD9xcWeX/1aJtaQ+kScO/GbU93izyvl2lyHUDst+LMNAEDvXGRDqRxCH5qALgbclFADW1UnxgC/mYEa7DBoAHo8Z9m5WyKXNtyZIyff+cJ/PC27kmSRqYmR8pHRKN/MSmSB4AEEoa58prqs7RODWKuTTftJW/koG+J/TkKbKQIsXDPHHwljxHfSKqiCymEAvYiHRyoG1cRmktt254IhxEFb4p2jt3lqwQ0g2zRve3q+W7sPyHqZdwTpI6ScKntUgw0pKyKxvP2zgNdwz9nlQMO1kuE2/5M+lurnjtrFgcQfmCEgEq/h3QmMmhlWHtDSyp5D6k9+OLZOkgKmjuVsKe9KjnBBk0M3bQEPww7hYXkgAu8jXzQ5e7VynqLHO/iujl1WlPT7TcYiD43RKUEzOxlrOpBxQAsUf0pA8/E07QGUEfosxIa11RlF0Exfpt5stTaQEsM/oREsNF4bY57PmR2kxIimMtMLOQthYp6cLBaXqnTTLo/x/7GkVlqiGtiaJEyEJ3fczLw87kkwcWXhwiGE0YnIgLKHUn2qv4YtJbnyb7tpl9IncKULTm7hub8FCmTx90RonzMyHzoRFrbK4MHK6nTtqPjghMKua7lV0bGUO835cxQb1FOuM9GA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(136003)(396003)(366004)(376002)(346002)(42606007)(39830400003)(5660300002)(66946007)(508600001)(38350700002)(6486002)(53546011)(38100700002)(8676002)(6666004)(83380400001)(110136005)(44832011)(31686004)(956004)(52116002)(2616005)(36756003)(86362001)(2906002)(26005)(8936002)(16576012)(186003)(66476007)(316002)(3450700001)(31696002)(66556008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVF6aWl5U3huY3hmaUJMS2JndFRNMzl2N1ErcWEvQ2NsNjE3bXp4TFpUZWFi?= =?utf-8?B?WHJ0dWYrNm5mcXlBVGRxRHRTRnBubXZEOW9rV3Q5QlhuNXpXblBuNVQrMWVu?= =?utf-8?B?bDhlSDJ4WUdVV2swRkE1M1ppOU56TFpIbU9FOFZqNmM5cmZ0U2syQUVGOW1H?= =?utf-8?B?ZWExWFZ4RGlRNkZpRFRTRjhmY1VOY0g1c3hycVJVYVVnU1pKUDc2RVpKSlBX?= =?utf-8?B?c3RVMStFWDB2QlZRSW1iK0pjY28yWGROR0hGaGRKT1RXQ256YTdCN0lWazBl?= =?utf-8?B?L0xyWUJFODV5M204M25JMGdpTXRDaklvamtUQzkxYWFualNWU2lQd3pTQ2Rs?= =?utf-8?B?S1JFSk1Ed2Rpdm1rT1Zlb09Mci8xM21xQ0dnVmV4anJ5OEJGVGlKd3RKT29O?= =?utf-8?B?OXFicTZQaEQ3UE5yTzBKbkxHSnUvaHVQQVpWMDdtU1NyK2xSTWlJUzRWZkRK?= =?utf-8?B?M2oyckN2WUVRSmJHLzltWk04dUg4Rnl5K3Y4VndJOG1RYXJuTWRVUTduRy9n?= =?utf-8?B?bHRhajB0bnZsQ0RQV1N2eHhhcDhCbVAwNVZrZS9LcXlKK0dNUW9CUTlrRktB?= =?utf-8?B?S2l3eUk2Q2F0WUdYYUF0dUJWMGtJc0JvaE1zbDF6UTEwb0k5YjF0SURuTXpS?= =?utf-8?B?bHZQZGZVcHhGMXJORWFJaUgwYkNBK0pCbDV6OGJYOVlnVEdjL2o5ODZQRStU?= =?utf-8?B?czhSMmNHZDNLL0NZaWxaZE9yNEFIeHZjYkEwTm1WQlI4ZmRvYlB0TUFqR2JJ?= =?utf-8?B?aDFJMDZkRW52bGhQYzZ4YzA4RXYvMXFwZnd2UFB0TjFnYVpYbmd6Yy9NY2tS?= =?utf-8?B?L0lzcHlYZmpEbmRFYVF4N2RadHhkRzl5UEo2cjJ6b1ZQTGRqdjN1RnIzcTBi?= =?utf-8?B?QnlxOTJFT0JqRG9ESEF6anNkbzlVakNZTVVlSDJpblVqRmdZZm9IUW1JemhZ?= =?utf-8?B?bnVVVWpVKytFNHhXdmgyNDc3ZkhRZnByTzlPYXRicDlDVGhENjV4akNCVFVQ?= =?utf-8?B?enZibGNvaGRxYmp3dmhOUGpnazNUUGJPSHkwcXd5akJ6dkRoVFNrdEhSdTY1?= =?utf-8?B?VW1oUUpDQksyZ0EvSzBmRUtlZk5aZ3B1MjdvMmcvTlVMc3pGMS9PUkkvM2pO?= =?utf-8?B?TGo1aFFvb2M3OG9WbEdzRHFtVXFMT3hCOHArZFZpcFhBTGVPNjNUMkN5d2JU?= =?utf-8?B?L3c0NGU4UXlRa01QWUpZZmFObXR3NlJqTk9JOU9zakNnbzRQQTZycTNzRnNJ?= =?utf-8?B?YzhBTlRkSExxdXVBanRFL1dLNnlMajNaRE9XV24raGZMQm1waGk4OG5YdXF5?= =?utf-8?B?VnZxbFVkQk8rY0xYV0p2NW1pMmMraFAxSlNyRDdjejNmcGhYc0hxNkFvRGt2?= =?utf-8?B?Z2NCMkY5czVZL0lHbmh3Q3YrQTloL2FHTGtlcXAzbUk0N3RMUCsxaGpETXhG?= =?utf-8?B?YXE4c3JKOXhmTXFlTnhkVFVmbVdPRm5qcERPUGhiMjUvb2Jvejl1ZGZKbnBP?= =?utf-8?B?RW0vVGhxV0tzM1hlQ1BKVlhkL3oyRUF3N1E4aXZXajdqaFBzOFhoUjd3dUJM?= =?utf-8?B?MUIxWUplQUhSRHExY0pMVWtudjN4eElTSGRXSVRtZzEyV1BQWDJ3eHdMOVBZ?= =?utf-8?B?RjhIQ29aQXJUSWtXQjQ2TkV3Z2d1TUk0eXhMUFMxTHZNT2pZRjQyWkdOWXNS?= =?utf-8?B?eUsvWVVyL29yeUJhSWdhSjdOT0pmNkE0VkNFRUdOK2xycGt1bk1uMEVIVHI3?= =?utf-8?B?STRaK2Y0OEVZSzArYks1MTNVSng4b3pjYjMzdXplRTZnZUllWWd2K3F1Q2FV?= =?utf-8?B?c1lUbG1ZZTFqc0VLV2ZuU0VkNy9jZCtLeDRwQldvYmJnWXYxWTZEbWlFTm12?= =?utf-8?B?RVRpYW01bFI5blQ5Nm4yVkZNQjRwQUVJVDNqMitaVFZJbHkvbW5SYUxFbDJk?= =?utf-8?B?aDExVzZlaThwREhtenUvMGJkbjBNMzRUaGdBdVZrZWptZ3ZhMDhsOEcvSnhL?= =?utf-8?B?OFdBOXNGVHRMbzBUaFNHVC9oR1c4dlMxOHlCOWhiTGhGSHZhekxtNmxLZ001?= =?utf-8?B?SkNTdy8vTUdiWmxjN1hxZy9nUElaQ2pDbjlJbFdWZmxxUlJ1ZC9BRldqVDB3?= =?utf-8?B?WENmRzBJRENJRHFoZHg3QWZRWFY2Z1dkMXMxY2dUZlU0TVJwMVJvK29LbjJQ?= =?utf-8?B?WCt0N0ZqWUkwT1ZkQ1lub3lwdG9zdW5XZ1ZBODIvN2F6Vk4xd3VEVlJKdTI2?= =?utf-8?B?NzdiR3RJajRBd3dZL24xSStzZUx3PT0=?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: 037a8dbb-72c1-4cc4-b196-08d9b7f8087c X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2021 14:03:37.3062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q4v43UFjHgHr3GzeJLB9mPP0JgFMfD9KdlBInVVFZwYIyGdy0mcG9KEDVazWbytq/kpg5xrCghin/HlqQNJvZLhyqsYjRctWoZyKFFd2Eps= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P251MB0403 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.melki@t2data.com Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/4/21 16:56, Simon Glass wrote: > At present some 32-bit settings are used with the 64-bit app. Fix this by > separating out the two cases. > > Be careful not to break the 64-bit payload, which needs to build a 64-bit > EFI stub with a 32-bit U-Boot. > > Signed-off-by: Simon Glass Signed-off-by: Christian Melki > --- > > Changes in v5: > - Add new patch to set the correct link flags for the 64-bit EFI app > > arch/x86/config.mk | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/config.mk b/arch/x86/config.mk > index 589f2aed2bc..889497b6bd7 100644 > --- a/arch/x86/config.mk > +++ b/arch/x86/config.mk > @@ -20,6 +20,11 @@ IS_32BIT := y > endif > endif > > +EFI_IS_32BIT := $(IS_32BIT) > +ifdef CONFIG_EFI_STUB_64BIT > +EFI_IS_32BIT := > +endif > + > ifeq ($(IS_32BIT),y) > PLATFORM_CPPFLAGS += -march=i386 -m32 > else > @@ -44,8 +49,14 @@ CFLAGS_EFI := -fpic -fshort-wchar > # Compiler flags to be removed when building UEFI applications > CFLAGS_NON_EFI := -mregparm=3 -fstack-protector-strong > > -ifeq ($(CONFIG_EFI_STUB_64BIT),) > +ifeq ($(IS_32BIT),y) > +EFIPAYLOAD_BFDARCH = i386 > +else > CFLAGS_EFI += $(call cc-option, -mno-red-zone) > +EFIPAYLOAD_BFDARCH = x86_64 > +endif > + > +ifeq ($(EFI_IS_32BIT),y) > EFIARCH = ia32 > EFIPAYLOAD_BFDTARGET = elf32-i386 > else > @@ -53,8 +64,6 @@ EFIARCH = x86_64 > EFIPAYLOAD_BFDTARGET = elf64-x86-64 > endif > > -EFIPAYLOAD_BFDARCH = i386 > - > LDSCRIPT_EFI := $(srctree)/arch/x86/lib/elf_$(EFIARCH)_efi.lds > EFISTUB := crt0_$(EFIARCH)_efi.o reloc_$(EFIARCH)_efi.o > OBJCOPYFLAGS_EFI += --target=efi-app-$(EFIARCH) >