From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Fri, 3 May 2013 17:09:34 +0200 (CEST) Subject: [U-Boot] [PATCH V3 2/2] arm: mx5: Add support for DENX M53EVK In-Reply-To: <568408995.526788.1367593153328.JavaMail.root@advansee.com> References: <1366920963-8646-1-git-send-email-marex@denx.de> <1366920963-8646-2-git-send-email-marex@denx.de> <568408995.526788.1367593153328.JavaMail.root@advansee.com> Message-ID: <793106687.527293.1367593774448.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, May 3, 2013 4:59:13 PM, Beno?t Th?baudeau wrote: > Dear Marek Vasut, > > On Thursday, April 25, 2013 10:16:03 PM, Marek Vasut wrote: > > Add basic support for the DENX M53EVK board. Currently supported is: > > MMC (incl. booting) > > NAND (incl. booting) > > Ethernet, I2C, USB, SATA, RTC. > > > > Signed-off-by: Marek Vasut > [...] > > diff --git a/board/denx/m53evk/m53evk.c b/board/denx/m53evk/m53evk.c > > new file mode 100644 > > index 0000000..3289f28 > > --- /dev/null > > +++ b/board/denx/m53evk/m53evk.c > > @@ -0,0 +1,408 @@ > [...] > > +#ifdef CONFIG_USB_EHCI_MX5 > > +int board_ehci_hcd_init(int port) > > +{ > > + if (port == 0) { > > + /* USB OTG PWRON */ > > + mxc_request_iomux(MX53_PIN_GPIO_4, IOMUX_CONFIG_ALT1); > > + mxc_iomux_set_pad(MX53_PIN_GPIO_4, > > + PAD_CTL_PKE_ENABLE | > > + PAD_CTL_100K_PD | > > + PAD_CTL_DRV_HIGH And here you set PKE without PUE, which means that PAD_CTL_100K_PD will have no effect on the pad, i.e. the keeper will be enabled, not a 100-k PD. > > + ); > > + gpio_direction_output(IOMUX_TO_GPIO(MX53_PIN_GPIO_4), 0); > > + > > + /* USB OTG Over Current */ > > + mxc_request_iomux(MX53_PIN_GPIO_18, IOMUX_CONFIG_ALT1); > > + mxc_iomux_set_input(MX53_USBOH3_IPP_IND_OTG_OC_SELECT_INPUT, 1); > > It looks like there is something wrong here: The last line connects OTG.OC to > EIM_D21.ALT6, but the line before sets GPIO_18 as GPIO7[13] instead of > setting > EIM_D21 as OTG.OC. Best regards, Beno?t