From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Wed, 20 Jul 2011 12:06:25 +0530 (IST) Subject: [U-Boot] [PATCH 1/4] gpio: Adds GPIO driver support for Armada100 In-Reply-To: <20110720060234.E72941579DF2@gemini.denx.de> Message-ID: <794341286.33968.1311143785027.JavaMail.root@ahm.einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, > > Is there any specific reason for not using u32 for the padding as > well? > nothing specific. It makes easy to find number of bytes than words. > > Why would you need this BASE + OFFSET notation when using a C struct > for the registers? Thi smakes little sense to me. > Well I did use the C struct method, if you see my patches submitted earlier but according to Prafulla and Lie structure size is too big. so they want me to use a mix of C struct and BASE + OFFSET notation. so I thought to break the big C struct into smaller grouped structures pointing each group with GPIO base + group offset. I would be glad if you can suggest me something better or smarter. Regards, Ajay Bhargav