From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA99CC32771 for ; Fri, 19 Aug 2022 09:54:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D4A884B03; Fri, 19 Aug 2022 11:54:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.se header.i=@prevas.se header.b="CbJ3A/5P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4EF4484B14; Fri, 19 Aug 2022 11:54:21 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2133.outbound.protection.outlook.com [40.107.104.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D31384996 for ; Fri, 19 Aug 2022 11:54:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4dSKgXZ1nQfSZecVegWgbZ+cjppPqU4FCt8B2rFXrQzXxQukJ7xaFnIL+b75W3lMu4m8HpI+Y6mht9QCeNKNgG5XGGRrSZrHD2Jv8HgTs4ApB7P0O8kacRTRct9NMaILHLofQ+yu+Jzw2z33OlIB/3WRClRYgmZ5YguvEP0dpGqddJqrAeoKjIAjPxH2D6A5CmKm8V5kuQS1X5UVOsXbdOvKZFyA9nY7YUW6PkdKPCR3DLmWHamATLSQMjcxmmxj3n9pE3w5F/M4WrP2dyMu3IIXP63KPcB7yLT1f9SfAPQRJKLk+lgJsDcvFhTrobNTEk4YrRSsPQ6Vj20SUcxUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oIPK65NL1xB/JxVbyNiNuUIDap4GHMmai7OB7MsWcBQ=; b=QCgPJ2tSUiW0iwpH5AvZ91Jx1te13xnR+YKrzcJSvCYI9InQLnwfYCUKeR2wfYZ4xc8MkUyY95lKjRrrpzXv7VOWNCVU2dMxXxOFlQbagTffZDADj8RXktexOdm2x4STNtW+HCVje6DNWGzRISdQKsHglPtRfBBME9URNQZFKwcihKlSqdNgYMWe/XuL+gQAQZZERmDBn544+uLLMiMNTbuYk53hCZQlqcRIahN0A6kxbPJK5mXlG7UVgJQrVUNNRB29VPsYeH7TajY/LUwRzW0/k3f3vfQpwidTtGVHUSczOk+pORdnrK13MJNy+EDZ6wSAqQj4tzZM+T/3Y2avnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.se; dkim=pass header.d=prevas.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oIPK65NL1xB/JxVbyNiNuUIDap4GHMmai7OB7MsWcBQ=; b=CbJ3A/5PFERizQOlhovx450FdJPiHSM8o3m/7Hax97zB20crq87Mm0C9R9RzK6dCmEcnyre4NOcUtKv+AdgSFMocKPVhq9mn1EYvNpS6C0w4EFPOxntKPz9nLAUJvDmjzd0vPJsceEZ5ZTAd2g2yWd8mEBZCvYK8J/MApE0BgXU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.se; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by AM5PR10MB1555.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:19::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Fri, 19 Aug 2022 09:54:16 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::84cd:fa2:ffc0:456e]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::84cd:fa2:ffc0:456e%9]) with mapi id 15.20.5546.016; Fri, 19 Aug 2022 09:54:16 +0000 Message-ID: <79937b56-01eb-a5d9-b6e8-6b62ba3bb059@prevas.se> Date: Fri, 19 Aug 2022 11:54:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Makefile: Use relative paths for debugging symbols. Content-Language: en-US To: Vagrant Cascadian , u-boot@lists.denx.de Cc: Vagrant Cascadian , Heinrich Schuchardt , Simon Glass References: <20220818173133.12552-1-vagrant@debian.org> From: Rasmus Villemoes In-Reply-To: <20220818173133.12552-1-vagrant@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MM0P280CA0051.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:b::35) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e03c8b06-8f93-41cd-0048-08da81c8c759 X-MS-TrafficTypeDiagnostic: AM5PR10MB1555:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RtVkTewwyugf0IST8LauQWu8lpAPtRg9eTwk9Bg8J5L0RQuIiRFma3H8HGv3E4SRWf9YwiONgJsbUv3No1DYTohP1S+/613PmKjplXU2LUeYGqQ+tSQxbhx/jy6k4K35JkbMeOvGvXIMBcKtd0xJ5KDsCI27ogpdzICKHlDbJC1pi1KHmkik5csy7o2ZBMf3NKg4lvhH6V9491tkCXRaPc/xUGlpR4tUeeWAEEcY3gDkkBs3SLs6GhE8n8UJvl16HMiH4c95lJIgucd3H4OdA6rsy7hj7Ty9dl35gZD/dS4r3rwVwebVpOigYfEBk5bWmtmMWJAgDCtRFipd9gVVfIm17oY6hrg01aEy14nCeuW1j242fNXGrorozJ7rvQ//erHbjVSk/Hqe2Fzyb/be8oPOH/IKBSvQ1nIPfGKYvrx+6mYCUDSkSQm8Z5EVG9G69AhRRXJfuC/fK3VugjWfkuzMLqo8NZxMcaRNiqPsLJRj1WgM48+4OxRoAfg8V86wM6MYEcwDVR9/E9S071ZZ/loNcDccDtk9zofJ1zcQUGi2J1EGKDjxDRAJtomELctCe4ryZS1gWuRhCdV8MTIed7oiSTVIltrwYo13Uha6/Fa2smAcpxSihk16v7I0WRWofZRfQfLvwQ5b2SH+bXl7jUxcrX1Xe907v4NeHxvwjXcetZ+sJD/O1jdx76FxZVC3tj8rovZVX0drlW7x1ceIZNekNaSIWXAN1o6hQgtTddrVPn2mr+NhQl2xxsQtqEhXombg4CzTUMywkHpVb88DOWdJgKeel2YTaxieavTAIKvXc3JHhPedfs0EZ2nl4F/UJ5tS8tlIGter2jLhtQA6BJkmG79G4U3GirCM1JpC5GY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230016)(346002)(396003)(136003)(366004)(39850400004)(376002)(36756003)(38350700002)(31696002)(316002)(38100700002)(83170400001)(31686004)(54906003)(2906002)(41300700001)(26005)(4326008)(186003)(5660300002)(8676002)(6486002)(52116002)(66476007)(966005)(44832011)(6506007)(2616005)(66946007)(66556008)(83380400001)(42882007)(6512007)(8936002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXlJbTBCTVpROUV4UXNoRHp2L1NOTy91Z2VFcTZ6M1E5S1I5M3NndE9oSy9Z?= =?utf-8?B?OU01Mm9qTllobWd5M3doLzVRSVF5bEtPY1hVN0pmaWNMV1dBbk91TncyckRh?= =?utf-8?B?RHVmZmVxRTZIVjhHUlhJSVdKNnZNQzlaT1pXaDRURkt1cllpNnQ2SnB1SHBK?= =?utf-8?B?YnFxbzMzNkpjNkswb3BMS3ZCdnprQ202YlNWME9hYldBMnU5UDE0OFIycFdJ?= =?utf-8?B?WVJiWmdjb1pYcktGclRGSWtXT21BUmZaYnVvY1hZSEtCRldkd1AzQVNZeXNX?= =?utf-8?B?NWY1RjNnNGtCcWYwSDVFVlo4YlMzZDR4V3J6N0lacWVCUm9odHJwK3RVTmc0?= =?utf-8?B?UmhxWjZOaEVlY3VMMXk1WGtVckp5dzE3UDQ5OTdab2RLT0dJb2tSTnBQNnNl?= =?utf-8?B?R0liNlpzbzc5WitFbzloWmhHNTJwWlFsOTdEdUdnZHZveEhudTdrY0ZjWUN6?= =?utf-8?B?aVdHQ2JOOVl1VXBWRm5iaWlPRElpK0ZvSGF3a1lKLzEramRxUXFldFZWbGhS?= =?utf-8?B?NnpWNWFLQ2h3NERycjFLMWVBM2djT0dNT2ZXUTFhTjBIYnpYb3o5SHMvYkln?= =?utf-8?B?SmcrOVExM0JsLzdEdjlRZVJoNnpGdUdIclUrZDh0UTVabm1nc0poY3BYVDE4?= =?utf-8?B?YnQzOERIbXM3K0dUUG4vdFBJTlFIVURpKzJzMUxWVEtyQVp2Vm1XTGRSS1Rw?= =?utf-8?B?VDdJT3owVTViaWRYOVJ5ZWk5eFJGaHlkVlhwN3BXV1lkMXMyRFFjbTRCOTRW?= =?utf-8?B?VWpYLzZTcEhESDRkdldlamRWU21GTHdDeEFhS3F5WXRnOTB3b0pQYzhOSFZ1?= =?utf-8?B?RDh3a0lIaUdQTmE5OHByelVYNEN0ck43ZUVpcmdmZXVudUVDUUtMdzMyK25S?= =?utf-8?B?RGdXS2ZFQnpFWHgvUURQM0U3R0wzSXljWHE5MVVJOS9uNThDUEpEbVhteis5?= =?utf-8?B?WEZtcE5sMDZQL1JDZ0VaWnRadWxpOHdXQ2dDbG5UalJPWTBPRUE1dis4V2s3?= =?utf-8?B?QVhhMEN3Mnd3VkppUTNtbGkyaVJFT1k2dVhlUDJsOG94eUlqaHU1c0N5b1RL?= =?utf-8?B?L095TmtTbitvd1lCTmFmT0lGZkZyOGtvSnE5ZUxTVnBkNnBTcEkwanQvSmVw?= =?utf-8?B?OVF5S2JXOFJ1R1crVmdZZ040TWY1WEZSOFpJL2dhWVJDcC9MeFM5YkZRWUd5?= =?utf-8?B?QXFRUnJueTlzTFBaKzBCNGM5YTNBcFlIRUxWL0lUTDhlWnhONVBlZzVQZW0z?= =?utf-8?B?bnZaNFFtMVRRYVBBdWF4YmJpcEIxUkpFek9HZkxXRitTTnpQNFNWYTViRmN3?= =?utf-8?B?VlE3RHQ4bElCcHB3K2YyaXhWUXFWVmRDUFFtQnBvVFp3cEtiamdpOUZFNWVM?= =?utf-8?B?R091dUE1ZDdET0w1QkJ6YlZBOEpublRGQjBUOEd0VE1HbGYvTFluY2k4L08x?= =?utf-8?B?T0J3UWsxdXY1OVZRd2p5blIwd0lrZEJlc08vVDQwZHZsZzVyb3hUT21IUHFo?= =?utf-8?B?OWFtRktZekRWclQ4ekRIRUY3OEo2dUVOeHRmdEMvdWRSeFlLRGlVVUhsSzUy?= =?utf-8?B?OXdpOXpxeHZEdUhSOFRtdml0d1Z6SDM5MFNXclRoRUlUSVlVSFBHZVhGNGZL?= =?utf-8?B?T3NXek43T29sa2JWYk1QM1JUQk5DWmNQUGZ5VzFRT1A1Vlk3UVNEYytXR045?= =?utf-8?B?WjR4N1NJOUxnQTZjeU1CMUE2bDFxSCtkS2x2aTBXamdXNS9jN0hwaWlXbXM2?= =?utf-8?B?YlJiQWd4aHcrSms5aHpYQnh0M3FScW5IU3k0MXp0cmcwNkRESzRGWDVPcmpW?= =?utf-8?B?bGF2czZhVmlnTjFmT1ZiU0x0MnA3NzlTbU1sK0ttMVQ5VHlmRitYTFFCS2pI?= =?utf-8?B?Tk10UHZibFpVaEg2MVl4bXVuYlhWMHRvRldxUVJHamQ3TytPbWhXSm9YRXA0?= =?utf-8?B?eXdlcFVUVitSYlpCUmtMSnQyRjJnWC9uK2J1SEhIYytpYmJBc1FWbjB2SGkv?= =?utf-8?B?MDhYWWdvS0NVVS9BcFRMWG55aEwwN0paUjRzVVlPVDJiZkp0YWlzbEN6dXhn?= =?utf-8?B?N1ZXUWlXcVpNejFWK1dMS3VXazd0RHhCNU1SOENycFBtVkx1Y1hNbDYxTjZv?= =?utf-8?B?cWE4U2dYekhqcERsb3hFWUNoQkYvdFBwa1ErQnk1cnl4QTVHTTFCZkx6R3Rv?= =?utf-8?B?a2c9PQ==?= X-OriginatorOrg: prevas.se X-MS-Exchange-CrossTenant-Network-Message-Id: e03c8b06-8f93-41cd-0048-08da81c8c759 X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 09:54:16.6162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DHlP/fb28aJf5PXLIK/DYVHctPIbVGyPN4v7YXORHqkuK5wJgptjHcFZBuBLpbbOSIamSMoAXc0v/0txfAKsAnJxAib29AcHv3MAmzUm8sI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR10MB1555 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 18/08/2022 19.31, Vagrant Cascadian wrote: > From: Vagrant Cascadian > > The KBUILD_CFLAGS and KBUILD_AFLAGS variables are adjusted to use > -ffile-prefix-map and --debug-prefix-map, respectively, to use > relative paths for occurrences of __FILE__ and debug paths. > > This enables reproducible builds regardless of the absolute path to > the build directory: > > https://reproducible-builds.org/docs/build-path/ > > Signed-off-by: Vagrant Cascadian > > --- > > Makefile | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 1a66f69a4b..b40b9b2444 100644 > --- a/Makefile > +++ b/Makefile > @@ -751,14 +751,18 @@ KBUILD_CFLAGS += $(call cc-disable-warning, stringop-overflow) > # Enabled with W=2, disabled by default as noisy > KBUILD_CFLAGS += $(call cc-disable-warning, maybe-uninitialized) > > -# change __FILE__ to the relative path from the srctree > -KBUILD_CFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=) > +# change __FILE__ and debugging symbols to the relative path from the > +# srctree > +KBUILD_CFLAGS += $(call cc-option,-ffile-prefix-map=$(srctree)/=) You do update the comment, but it might be worth spelling out in the commit log that -ffile-prefix-map is a superset of -fmacro-prefix-map, and that both options are supported in the same set of compilers (so we don't lose the effect of -fmacro-prefix-map for some set of compilers), namely gcc 8. For reference, from the gcc repo commit 7365279fca30371b07e49bfa83a23ddc44cc3860 Author: Boris Kolpackov Date: Thu Jan 18 13:17:37 2018 +0000 Add ability to remap file names in __FILE__, etc (PR other/70268) This commit adds the -fmacro-prefix-map option that allows remapping of file names in __FILE__, __BASE_FILE__, and __builtin_FILE(), similar to how -fdebug-prefix-map allows to do the same for debug information. Additionally, it adds -ffile-prefix-map which can be used to specify both mappings with a single option (and, should we need to add more -f*-prefix-map options in the future, those as well). > KBUILD_CFLAGS += -g > # $(KBUILD_AFLAGS) sets -g, which causes gcc to pass a suitable -g > # option to the assembler. > KBUILD_AFLAGS += -g > > +# Use relative paths in debugging symbols > +KBUILD_AFLAGS += --debug-prefix-map=$(srctree)/= > + Hm, ok, it seems this has been supported in binutils since ~2007, so I don't suppose this needs some equivalent to the cc-option guard. Acked-by: Rasmus Villemoes