Re:Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support

["Andy Yan" <andyshrk@163.com>]

Hi Danq,

At 2025-03-02 12:09:34, "Dang Huynh" <danct12@riseup.net> wrote:
>Hi Chaoyi Chen,
>
>On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote:
>> 
>> Could you use a naming prefix like "rkvop2" to explicitly indicate the
>> use of vop2, thereby distinguishing it from rk_vop.c?
>> 
>Yes. This will be in v3.
>
>> > +	struct rk3568_vop_esmart *esmart = priv->regs + 
>VOP2_ESMART_OFFSET(0);
>> 
>> You are assuming that the RK356X is always used ESMART0, which generally
>> works. But considering
>> that there are multiple Video Ports and different Video Ports may have
>> different primary win,
>> selecting the appropriate win can simplifies the processing for U-Boot
>> to Kernel transitions in the future.
>> 
>> It's a good idea to implement the win selection as a configurable
>> parameter, or we can consider the
>> default win used for different Video Ports.
>ESMART0 is configured to the desired video port on U-Boot. VOP2 should be 
>reconfigured by Linux.

As you currently "Disable esmart and post before booting to OS",  So the current
approach won't cause any issues. But if one day we can make the U-Boot logo remains displayed until
kernel bootup completion, and if the u-boot logo is not displayed on the primary plane, there would be
no applications attempting to disable the u-boot logo，becasue Linux kernel logo or UI application always
select primary plane。
I am uncertain whether other platforms have implemented analogous considerations when chose which plane to show
logo within U-Boot.


>