From: Safae Ouajih <souajih@baylibre.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, sean.anderson@seco.com,
r.stratiienko@gmail.com, mkorpershoek@baylibre.com,
glaroque@baylibre.com, khilman@baylibre.com
Subject: Re: [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3,v4 support
Date: Thu, 9 Feb 2023 18:01:48 +0100 [thread overview]
Message-ID: <79ea2e45-fd43-2e41-c705-84b1bcd47d9d@baylibre.com> (raw)
In-Reply-To: <CAPnjgZ30utDHxq=m-KizvFmPSNzCdnbD-tu1-zQnEEqODdVq4A@mail.gmail.com>
On 07/02/2023 05:02, Simon Glass wrote:
> On Sun, 5 Feb 2023 at 16:50, Safae Ouajih <souajih@baylibre.com> wrote:
>> Introduce vendor boot image for version 3 and 4 of boot image header.
>> The vendor boot image will hold extra information about kernel, dtb
>> and ramdisk.
>>
>> This is done to prepare for boot image version 3 and 4 support.
>>
>> Signed-off-by: Safae Ouajih <souajih@baylibre.com>
>> ---
>> boot/bootm.c | 8 +++----
>> boot/image-android.c | 54 ++++++++++++++++++++++++++++----------------
>> boot/image-board.c | 3 +--
>> boot/image-fdt.c | 3 ++-
>> cmd/abootimg.c | 4 ++--
>> include/image.h | 48 ++++++++++++++++++++++++++++++---------
>> 6 files changed, 81 insertions(+), 39 deletions(-)
> I don't see a change log but I see some comments. Not sure what else I
> said on the review.
Only the comments changed to add the new partition
Thank you for the review,
BR,
Safae
> Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2023-02-09 17:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 23:50 [PATCH v3 00/19] Support android boot image v3/v4 Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 01/19] android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0 Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 02/19] android: boot: support vendor boot image in abootimg Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 03/19] android: boot: replace android_image_check_header Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 04/19] android: boot: add boot image header v3 and v4 structures Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 05/19] android: boot: kcomp: support andr_image_data Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 06/19] android: boot: move to andr_image_data structure Safae Ouajih
2023-02-07 4:02 ` Simon Glass
2023-02-09 16:30 ` Safae Ouajih
2023-02-09 14:26 ` Mattijs Korpershoek
2023-02-09 16:49 ` Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 07/19] android: boot: content print is not supported for v3, v4 header version Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 08/19] android: boot: boot image header v3, v4 do not support recovery DTBO Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3, v4 support Safae Ouajih
2023-02-07 4:02 ` [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3,v4 support Simon Glass
2023-02-09 17:01 ` Safae Ouajih [this message]
2023-02-09 14:29 ` Mattijs Korpershoek
2023-02-09 14:30 ` Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 10/19] android: boot: update android_image_get_data to support v3, v4 Safae Ouajih
2023-02-09 14:32 ` [PATCH v3 10/19] android: boot: update android_image_get_data to support v3,v4 Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 11/19] android: boot: ramdisk: support vendor ramdisk Safae Ouajih
2023-02-09 14:35 ` Mattijs Korpershoek
2023-04-07 8:56 ` Roman Stratiienko
2023-04-07 13:16 ` Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 12/19] android: boot: support extra command line Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 13/19] android: boot: update android_image_get_dtb_img_addr to support v3, v4 Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 14/19] drivers: fastboot: zImage flashing is not supported for " Safae Ouajih
2023-02-09 14:38 ` [PATCH v3 14/19] drivers: fastboot: zImage flashing is not supported for v3,v4 Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 15/19] android: boot: support boot image header version 3 and 4 Safae Ouajih
2023-02-09 14:46 ` Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 16/19] android: boot: support bootconfig Safae Ouajih
2023-02-05 23:50 ` [PATCH v3 17/19] doc: android: add documentation for v3, v4 boot image header Safae Ouajih
2023-02-07 4:02 ` [PATCH v3 17/19] doc: android: add documentation for v3,v4 " Simon Glass
2023-02-08 8:54 ` Mattijs Korpershoek
2023-02-05 23:50 ` [PATCH v3 18/19] test/py: android: extend abootimg test Safae Ouajih
2023-02-07 19:02 ` Tom Rini
2023-02-09 16:52 ` Safae Ouajih
2023-02-27 14:15 ` Safae Ouajih
2023-02-27 14:18 ` Tom Rini
2023-03-06 19:49 ` Safae Ouajih
2023-03-06 20:07 ` Tom Rini
2023-02-05 23:50 ` [PATCH v3 19/19] Dockerfile: add mkbootimg tool Safae Ouajih
2023-02-09 14:08 ` [PATCH v3 00/19] Support android boot image v3/v4 Mattijs Korpershoek
2023-04-05 14:41 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79ea2e45-fd43-2e41-c705-84b1bcd47d9d@baylibre.com \
--to=souajih@baylibre.com \
--cc=glaroque@baylibre.com \
--cc=khilman@baylibre.com \
--cc=mkorpershoek@baylibre.com \
--cc=r.stratiienko@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox