public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244@gmail.com>
To: dario.binacchi@amarulasolutions.com,
	michael@amarulasolutions.com, sjg@chromium.org,
	philipp.tomsich@vrull.eu, kever.yang@rock-chips.com
Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com
Subject: [PATCH v5 19/21] drivers: fix debug string with fdt_addr_t input
Date: Tue, 28 Feb 2023 22:22:08 +0100	[thread overview]
Message-ID: <79f29204-f0bd-b211-4111-e70bdc208172@gmail.com> (raw)
In-Reply-To: <d70fb562-db1f-2a6d-206e-55568176c228@gmail.com>

The fdt_addr_t and phys_addr_t size have been decoupled. A 32bit CPU
can expect 64-bit data from the device tree parser, so fix some
debug strings with fdt_addr_t to be able to handle both sizes.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---

Changed V5:
  new patch
---
 arch/arm/mach-mvebu/cpu.c       | 2 +-
 drivers/clk/ti/clk-ctrl.c       | 9 +++++----
 drivers/phy/phy-stm32-usbphyc.c | 4 ++--
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
index 329d1369..f58689e1 100644
--- a/arch/arm/mach-mvebu/cpu.c
+++ b/arch/arm/mach-mvebu/cpu.c
@@ -631,7 +631,7 @@ int board_xhci_enable(fdt_addr_t base)
 {
 	const struct mbus_dram_target_info *dram;

-	printf("MVEBU XHCI INIT controller @ 0x%lx\n", base);
+	printf("MVEBU XHCI INIT controller @ 0x%llx\n", (fdt64_t)base);

 	dram = mvebu_mbus_dram_info();
 	xhci_mvebu_mbus_config((void __iomem *)base, dram);
diff --git a/drivers/clk/ti/clk-ctrl.c b/drivers/clk/ti/clk-ctrl.c
index 6cc02d2e..8926e57e 100644
--- a/drivers/clk/ti/clk-ctrl.c
+++ b/drivers/clk/ti/clk-ctrl.c
@@ -44,7 +44,7 @@ static int clk_ti_ctrl_disable(struct clk *clk)
 	offs = priv->offs[0].start + clk->id;
 	err = clk_ti_ctrl_check_offs(clk, offs);
 	if (err) {
-		dev_err(clk->dev, "invalid offset: 0x%lx\n", offs);
+		dev_err(clk->dev, "invalid offset: 0x%llx\n", (fdt64_t)offs);
 		return err;
 	}

@@ -64,7 +64,7 @@ static int clk_ti_ctrl_enable(struct clk *clk)
 	offs = priv->offs[0].start + clk->id;
 	err = clk_ti_ctrl_check_offs(clk, offs);
 	if (err) {
-		dev_err(clk->dev, "invalid offset: 0x%lx\n", offs);
+		dev_err(clk->dev, "invalid offset: 0x%llx\n", (fdt64_t)offs);
 		return err;
 	}

@@ -125,8 +125,9 @@ static int clk_ti_ctrl_of_to_plat(struct udevice *dev)
 		}

 		priv->offs[i].end = priv->offs[i].start + fdt_size;
-		dev_dbg(dev, "start=0x%08lx, end=0x%08lx\n",
-			priv->offs[i].start, priv->offs[i].end);
+		dev_dbg(dev, "start=0x%016llx, end=0x%016llx\n",
+			(fdt64_t)priv->offs[i].start,
+			(fdt64_t)priv->offs[i].end);
 	}

 	return 0;
diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c
index dcf2194e..15bd60ca 100644
--- a/drivers/phy/phy-stm32-usbphyc.c
+++ b/drivers/phy/phy-stm32-usbphyc.c
@@ -583,8 +583,8 @@ static int stm32_usbphyc_probe(struct udevice *dev)

 		phy_id = ofnode_read_u32_default(node, "reg", FDT_ADDR_T_NONE);
 		if (phy_id >= MAX_PHYS) {
-			dev_err(dev, "invalid reg value %lx for %s\n",
-				phy_id, ofnode_get_name(node));
+			dev_err(dev, "invalid reg value %llx for %s\n",
+				(fdt64_t)phy_id, ofnode_get_name(node));
 			return -ENOENT;
 		}

--
2.20.1


  parent reply	other threads:[~2023-02-28 21:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 21:10 [PATCH v5 00/21] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-02-28 21:14 ` [PATCH v5 01/21] mtd: nand: raw: rockchip_nfc: use dev_read_addr_ptr Johan Jonker
2023-02-28 21:15 ` [PATCH v5 02/21] mtd: nand: raw: rockchip_nfc: remove the compatible string "rockchip,rk3308-nfc" Johan Jonker
2023-02-28 21:16 ` [PATCH v5 03/21] mtd: nand: raw: rockchip_nfc: add layout structure Johan Jonker
2023-02-28 21:16 ` [PATCH v5 04/21] mtd: nand: raw: rockchip_nfc: add flash_node to chip structure Johan Jonker
2023-02-28 21:16 ` [PATCH v5 05/21] mtd: nand: raw: rockchip_nfc: fix oobfree offset and description Johan Jonker
2023-02-28 21:17 ` [PATCH v5 06/21] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-02-28 21:17 ` [PATCH v5 07/21] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr Johan Jonker
2023-02-28 21:18 ` [PATCH v5 08/21] rockchip: timer: dw-apb-timer: convert dev_read_addr output to phys_addr_t Johan Jonker
2023-02-28 21:18 ` [PATCH v5 09/21] include: dm: ofnode: fix headers Johan Jonker
2023-02-28 21:18 ` [PATCH v5 10/21] core: remap: convert regmap_init_mem_plat() input to phys_addr_t Johan Jonker
2023-02-28 21:19 ` [PATCH v5 11/21] core: fdtaddr: add devfdt_get_addr_size_index_ptr function Johan Jonker
2023-02-28 21:20 ` [PATCH v5 12/21] core: read: add dev_read_addr_index_ptr function Johan Jonker
2023-03-01 15:01   ` Simon Glass
2023-02-28 21:20 ` [PATCH v5 13/21] spi: spi-aspeed-smc: use devfdt_get_addr_index_ptr Johan Jonker
2023-03-01 15:01   ` Simon Glass
2023-02-28 21:20 ` [PATCH v5 14/21] drivers: use dev_read_addr_index_ptr when cast to pointer Johan Jonker
2023-02-28 21:21 ` [PATCH v5 15/21] drivers: use dev_read_addr_ptr " Johan Jonker
2023-03-01 15:01   ` Simon Glass
2023-02-28 21:21 ` [PATCH v5 16/21] drivers: use devfdt_get_addr_size_index_ptr " Johan Jonker
2023-02-28 21:21 ` [PATCH v5 17/21] drivers: use devfdt_get_addr_index_ptr " Johan Jonker
2023-03-01 15:01   ` Simon Glass
2023-02-28 21:21 ` [PATCH v5 18/21] drivers: use devfdt_get_addr_ptr " Johan Jonker
2023-03-01 15:01   ` Simon Glass
2023-02-28 21:22 ` Johan Jonker [this message]
2023-03-01 15:01   ` [PATCH v5 19/21] drivers: fix debug string with fdt_addr_t input Simon Glass
2023-02-28 21:22 ` [PATCH v5 20/21] arm: stm32mp: spl: fix function " Johan Jonker
2023-02-28 21:22 ` [PATCH v5 21/21] include: fdtdec: decouple fdt_addr_t and phys_addr_t size Johan Jonker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79f29204-f0bd-b211-4111-e70bdc208172@gmail.com \
    --to=jbx6244@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=michael@amarulasolutions.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=yifeng.zhao@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox