From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 092BAC001B0 for ; Fri, 23 Jun 2023 14:19:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD65D8477A; Fri, 23 Jun 2023 16:19:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YLsVdJjv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9D3B86332; Fri, 23 Jun 2023 16:19:16 +0200 (CEST) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0393C8206E for ; Fri, 23 Jun 2023 16:19:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fa7eb35a13so4107115e9.0 for ; Fri, 23 Jun 2023 07:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687529952; x=1690121952; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=zVoUCBXRQQy8aSVQoCEfdGTC9bLxh+48LcWSrRDp0zM=; b=YLsVdJjv9pqnOJm1XaYkVew3BJwDwbJMYrbjnLaJBIIo3ZrynUKZ7k4FfhOZXZMage tY/XO5Fs+Mo+vRHUUwEPrDP5v9QbxKYUjZqORi/AjDNbubSdFCNsR/GgX+Tivd63wWDi gl6EH+e+j6e6UxrQ5cZIi16SHWR/a4Z26JScXVmLJaO5UoT4mvYmETahrEhpR8UBBBJF rfLs78oacL5Y/K0tdZnz5EzFRmsFyJzWr6k/Hph9RgQ4RtFUk1jJ/5wdfnnHJrAEmqFT MJspvF7PXMG3l6eVRx4DmpYdRYLMZ4gmEGV+qykf5RkZWCrV8umlyEP3gzZE3wHjlpsL 4hBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687529952; x=1690121952; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zVoUCBXRQQy8aSVQoCEfdGTC9bLxh+48LcWSrRDp0zM=; b=OkQ2EE8dFyrAcDz8Tg9vgZUjmgo8P/yqFkLcELbYd9TL74KLHBPtx+9CYopxGNDL7T tydi0JuObUAlHnIh+NKLlRms5R1xkKdW+3tbD/qz2f93Xrpss5QyacF+218e2uD/GFkn +6PeB0pYr+TShlJMA9HlMawJTxbZSwSyx0YJHmhmmHGPptzMT3t9oDEyVimRV4Naerky WFZA4tDLfvDX9UITdifmBhLmbvjooxp7KnBq2LNOE+awEVd00iSazKqa51mzV9uhpb8t eiQa49nLo7XfD4BZGhR4Cu1HBHz3za5GpTD36EnMysw26r3n8xzD2nHeBkg+GwTHBXYt F34Q== X-Gm-Message-State: AC+VfDxR9LLjobnzgjXkvJ0rkKYNxIMTDvyRNeiW00URPZkmm4ewLVmv rv9Vc8wbegoiQ56MMXhGE/s= X-Google-Smtp-Source: ACHHUZ7sexY7zxR8nVIEl4YmkdwSgJGDaQ+E/07bE64sPPFG5/SFnTYTBF3cc4wXoaNnOZfApliEig== X-Received: by 2002:a05:600c:2041:b0:3fa:7808:3e16 with SMTP id p1-20020a05600c204100b003fa78083e16mr2928158wmg.29.1687529952163; Fri, 23 Jun 2023 07:19:12 -0700 (PDT) Received: from [127.0.0.1] ([91.204.85.69]) by smtp.gmail.com with ESMTPSA id x13-20020a1c7c0d000000b003f9c859894esm2526022wmc.7.2023.06.23.07.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 07:19:11 -0700 (PDT) Date: Fri, 23 Jun 2023 17:19:09 +0300 From: Svyatoslav Ryhel To: Thierry Reding CC: Thierry Reding , Tom Warren , Tom Rini , Simon Glass , =?ISO-8859-1?Q?Jonas_Schw=F6bel?= , u-boot@lists.denx.de Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v7_4/7=5D_board=3A_asus=3A_transforme?= =?US-ASCII?Q?r=3A_add_ASUS_Transformer_T30_family_support?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20230623055600.246416-1-clamor95@gmail.com> <20230623055600.246416-5-clamor95@gmail.com> Message-ID: <7EA055AA-7ACE-4759-B8F0-CABA68402644@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80=2E 17:11:35 GMT+03:00,= Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0=D0=B2(-=D0=BB=D0=B0): >On Fri, Jun 23, 2023 at 02:51:54PM +0300, Svyatoslav Ryhel wrote: >>=20 >>=20 >> 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80=2E 14:32:30 GMT+03:= 00, Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8= =D1=81=D0=B0=D0=B2(-=D0=BB=D0=B0): >> >On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: >> >[=2E=2E=2E] >> >> diff --git a/board/asus/transformer-t30/pinmux-config-transformer=2E= h b/board/asus/transformer-t30/pinmux-config-transformer=2Eh >> >> new file mode 100644 >> >> index 0000000000=2E=2E96ff45d375 >> >> --- /dev/null >> >> +++ b/board/asus/transformer-t30/pinmux-config-transformer=2Eh >> >> @@ -0,0 +1,365 @@ >> >> +/* SPDX-License-Identifier: GPL-2=2E0 */ >> >> +/* >> >> + * Copyright (c) 2010-2013, NVIDIA CORPORATION=2E All rights reser= ved=2E >> >> + * >> >> + * Copyright (c) 2021, Svyatoslav Ryhel=2E >> >> + */ >> > >> >I don't recall if we discussed this during upstreaming of the Linux >> >device tree files, but shortly after the initial support for Tegra20 a= nd >> >Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to mov= e >> >towards generating the pinmux configuration for the various consumers >> >(i=2Ee=2E U-Boot and Linux) from data tables using a set of scripts=2E= This >> >was done because we noticed that various inconsistencies kept creeping >> >into the various drivers/tables=2E >> > >> >You can find the scripts for this here: >> > >> > https://github=2Ecom/NVIDIA/tegra-pinmux-scripts >> > >> >I think there'd be some benefit if these new boards were also converte= d >> >to use these scripts=2E >>=20 >> True, but there is no driver for pinmux which can utilize device tree, = instead u-boot relies on board header=2E I see the benefit of these pinmux = nodes only if I can verify that they are correct and do not brake devices= =2E Would be really bad if at some point devices brake cause nodes were not= tested=2E >>=20 >> Additionally, shouldn't all supported boards be converted first? > >The above repository contains a script that will generate the board >headers for U-Boot based on a more generic definition of the pinmux >configuration=2E Many devices already have headers that were generated >from those scripts, though it's mostly later boards (Tegra124 and >onwards)=2E > >That said, for many of these boards a spreadsheet exists that contains >these settings and the tables are generated from that spreadsheet=2E For >many of these OEM devices I suspect no such spreadsheet exists, and it >doesn't necessarily make sense to transcribe this into the tables and >then convert into board header & DTS snippets=2E It might be nice to do >for consistency, but I'll leave it up to you=2E Current tables are dumped from working vendor kernels=2E It is not that I = like this approach, but I would rather leave an existing setup since it is = well tested and confirmed to be stable enough=2E No one knows what htc and = asus did with those pins, at least publicly=2E >The repository has been in an archived state since there wasn't any >activity on it for a long time and I guess we didn't expect any new >boards to be added at this point=2E If needed we could revive this=2E That should not be necessary, though, thanks for proposition=2E Best regards, Svyatoslav R=2E >Thierry