From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot 1/4] eth/r8152: reset bmu after disabling Tx/Rx
Date: Tue, 9 Jun 2020 16:20:43 +0200 [thread overview]
Message-ID: <7a990a57-a944-bbde-65d2-e0a2be4e1389@denx.de> (raw)
In-Reply-To: <1394712342-15778-378-Taiwan-albertk@realtek.com>
On 6/9/20 10:53 AM, Hayes Wang wrote:
> Reset bmu after disabling Tx/Rx. This is used to clear the FIFO of
> Tx/Rx. The remained data may be transferred after Tx/Rx is re-enabled.
> And it results in garbage data.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> drivers/usb/eth/r8152.c | 14 ++++++++++++++
> drivers/usb/eth/r8152.h | 7 ++++++-
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c
> index f201a1789b..dbb1721882 100644
> --- a/drivers/usb/eth/r8152.c
> +++ b/drivers/usb/eth/r8152.c
> @@ -568,6 +568,17 @@ static void r8153_power_cut_en(struct r8152 *tp, bool enable)
> ocp_write_word(tp, MCU_TYPE_USB, USB_MISC_0, ocp_data);
> }
>
> +static void rtl_reset_bmu(struct r8152 *tp)
> +{
> + u32 ocp_data;
You're writing a byte, shouldn't that be u8 ?
next prev parent reply other threads:[~2020-06-09 14:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 8:53 [PATCH u-boot 0/4] r8152: support more chips Hayes Wang
2020-06-09 8:53 ` [PATCH u-boot 1/4] eth/r8152: reset bmu after disabling Tx/Rx Hayes Wang
2020-06-09 14:20 ` Marek Vasut [this message]
2020-06-10 9:27 ` Hayes Wang
2020-06-10 11:04 ` Marek Vasut
2020-06-11 3:18 ` Hayes Wang
2020-06-09 8:53 ` [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it Hayes Wang
2020-06-09 14:22 ` Marek Vasut
2020-06-10 9:47 ` Hayes Wang
2020-06-10 11:06 ` Marek Vasut
2020-06-09 8:53 ` [PATCH u-boot 3/4] eth/r8152: modify rtl_clear_bp function Hayes Wang
2020-06-09 14:23 ` Marek Vasut
2020-06-09 8:53 ` [PATCH u-boot 4/4] eth/r8152: support RTL8153B/RTL8154B Hayes Wang
2020-06-09 14:27 ` Marek Vasut
2020-06-10 12:44 ` Hayes Wang
2020-06-10 12:54 ` Marek Vasut
2020-06-10 13:12 ` Hayes Wang
2020-06-10 13:20 ` Marek Vasut
2020-06-11 3:18 ` Hayes Wang
2020-06-12 0:05 ` Marek Vasut
2020-06-12 3:50 ` Hayes Wang
2020-06-12 11:52 ` Marek Vasut
2020-06-15 6:52 ` Hayes Wang
2020-06-15 7:34 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a990a57-a944-bbde-65d2-e0a2be4e1389@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox