Re: [PATCH v2 2/4] mtd: spi-nor-core: macronix: Add support for mx66lm1g45g

Jagan Teki
2021-11-13T13:49:08Z

On Thu, Nov 4, 2021 at 5:20 AM Tudor Ambarus
<tudor.ambarus@microchip.com> wrote:
>
> mx66lm1g45g supports just 1-1-1, 8-8-8 and 8d-8d-8d modes.
> Tested in 1-1-1 and 8d-8d-8d modes using microchip's Octal SPI IP.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi/Kconfig | 8 ++++
> drivers/mtd/spi/spi-nor-core.c | 74 ++++++++++++++++++++++++++++++++++
> drivers/mtd/spi/spi-nor-ids.c | 6 +++
> include/linux/mtd/spi-nor.h | 8 ++++
> 4 files changed, 96 insertions(+)
>
> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
> index 408a53f861..2d2b71c52d 100644
> --- a/drivers/mtd/spi/Kconfig
> +++ b/drivers/mtd/spi/Kconfig
> @@ -160,6 +160,14 @@ config SPI_FLASH_MACRONIX
> help
> Add support for various Macronix SPI flash chips (MX25Lxxx)
>
> +config SPI_FLASH_MX66LM1G45G
> + bool "Macronix MX66LM1G45G chip support"

Apart from actual code, I don't like to have specific part configs,
look like list is increasing like anything. Better use existing
macronix.

Jagan.