From: Angelo Dureghello <angelo@kernel-space.org>
To: Stefan Roese <sr@denx.de>, trini@konsulko.com
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 3/5] m68k: dts: add watchdog node
Date: Tue, 18 Jul 2023 15:58:25 +0200 [thread overview]
Message-ID: <7b554118-a36f-68d2-96e5-2f60667243aa@kernel-space.org> (raw)
In-Reply-To: <42008163-971d-6a05-261e-64c8bb343112@denx.de>
Hi Stefan,
On 18/07/23 2:26 PM, Stefan Roese wrote:
> On 6/25/23 21:35, Angelo Dureghello wrote:
>> Add watchdog node for the implemented mcf_wdt driver.
>>
>> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
>> ---
>> arch/m68k/dts/M5208EVBE.dts | 5 +++++
>> arch/m68k/dts/mcf5208.dtsi | 7 +++++++
>> arch/m68k/dts/mcf523x.dtsi | 7 +++++++
>> arch/m68k/dts/mcf5271.dtsi | 7 +++++++
>> arch/m68k/dts/mcf5275.dtsi | 7 +++++++
>> arch/m68k/dts/mcf5282.dtsi | 7 +++++++
>> arch/m68k/dts/mcf5329.dtsi | 7 +++++++
>> arch/m68k/dts/mcf537x.dtsi | 7 +++++++
>> 8 files changed, 54 insertions(+)
>>
>> diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts
>> index 1c32718af4..ec203e8b69 100644
>> --- a/arch/m68k/dts/M5208EVBE.dts
>> +++ b/arch/m68k/dts/M5208EVBE.dts
>> @@ -15,6 +15,11 @@
>> };
>> };
>> +&wdog0 {
>> + timeout-sec = <32>;
>> + status = "okay";
>> +};
>> +
>> &uart0 {
>> bootph-all;
>> status = "okay";
>> diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi
>> index 9392facfa8..b06dc4bb26 100644
>> --- a/arch/m68k/dts/mcf5208.dtsi
>> +++ b/arch/m68k/dts/mcf5208.dtsi
>> @@ -16,6 +16,13 @@
>> #address-cells = <1>;
>> #size-cells = <1>;
>> + wdog0: watchdog@fc08c000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0xfc08c000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>
> I was not able to find this compatible property in the Linux Kernel
> source tree. Is this the official version of the Coldfire WDT DT node?
> Just checking..
>
there is no fdt support for m68k in Linux, after discussing the need in
u-boot, i implemented fdt here the best i could.
> Thanks,
> Stefan
>
>> +
>> uart0: uart@fc060000 {
>> compatible = "fsl,mcf-uart";
>> reg = <0xfc060000 0x40>;
>> diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi
>> index 41c7b9b2d1..fb5a4cdc21 100644
>> --- a/arch/m68k/dts/mcf523x.dtsi
>> +++ b/arch/m68k/dts/mcf523x.dtsi
>> @@ -23,6 +23,13 @@
>> ranges = <0x00000000 0x40000000 0x40000000>;
>> reg = <0x40000000 0x40000000>;
>> + wdog0: watchdog@140000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0x140000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@200 {
>> compatible = "fsl,mcf-uart";
>> reg = <0x200 0x40>;
>> diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi
>> index fc82bd3c24..0884c13ab1 100644
>> --- a/arch/m68k/dts/mcf5271.dtsi
>> +++ b/arch/m68k/dts/mcf5271.dtsi
>> @@ -23,6 +23,13 @@
>> ranges = <0x00000000 0x40000000 0x40000000>;
>> reg = <0x40000000 0x40000000>;
>> + wdog0: watchdog@140000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0x140000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@200 {
>> compatible = "fsl,mcf-uart";
>> reg = <0x200 0x40>;
>> diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi
>> index 402517cdec..78210569da 100644
>> --- a/arch/m68k/dts/mcf5275.dtsi
>> +++ b/arch/m68k/dts/mcf5275.dtsi
>> @@ -24,6 +24,13 @@
>> ranges = <0x00000000 0x40000000 0x40000000>;
>> reg = <0x40000000 0x40000000>;
>> + wdog0: watchdog@140000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0x140000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@200 {
>> compatible = "fsl,mcf-uart";
>> reg = <0x200 0x40>;
>> diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi
>> index 883c0d0324..40704c5202 100644
>> --- a/arch/m68k/dts/mcf5282.dtsi
>> +++ b/arch/m68k/dts/mcf5282.dtsi
>> @@ -23,6 +23,13 @@
>> ranges = <0x00000000 0x40000000 0x40000000>;
>> reg = <0x40000000 0x40000000>;
>> + wdog0: watchdog@140000 {
>> + compatible = "fsl,mcf5282-wdt";
>> + reg = <0x140000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@200 {
>> compatible = "fsl,mcf-uart";
>> reg = <0x200 0x40>;
>> diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi
>> index 7501cc4b01..50ff73bca7 100644
>> --- a/arch/m68k/dts/mcf5329.dtsi
>> +++ b/arch/m68k/dts/mcf5329.dtsi
>> @@ -16,6 +16,13 @@
>> #address-cells = <1>;
>> #size-cells = <1>;
>> + wdog0: watchdog@fc098000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0xfc08c000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@fc060000 {
>> compatible = "fsl,mcf-uart";
>> reg = <0xfc060000 0x40>;
>> diff --git a/arch/m68k/dts/mcf537x.dtsi b/arch/m68k/dts/mcf537x.dtsi
>> index 338b8b4583..23c3754df0 100644
>> --- a/arch/m68k/dts/mcf537x.dtsi
>> +++ b/arch/m68k/dts/mcf537x.dtsi
>> @@ -16,6 +16,13 @@
>> #address-cells = <1>;
>> #size-cells = <1>;
>> + wdog0: watchdog@fc098000 {
>> + compatible = "fsl,mcf5208-wdt";
>> + reg = <0xfc08c000 0x10>;
>> + big-endian;
>> + status = "disabled";
>> + };
>> +
>> uart0: uart@fc060000 {
>> compatible = "fsl,mcf-uart";
>> reg = <0xfc060000 0x40>;
>
> Viele Grüße,
> Stefan Roese
>
Regards,
angelo
next prev parent reply other threads:[~2023-07-18 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 19:35 [PATCH 0/5] m68k: add ColdFire watchdog driver Angelo Dureghello
2023-06-25 19:35 ` [PATCH 1/5] drivers: watchdog: add mcf watchdog support Angelo Dureghello
2023-07-18 12:23 ` Stefan Roese
2023-07-18 14:06 ` Angelo Dureghello
2023-07-19 9:55 ` Stefan Roese
2023-06-25 19:35 ` [PATCH 2/5] m68k: move watchdog functions in mcf_wdt driver Angelo Dureghello
2023-07-18 12:25 ` Stefan Roese
2023-06-25 19:35 ` [PATCH 3/5] m68k: dts: add watchdog node Angelo Dureghello
2023-07-18 12:26 ` Stefan Roese
2023-07-18 13:58 ` Angelo Dureghello [this message]
2023-07-18 14:27 ` Stefan Roese
2023-07-19 1:07 ` Simon Glass
2023-06-25 19:35 ` [PATCH 4/5] configs: m68k: add watchdog driver Angelo Dureghello
2023-06-25 19:35 ` [PATCH 5/5] MAINTAINERS: add myself as mcf_wdt.c maintainer Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b554118-a36f-68d2-96e5-2f60667243aa@kernel-space.org \
--to=angelo@kernel-space.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox