public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/20] usb: hub: Update handling connect status/change in usb_scan_port()
Date: Tue, 20 Jun 2017 10:18:08 -0500	[thread overview]
Message-ID: <7bb06632-8a21-37f2-cda7-8bca216510e6@kernel.org> (raw)
In-Reply-To: <f650720f-50d3-87ca-e892-91f39808d6a7@denx.de>



On 06/16/2017 09:19 AM, Marek Vasut wrote:
> On 06/16/2017 03:31 PM, Bin Meng wrote:
>> It was observed that on Intel MinnowMax board, when xHCI is enabled
>> in the BayTrail SoC, with a USB 3.0 device connected to the bottom
>> USB 3.0 port (mapped to xHCI root port #7), its PORTSC register is
>> always 0x201203 (CCS = 1, CSC = 0). The root cause of such behavior
>> is unknown yet. Connect status change bit is set on the same port
>> with a USB 2.0 device (mapped to xHCI port #1, which is a different
>> port on the root hub).
>>
>> With current logic in usb_scan_port(), the enumeration process will
>> abort if it does not detect a connect status change on a hub port.
>> However since a device connection status is correctly reported, the
>> enumeration process can still continue.
>>
>> With this change, USB device connected to the bottom blue port on
>> MinnowMax board can be enumerated under either SS or HS mode.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> 
> I'd be slightly concerned this can break some other controllers, like
> the DWC2 . CCing Dinh, maybe he can test it on SoCFPGA.
> 

I tested this patch on a SoCFPGA Atlas/DE0-Nano board, and USB is still
working fine.

Feel free to add:

Tested-by: Dinh Nguyen <dinguyen@kernel.org>

  reply	other threads:[~2017-06-20 15:18 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 13:31 [U-Boot] [PATCH 00/20] usb: xhci: Fix USB xHCI support on Intel platform Bin Meng
2017-06-16 13:31 ` [U-Boot] [PATCH 01/20] usb: xhci: Remove incorrect comments for struct xhci_container_ctx Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 02/20] usb: xhci: Correct command TRB 4th dword initialization Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 03/20] usb: xhci: Initialize scratchpad buffer array and scratchpad buffers Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 04/20] usb: xhci: Add input slot context in xhci_set_configuration() Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 05/20] usb: hub: Update handling connect status/change in usb_scan_port() Bin Meng
2017-06-16 14:19   ` Marek Vasut
2017-06-20 15:18     ` Dinh Nguyen [this message]
2017-06-16 13:31 ` [U-Boot] [PATCH 06/20] usb: hub: Send correct wValue to get hub descriptor of a USB 3.0 hub Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 07/20] usb: hub: Revise wLength for 'get port status' request Bin Meng
2017-06-17  3:43   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 08/20] usb: hub: Change USB hub descriptor to match USB 3.0 hubs Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 09/20] usb: hub: Add 3.0 hub port status mask of 2.0 hub Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 10/20] usb: xhci: Change MAX_HC_PORTS to 255 Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 11/20] usb: xhci: Get rid of CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 12/20] configs: Remove CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS in all boards Bin Meng
2017-06-16 14:06   ` Bin Meng
2017-06-21 12:13     ` Stefan Roese
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 13/20] usb: ehci: Get rid of CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 14/20] configs: Remove CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in all boards Bin Meng
2017-06-16 14:09   ` Bin Meng
2017-06-21 12:13     ` Stefan Roese
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 15/20] usb: cmd: Print actual packet size for super speed devices Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 16/20] usb: xhci: Convert CONFIG_USB_XHCI_PCI to Kconfig Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 17/20] x86: minnowmax: Configure GPIO pins to turn on USB ports VBUS Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-17 13:41     ` Bin Meng
2017-06-22  6:44     ` Bin Meng
2017-06-16 13:31 ` [U-Boot] [PATCH 18/20] x86: minnowmax: Add a environment variable for USB power-on delay Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-16 13:31 ` [U-Boot] [PATCH 19/20] x86: minnowmax: Enable USB xHCI support Bin Meng
2017-06-17  3:44   ` Simon Glass
2017-06-17 13:43     ` Bin Meng
2017-06-16 13:31 ` [U-Boot] [PATCH 20/20] x86: Remove CONFIG_USB_MAX_CONTROLLER_COUNT Bin Meng
2017-06-17  3:45   ` Simon Glass
2017-06-22  6:44     ` Bin Meng
2017-06-16 13:42 ` [U-Boot] [PATCH 00/20] usb: xhci: Fix USB xHCI support on Intel platform Bin Meng
2017-06-16 14:21 ` Marek Vasut
2017-06-16 14:29   ` Stefan Roese
2017-06-21  9:28 ` Stefan Roese
2017-06-21 10:24   ` Bin Meng
2017-06-21 12:07     ` Stefan Roese
2017-06-21 12:44       ` Bin Meng
2017-06-22  6:32         ` Bin Meng
2017-06-21 12:10 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bb06632-8a21-37f2-cda7-8bca216510e6@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox