From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 833A6C38142 for ; Tue, 31 Jan 2023 12:48:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D2C3085A76; Tue, 31 Jan 2023 13:48:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UFBYaR15"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4606185A76; Tue, 31 Jan 2023 13:48:15 +0100 (CET) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5C84085A6C for ; Tue, 31 Jan 2023 13:48:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pj1-x102b.google.com with SMTP id t12-20020a17090aae0c00b00229f4cff534so979746pjq.1 for ; Tue, 31 Jan 2023 04:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=86b0tr2MKxC+r1vcMBhvualgrHXqMRD2hSzOIbh4+Ys=; b=UFBYaR15zsixrxpcZlbLMmoRethViQFeKDegDmYx1k4prJRYFvP82DXTnTdhV4ZWV5 okciYky0htAwsBrdztmTsif9chG/SwdWcEKy20La0kIiSXY2FJlMpOEVdqAnC+Q0gpeX yyA7UnqK1hxy6+/OKGMjzHqlCu33Y9mc9oGpR+3444YBE240DXXlICI3DN/nFyWr0Nw4 PhLYAcvxOpLR3ZHCj+bnMCSE9kDna8uVemwHiPlEQOGDORxFTiMW6LBUjdu5e43JkmTh O8DAyZqyor1+/L1DvemwnAtQjIGMLxlEj+bfTcCKAyZ9UKTZd+P9n2KM1auuU4sRUMW1 q+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=86b0tr2MKxC+r1vcMBhvualgrHXqMRD2hSzOIbh4+Ys=; b=0RWPYARg3VuTZtrSgc9Zpe/vn2IJ4RJsG0xBoeGqlVtWMuHOvK/uFSHDOn8gn8qVkT BN0uDCU0nW4SBCy/97snCLqWjgZHUy+VFj7CLnTWZ+G1zYRMLSLCIK1gGKNF9EzoL/n+ amHrkw5pzhRJ3zsMiSdYaVCKH2xb8p/h1gWGfN1ghpQjWtVjddEimgF0X96ahasxvyKF 5bm0nBrhTm8eesjni8Uyg/pZD+A4BxanCc+zgtK/OKnSRyy/ZEabfO0MHU8wFqJ2+Zks EaUlk2Y+2beLdObotJx5xQ/PxlWwWiJ7paLddrT9EXt6TuZpYaXlfaiflOW9vyYJHRia x+Dw== X-Gm-Message-State: AO0yUKVxFZJZtCbhBW73eTj0raYw6nZZ+Pg5+r8OL214jrd+Y+8rLigZ /qvX8bSyRKpM/yhCQNFfTUs= X-Google-Smtp-Source: AK7set8NmyvUDwy8B5ZJCe/4VFIvjL0q0hVSwHEIDstMBIAEZD0QmvIOkHN8dx+NITQZgQF/cgfZSA== X-Received: by 2002:a17:903:234c:b0:196:11ae:95f6 with SMTP id c12-20020a170903234c00b0019611ae95f6mr34442750plh.21.1675169286666; Tue, 31 Jan 2023 04:48:06 -0800 (PST) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id m6-20020a170902db8600b001947738ec7fsm9697929pld.158.2023.01.31.04.48.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 04:48:06 -0800 (PST) Message-ID: <7d0e5ebd-885a-389e-cb11-19454ea4ac6d@gmail.com> Date: Tue, 31 Jan 2023 21:48:04 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] power: act8846_pmic: fix number of registers Content-Language: en-US To: John Keeping , Jaehoon Chung Cc: u-boot@lists.denx.de References: <20230119125612.1968983-1-john@metanate.com> From: Jaehoon Chung In-Reply-To: <20230119125612.1968983-1-john@metanate.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/19/23 21:56, John Keeping wrote: > The highest register on ACT8846 is 0xf5, so set the number of registers > to 0xf6, ensuring that the pmic read/write commands are able to access > all of the supported registers (and many that are not valid, since the > register space is quite sparse). > > Signed-off-by: John Keeping Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > include/power/act8846_pmic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h > index acd0fd671e..84845c70f9 100644 > --- a/include/power/act8846_pmic.h > +++ b/include/power/act8846_pmic.h > @@ -9,7 +9,7 @@ > > #include > > -#define ACT8846_NUM_OF_REGS 12 > +#define ACT8846_NUM_OF_REGS 0xf6 > > #define BUCK_VOL_MASK 0x3f > #define LDO_VOL_MASK 0x3f