From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 1 Nov 2018 13:11:21 +0100 Subject: [U-Boot] [PATCH 08/13] mmc: tmio: Silence transfer errors when tuning In-Reply-To: References: <20181031171606.13561-1-marek.vasut+renesas@gmail.com> <20181031171606.13561-8-marek.vasut+renesas@gmail.com> Message-ID: <7dab2cac-c8e9-71ac-45f3-48d8f3aa227c@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/01/2018 12:42 PM, Masahiro Yamada wrote: > On Thu, Nov 1, 2018 at 2:22 AM Marek Vasut wrote: >> >> In case the controller performs card tuning, that is, sends MMC >> command 19 or 21, silence possible CRC error warning prints. The >> warnings are bound to happen, since the tuning will fail for some >> settings while searching for the optimal configuration of the bus >> and that is perfectly OK. >> >> This patch passes around the MMC command structure and adds check >> into tmio_sd_check_error() to avoid printing CRC error warning >> when the tuning happens. > > Make sense, but another solution might be > to delete the message entirely, or to turn it into a debug message. I'd like to see errors when they happen though, so what do you think about this patch ? -- Best regards, Marek Vasut