From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B40EC7EE29 for ; Fri, 2 Jun 2023 18:54:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4FC3862FA; Fri, 2 Jun 2023 20:53:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="LnXAAoqj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BC65A8638D; Fri, 2 Jun 2023 20:53:57 +0200 (CEST) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81B43856C4 for ; Fri, 2 Jun 2023 20:53:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=william.zhang@broadcom.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6537d2a8c20so590649b3a.2 for ; Fri, 02 Jun 2023 11:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1685732032; x=1688324032; h=in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:from:to:cc:subject:date:message-id:reply-to; bh=iJQZArITuIRloSRglqjyZ+wJ8D1e46CWWMDRJhxAMfE=; b=LnXAAoqjWivJe80BJCGULv8UoyWBTufKvVtPglzPf3kijOIcZQis7ujnJOxRGgBk+E RQcO2xoNXVjbu6LQsmtg/l8M6gg8l2Uj4mcILAikiWLgcvzoOlb7UV1FFBaI54J6kHaU AECU7ZuonAFUdORTZuNqG8caD1MHLuVnqG6Dw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685732032; x=1688324032; h=in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iJQZArITuIRloSRglqjyZ+wJ8D1e46CWWMDRJhxAMfE=; b=IXc5VS64Cq0HcGyiAgQZCK6is6jWWbBwh5vJGpIlKq5T8ib6D3nJbcA7F0tZHvwe4m D3kP2UTtErA8WVV1bCNl777y4cEEfENoDCeetxgGT2tpww7COuwyJ3207MhbZEbP/FTL QM/Rq/aYpYmCz3TXcCvkV4Yazg6//t5kbODXtQXAG7aTLdGFGmIKsP/dNcAtwEx1YPyN Hsx4sza+dpoCOEayRp5YyDH44a0m2YsImk6XxiF8Ezcnz9whkBDn2eZTfRZqbJTe7l+F y68wTUcLmr839dsNoY4psq8IZoN/Z+HXXxvaAFqwhVnN31IYOCSOuAq44XJ0w4FX9QiD hfZg== X-Gm-Message-State: AC+VfDwQ2mFDbbY0oSCz6I5EIFPQ+GpoR3BAbQGKEOA5qDJ3xsbueK00 8ZZxWD0F8RiinqGkd+6qDT86rA== X-Google-Smtp-Source: ACHHUZ4RVmvYd/DCfgbKsVnZ9tNe4KYawc2reDECoWjM16XBzy1S0nuc/UrftFI84Hf85hETDolefg== X-Received: by 2002:a05:6a20:8e1d:b0:10d:d42:f6bc with SMTP id y29-20020a056a208e1d00b0010d0d42f6bcmr9478977pzj.41.1685732031697; Fri, 02 Jun 2023 11:53:51 -0700 (PDT) Received: from bcacpedev-irv-3.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id ja22-20020a170902efd600b001b008b3dee2sm1665230plb.287.2023.06.02.11.53.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2023 11:53:46 -0700 (PDT) Subject: Re: [PATCH v2 8/9] spi: bcmbca-hsspi: Add driver for newer HSSPI controller To: Jagan Teki Cc: anand.gore@broadcom.com, kursad.oney@broadcom.com, U-Boot Mailing List , noltari@gmail.com, philippe.reynes@softathome.com, tomer.yacoby@broadcom.com, dregan@mail.com, joel.peshkin@broadcom.com, dan.beygelman@broadcom.com References: <20230502185817.374951-1-william.zhang@broadcom.com> <20230502185817.374951-9-william.zhang@broadcom.com> From: William Zhang Message-ID: <7e37de97-9212-78a5-22e3-66250a8c121e@broadcom.com> Date: Fri, 2 Jun 2023 11:53:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000f5f29705fd2a1218" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --000000000000f5f29705fd2a1218 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Jagan, On 06/01/2023 10:54 PM, Jagan Teki wrote: > On Wed, May 3, 2023 at 12:29 AM William Zhang > wrote: >> >> The newer BCMBCA SoCs such as BCM6756, BCM4912 and BCM6855 include an >> updated SPI controller that add the capability to allow the driver to >> control chip select explicitly. Driver can control and keep cs low >> between the transfers natively. Hence the dummy cs workaround or prepend >> mode found in the bcm63xx-hsspi driver are no longer needed and this new >> driver is much cleaner. >> >> Port from linux patch: >> Link: https://lore.kernel.org/r/20230209200246.141520-15-william.zhang@broadcom.com >> >> Signed-off-by: William Zhang >> --- >> >> Changes in v2: None >> >> arch/arm/mach-bcmbca/Kconfig | 15 ++ > > Exclude this from spi driver patch. Driver has to be a separate patch. > Sure >> drivers/spi/Kconfig | 9 + >> drivers/spi/Makefile | 1 + >> drivers/spi/bcmbca_hsspi.c | 414 +++++++++++++++++++++++++++++++++++ >> 4 files changed, 439 insertions(+) >> create mode 100644 drivers/spi/bcmbca_hsspi.c >> >> diff --git a/arch/arm/mach-bcmbca/Kconfig b/arch/arm/mach-bcmbca/Kconfig >> index 6441ed5929d2..60b36c4bb0f6 100644 >> --- a/arch/arm/mach-bcmbca/Kconfig >> +++ b/arch/arm/mach-bcmbca/Kconfig >> @@ -27,6 +27,7 @@ config BCM4912 >> select SYS_ARCH_TIMER >> select DM_SERIAL >> select PL01X_SERIAL >> + select BCMBCA_HSSPI >> >> config BCM63138 >> bool "Support for Broadcom 63138 Family" >> @@ -75,6 +76,7 @@ config BCM6756 >> select CPU_V7A >> select DM_SERIAL >> select PL01X_SERIAL >> + select BCMBCA_HSSPI >> >> config BCM6813 >> bool "Support for Broadcom 6813 Family" >> @@ -82,6 +84,7 @@ config BCM6813 >> select SYS_ARCH_TIMER >> select DM_SERIAL >> select PL01X_SERIAL >> + select BCMBCA_HSSPI >> >> config BCM6846 >> bool "Support for Broadcom 6846 Family" >> @@ -97,6 +100,7 @@ config BCM6855 >> select CPU_V7A >> select DM_SERIAL >> select PL01X_SERIAL >> + select BCMBCA_HSSPI >> help >> Broadcom BCM6855 is a triple core Cortex A7 based xPON Gateway >> SoC. This SoC family includes BCM6855x, BCM68252 and BCM6753. >> @@ -131,6 +135,17 @@ config BCM6878 >> select PL01X_SERIAL >> select BCM63XX_HSSPI >> >> +config HAVE_SPI_CS_CTRL >> + bool "SoC supports SPI chip select control" >> + default y if BCM4912 >> + default y if BCM6756 >> + default y if BCM6855 >> + default y if BCM6813 > > Use || Will update > >> + default n >> + help >> + Enable this option if SoC supports SPI chip select control explicitly >> + through software. >> + >> source "arch/arm/mach-bcmbca/bcm47622/Kconfig" >> source "arch/arm/mach-bcmbca/bcm4908/Kconfig" >> source "arch/arm/mach-bcmbca/bcm4912/Kconfig" >> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig >> index 47a261f1e1b8..6b26915f9bb2 100644 >> --- a/drivers/spi/Kconfig >> +++ b/drivers/spi/Kconfig >> @@ -107,6 +107,15 @@ config BCM63XX_HSSPI >> access the SPI NOR flash on platforms embedding this Broadcom >> SPI core. >> >> +config BCMBCA_HSSPI >> + bool "BCMBCA HSSPI driver" >> + depends on ARCH_BCMBCA && HAVE_SPI_CS_CTRL >> + help >> + This enables support for the High Speed SPI controller present on >> + newer Broadcom BCMBCA SoCs. These SoCs include an updated SPI controller >> + that adds the capability to allow the driver to control chip select >> + explicitly. >> + >> config BCM63XX_SPI >> bool "BCM6348 SPI driver" >> depends on ARCH_BMIPS >> diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile >> index 95dba9ac4559..c27b3327c337 100644 >> --- a/drivers/spi/Makefile >> +++ b/drivers/spi/Makefile >> @@ -25,6 +25,7 @@ obj-$(CONFIG_ATH79_SPI) += ath79_spi.o >> obj-$(CONFIG_ATMEL_QSPI) += atmel-quadspi.o >> obj-$(CONFIG_ATMEL_SPI) += atmel_spi.o >> obj-$(CONFIG_BCM63XX_HSSPI) += bcm63xx_hsspi.o >> +obj-$(CONFIG_BCMBCA_HSSPI) += bcmbca_hsspi.o >> obj-$(CONFIG_BCM63XX_SPI) += bcm63xx_spi.o >> obj-$(CONFIG_BCMSTB_SPI) += bcmstb_spi.o >> obj-$(CONFIG_CF_SPI) += cf_spi.o >> diff --git a/drivers/spi/bcmbca_hsspi.c b/drivers/spi/bcmbca_hsspi.c >> new file mode 100644 >> index 000000000000..fbe315a7d45d >> --- /dev/null >> +++ b/drivers/spi/bcmbca_hsspi.c >> @@ -0,0 +1,414 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Copyright (C) 2017 Álvaro Fernández Rojas >> + * >> + * Derived from linux/drivers/spi/spi-bcm63xx-hsspi.c: >> + * Copyright (C) 2000-2010 Broadcom Corporation >> + * Copyright (C) 2012-2013 Jonas Gorski >> + * Copyright (C) 2021 Broadcom Ltd >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define HSSPI_PP 0 >> + >> +#define SPI_MAX_SYNC_CLOCK 30000000 > > What is this clock? spi-max-frequency ? if yes pick it from DT. > Not spi-max-frequency. This is the controller internal setting that determines if controller works in sync or async mode when clock is below or above this frequency. >> + >> +/* SPI Control register */ >> +#define SPI_CTL_REG 0x000 >> +#define SPI_CTL_CS_POL_SHIFT 0 >> +#define SPI_CTL_CS_POL_MASK (0xff << SPI_CTL_CS_POL_SHIFT) >> +#define SPI_CTL_CLK_GATE_SHIFT 16 >> +#define SPI_CTL_CLK_GATE_MASK BIT(SPI_CTL_CLK_GATE_SHIFT) >> +#define SPI_CTL_CLK_POL_SHIFT 17 >> +#define SPI_CTL_CLK_POL_MASK BIT(SPI_CTL_CLK_POL_SHIFT) >> + >> +/* SPI Interrupts registers */ >> +#define SPI_IR_STAT_REG 0x008 >> +#define SPI_IR_ST_MASK_REG 0x00c >> +#define SPI_IR_MASK_REG 0x010 >> + >> +#define SPI_IR_CLEAR_ALL 0xff001f1f >> + >> +/* SPI Ping-Pong Command registers */ >> +#define SPI_CMD_REG (0x080 + (0x40 * (HSSPI_PP)) + 0x00) >> +#define SPI_CMD_OP_SHIFT 0 >> +#define SPI_CMD_OP_START BIT(SPI_CMD_OP_SHIFT) >> +#define SPI_CMD_PFL_SHIFT 8 >> +#define SPI_CMD_PFL_MASK (0x7 << SPI_CMD_PFL_SHIFT) >> +#define SPI_CMD_SLAVE_SHIFT 12 >> +#define SPI_CMD_SLAVE_MASK (0x7 << SPI_CMD_SLAVE_SHIFT) >> + >> +/* SPI Ping-Pong Status registers */ >> +#define SPI_STAT_REG (0x080 + (0x40 * (HSSPI_PP)) + 0x04) >> +#define SPI_STAT_SRCBUSY_SHIFT 1 >> +#define SPI_STAT_SRCBUSY_MASK BIT(SPI_STAT_SRCBUSY_SHIFT) >> + >> +/* SPI Profile Clock registers */ >> +#define SPI_PFL_CLK_REG(x) (0x100 + (0x20 * (x)) + 0x00) >> +#define SPI_PFL_CLK_FREQ_SHIFT 0 >> +#define SPI_PFL_CLK_FREQ_MASK (0x3fff << SPI_PFL_CLK_FREQ_SHIFT) >> +#define SPI_PFL_CLK_RSTLOOP_SHIFT 15 >> +#define SPI_PFL_CLK_RSTLOOP_MASK BIT(SPI_PFL_CLK_RSTLOOP_SHIFT) >> + >> +/* SPI Profile Signal registers */ >> +#define SPI_PFL_SIG_REG(x) (0x100 + (0x20 * (x)) + 0x04) >> +#define SPI_PFL_SIG_LATCHRIS_SHIFT 12 >> +#define SPI_PFL_SIG_LATCHRIS_MASK BIT(SPI_PFL_SIG_LATCHRIS_SHIFT) >> +#define SPI_PFL_SIG_LAUNCHRIS_SHIFT 13 >> +#define SPI_PFL_SIG_LAUNCHRIS_MASK BIT(SPI_PFL_SIG_LAUNCHRIS_SHIFT) >> +#define SPI_PFL_SIG_ASYNCIN_SHIFT 16 >> +#define SPI_PFL_SIG_ASYNCIN_MASK BIT(SPI_PFL_SIG_ASYNCIN_SHIFT) >> + >> +/* SPI Profile Mode registers */ >> +#define SPI_PFL_MODE_REG(x) (0x100 + (0x20 * (x)) + 0x08) >> +#define SPI_PFL_MODE_FILL_SHIFT 0 >> +#define SPI_PFL_MODE_FILL_MASK (0xff << SPI_PFL_MODE_FILL_SHIFT) >> +#define SPI_PFL_MODE_MDRDSZ_SHIFT 16 >> +#define SPI_PFL_MODE_MDRDSZ_MASK BIT(SPI_PFL_MODE_MDRDSZ_SHIFT) >> +#define SPI_PFL_MODE_MDWRSZ_SHIFT 18 >> +#define SPI_PFL_MODE_MDWRSZ_MASK BIT(SPI_PFL_MODE_MDWRSZ_SHIFT) >> +#define SPI_PFL_MODE_3WIRE_SHIFT 20 >> +#define SPI_PFL_MODE_3WIRE_MASK BIT(SPI_PFL_MODE_3WIRE_SHIFT) >> + >> +/* SPI Ping-Pong FIFO registers */ >> +#define HSSPI_FIFO_SIZE 0x200 >> +#define HSSPI_FIFO_BASE (0x200 + \ >> + (HSSPI_FIFO_SIZE * HSSPI_PP)) >> + >> +/* SPI Ping-Pong FIFO OP register */ >> +#define HSSPI_FIFO_OP_SIZE 0x2 >> +#define HSSPI_FIFO_OP_REG (HSSPI_FIFO_BASE + 0x00) >> +#define HSSPI_FIFO_OP_BYTES_SHIFT 0 >> +#define HSSPI_FIFO_OP_BYTES_MASK (0x3ff << HSSPI_FIFO_OP_BYTES_SHIFT) >> +#define HSSPI_FIFO_OP_MBIT_SHIFT 11 >> +#define HSSPI_FIFO_OP_MBIT_MASK BIT(HSSPI_FIFO_OP_MBIT_SHIFT) >> +#define HSSPI_FIFO_OP_CODE_SHIFT 13 >> +#define HSSPI_FIFO_OP_READ_WRITE (1 << HSSPI_FIFO_OP_CODE_SHIFT) >> +#define HSSPI_FIFO_OP_CODE_W (2 << HSSPI_FIFO_OP_CODE_SHIFT) >> +#define HSSPI_FIFO_OP_CODE_R (3 << HSSPI_FIFO_OP_CODE_SHIFT) >> + >> +#define HSSPI_MAX_DATA_SIZE (HSSPI_FIFO_SIZE - HSSPI_FIFO_OP_SIZE) >> + >> +#define SPIM_CTRL_CS_OVERRIDE_SEL_SHIFT 0 >> +#define SPIM_CTRL_CS_OVERRIDE_SEL_MASK 0xff >> +#define SPIM_CTRL_CS_OVERRIDE_VAL_SHIFT 8 >> +#define SPIM_CTRL_CS_OVERRIDE_VAL_MASK 0xff >> + >> +struct bcmbca_hsspi_priv { >> + void __iomem *regs; >> + void __iomem *spim_ctrl; >> + u32 clk_rate; >> + u8 num_cs; >> + u8 cs_pols; >> + u32 speed; >> +}; >> + >> +static int bcmbca_hsspi_cs_info(struct udevice *bus, uint cs, >> + struct spi_cs_info *info) >> +{ >> + struct bcmbca_hsspi_priv *priv = dev_get_priv(bus); >> + >> + if (cs >= priv->num_cs) { >> + dev_err(bus, "no cs %u\n", cs); >> + return -EINVAL; >> + } >> + >> + return 0; >> +} >> + >> +static int bcmbca_hsspi_set_mode(struct udevice *bus, uint mode) >> +{ >> + struct bcmbca_hsspi_priv *priv = dev_get_priv(bus); >> + >> + /* clock polarity */ >> + if (mode & SPI_CPOL) >> + setbits_32(priv->regs + SPI_CTL_REG, SPI_CTL_CLK_POL_MASK); >> + else >> + clrbits_32(priv->regs + SPI_CTL_REG, SPI_CTL_CLK_POL_MASK); >> + >> + return 0; >> +} >> + >> +static int bcmbca_hsspi_set_speed(struct udevice *bus, uint speed) >> +{ >> + struct bcmbca_hsspi_priv *priv = dev_get_priv(bus); >> + >> + priv->speed = speed; >> + >> + return 0; >> +} >> + >> +static void bcmbca_hsspi_setup_clock(struct bcmbca_hsspi_priv *priv, >> + struct dm_spi_slave_plat *plat) >> +{ >> + u32 clr, set; >> + >> + /* profile clock */ >> + set = DIV_ROUND_UP(priv->clk_rate, priv->speed); >> + set = DIV_ROUND_UP(2048, set); >> + set &= SPI_PFL_CLK_FREQ_MASK; >> + set |= SPI_PFL_CLK_RSTLOOP_MASK; >> + writel(set, priv->regs + SPI_PFL_CLK_REG(plat->cs)); >> + >> + /* profile signal */ >> + set = 0; >> + clr = SPI_PFL_SIG_LAUNCHRIS_MASK | >> + SPI_PFL_SIG_LATCHRIS_MASK | >> + SPI_PFL_SIG_ASYNCIN_MASK; >> + >> + /* latch/launch config */ >> + if (plat->mode & SPI_CPHA) >> + set |= SPI_PFL_SIG_LAUNCHRIS_MASK; >> + else >> + set |= SPI_PFL_SIG_LATCHRIS_MASK; >> + >> + /* async clk */ >> + if (priv->speed > SPI_MAX_SYNC_CLOCK) >> + set |= SPI_PFL_SIG_ASYNCIN_MASK; >> + >> + clrsetbits_32(priv->regs + SPI_PFL_SIG_REG(plat->cs), clr, set); > > I think this won't change every time cs changes, isn't it? if so mode > code has to move set_mode and the speed code has to move set_speed. > The controller setting will change if different spi slave select has different settings. The set_mode and set_speed code in this driver do take care some of the settings but these settings need to be applied at the beginning of the transfer. This is same as the original bcm63xx driver. >> + >> + /* global control */ >> + set = 0; >> + clr = 0; >> + >> + if (priv->cs_pols & BIT(plat->cs)) >> + set |= BIT(plat->cs); >> + else >> + clr |= BIT(plat->cs); >> + >> + clrsetbits_32(priv->regs + SPI_CTL_REG, clr, set); >> +} >> + >> +static void bcmbca_hsspi_activate_cs(struct bcmbca_hsspi_priv *priv, >> + struct dm_spi_slave_plat *plat) >> +{ >> + u32 val; >> + >> + /* set the override bit */ >> + val = readl(priv->spim_ctrl); >> + val |= BIT(plat->cs + SPIM_CTRL_CS_OVERRIDE_SEL_SHIFT); >> + writel(val, priv->spim_ctrl); >> +} >> + >> +static void bcmbca_hsspi_deactivate_cs(struct bcmbca_hsspi_priv *priv, >> + struct dm_spi_slave_plat *plat) >> +{ >> + u32 val; >> + >> + /* clear the cs override bit */ >> + val = readl(priv->spim_ctrl); >> + val &= ~BIT(plat->cs + SPIM_CTRL_CS_OVERRIDE_SEL_SHIFT); >> + writel(val, priv->spim_ctrl); >> +} >> + >> +static int bcmbca_hsspi_xfer(struct udevice *dev, unsigned int bitlen, >> + const void *dout, void *din, unsigned long flags) >> +{ >> + struct bcmbca_hsspi_priv *priv = dev_get_priv(dev->parent); >> + struct dm_spi_slave_plat *plat = dev_get_parent_plat(dev); >> + size_t data_bytes = bitlen / 8; >> + size_t step_size = HSSPI_FIFO_SIZE; >> + u16 opcode = 0; >> + u32 val = SPI_PFL_MODE_FILL_MASK; >> + const u8 *tx = dout; >> + u8 *rx = din; >> + u32 cs_act = 0; >> + >> + if (flags & SPI_XFER_BEGIN) >> + bcmbca_hsspi_setup_clock(priv, plat); >> + >> + /* fifo operation */ >> + if (tx && rx) >> + opcode = HSSPI_FIFO_OP_READ_WRITE; >> + else if (rx) >> + opcode = HSSPI_FIFO_OP_CODE_R; >> + else if (tx) >> + opcode = HSSPI_FIFO_OP_CODE_W; >> + >> + if (opcode != HSSPI_FIFO_OP_CODE_R) >> + step_size -= HSSPI_FIFO_OP_SIZE; >> + >> + /* dual mode */ >> + if ((opcode == HSSPI_FIFO_OP_CODE_R && (plat->mode & SPI_RX_DUAL)) || >> + (opcode == HSSPI_FIFO_OP_CODE_W && (plat->mode & SPI_TX_DUAL))) { >> + opcode |= HSSPI_FIFO_OP_MBIT_MASK; >> + >> + /* profile mode */ >> + if (plat->mode & SPI_RX_DUAL) >> + val |= SPI_PFL_MODE_MDRDSZ_MASK; >> + if (plat->mode & SPI_TX_DUAL) >> + val |= SPI_PFL_MODE_MDWRSZ_MASK; >> + } >> + >> + if (plat->mode & SPI_3WIRE) >> + val |= SPI_PFL_MODE_3WIRE_MASK; >> + writel(val, priv->regs + SPI_PFL_MODE_REG(plat->cs)); >> + >> + /* transfer loop */ >> + while (data_bytes > 0) { >> + size_t curr_step = min(step_size, data_bytes); >> + int ret; >> + >> + /* copy tx data */ >> + if (tx) { >> + memcpy_toio(priv->regs + HSSPI_FIFO_BASE + >> + HSSPI_FIFO_OP_SIZE, tx, curr_step); >> + tx += curr_step; >> + } >> + >> + /* set fifo operation */ >> + writew(cpu_to_be16(opcode | (curr_step & HSSPI_FIFO_OP_BYTES_MASK)), >> + priv->regs + HSSPI_FIFO_OP_REG); >> + >> + /* make sure we keep cs active until spi transfer is done */ >> + if (!cs_act) { >> + bcmbca_hsspi_activate_cs(priv, plat); >> + cs_act = 1; >> + } >> + >> + /* issue the transfer */ >> + val = SPI_CMD_OP_START; >> + val |= (plat->cs << SPI_CMD_PFL_SHIFT) & >> + SPI_CMD_PFL_MASK; >> + val |= (plat->cs << SPI_CMD_SLAVE_SHIFT) & >> + SPI_CMD_SLAVE_MASK; >> + writel(val, priv->regs + SPI_CMD_REG); >> + >> + /* wait for completion */ >> + ret = wait_for_bit_32(priv->regs + SPI_STAT_REG, >> + SPI_STAT_SRCBUSY_MASK, false, >> + 1000, false); >> + if (ret) { >> + bcmbca_hsspi_deactivate_cs(priv, plat); >> + dev_err(dev, "interrupt timeout\n"); >> + return ret; >> + } >> + >> + data_bytes -= curr_step; >> + if ((flags & SPI_XFER_END) && !data_bytes) >> + bcmbca_hsspi_deactivate_cs(priv, plat); >> + >> + /* copy rx data */ >> + if (rx) { >> + memcpy_fromio(rx, priv->regs + HSSPI_FIFO_BASE, >> + curr_step); >> + rx += curr_step; >> + } >> + } >> + >> + return 0; >> +} >> + >> +static const struct dm_spi_ops bcmbca_hsspi_ops = { >> + .cs_info = bcmbca_hsspi_cs_info, >> + .set_mode = bcmbca_hsspi_set_mode, >> + .set_speed = bcmbca_hsspi_set_speed, >> + .xfer = bcmbca_hsspi_xfer, >> +}; >> + >> +static const struct udevice_id bcmbca_hsspi_ids[] = { >> + { .compatible = "brcm,bcmbca-hsspi-v1.1", }, >> + { /* sentinel */ } >> +}; >> + >> +static int bcmbca_hsspi_child_pre_probe(struct udevice *dev) >> +{ >> + struct bcmbca_hsspi_priv *priv = dev_get_priv(dev->parent); >> + struct dm_spi_slave_plat *plat = dev_get_parent_plat(dev); >> + u32 val; >> + >> + /* check cs */ >> + if (plat->cs >= priv->num_cs) { >> + dev_err(dev, "no cs %u\n", plat->cs); >> + return -EINVAL; >> + } >> + >> + /* cs polarity */ >> + if (plat->mode & SPI_CS_HIGH) >> + priv->cs_pols |= BIT(plat->cs); >> + else >> + priv->cs_pols &= ~BIT(plat->cs); >> + >> + /* set the polarity to spim cs register */ >> + val = readl(priv->spim_ctrl); >> + val &= ~BIT(plat->cs + SPIM_CTRL_CS_OVERRIDE_VAL_SHIFT); >> + if (priv->cs_pols & BIT(plat->cs)) >> + val |= BIT(plat->cs + SPIM_CTRL_CS_OVERRIDE_VAL_SHIFT); >> + writel(val, priv->spim_ctrl); > > What is this code for cannot we handle this via set_mode or xfer? > This is the new register introduced in this controller to allow the driver to override the cs signal high and low from the controller so driver can control it directly. In the old controller, driver has no control over cs at all. Here we preset the OVERRIDE_VAL based on the cs_pols setting so the actually bcmbca_hsspi_activate/deactivate_cs function just need to set the OVERRIDE_SEL bit. The bcmbca_hsspi_activate/deactivate_cs functions has to be called right befer and after the controller start/finish the transation so can not be set via set_mode and xfer > Jagan. > --000000000000f5f29705fd2a1218 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDDG6HZcbcVdEvVYk4TANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxMTMxNDVaFw0yNTA5MTAxMTMxNDVaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVdpbGxpYW0gWmhhbmcxKTAnBgkqhkiG9w0B CQEWGndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAyKF+RmY29Wvfmfe3L8J4rZNmBIvRmrWKI5td5L0vlpPMCEzUkVhBdL2N9cDP0rPScvWL CX/9cI1a2BUy/6/ZT5j9PhcUn6A3kwKFGukLY2itfKaDrP3ANVJGhBXPVJ6sx55GF41PkiL2EMnY 7LJGNpl9WHYrw8VqtRediPyXq8M6ZWGPZWxygsE6y1pOkEk9qLpvXTb2Epxk2JWcQFZQCDWVULue YDZuuBJwnyCzevMoPtVYPharioL5H3BRnQi8YoTXH7/uRo33dewYFm474yFjwwnt82TFtveVZkVq 6h4WIQ4wTcwFfET8zMkELnGzS5SHCl8sPD+lNxxJ1JDZYwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRp3aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUq65GzwZxydFHjjYEU/9h xHhPWlwwDQYJKoZIhvcNAQELBQADggEBAA2hGG3JPAdGPH0ZdohGUCIVjKz+U+EFuIDbS6A/5jqX VhYAxZlzj7tSjUIM7G7IhyfqPC46GKJ/4x+Amz1Z6YxNGy71L68kYD6hIbBcA5AM42QBUufly6Oa /ppSz3WoflVyFFQ5YXniZ+eU+2/cdnYZg4aVUnFjimOF5o3NfMLzOkhQNxbaDjFUfUYD8hKmU6v4 0vUBj8KZ9Gi1LIagLKUREn8jku0lcLsRbnJ5Ey5ScajC/FESPyYWasOW8j8/1EoJksmhbYGKNS6C urb/KlmDGfVrIRYDbL0ckhGQIP5c6L+kSQZ2sHnQK0e0WgIaZYxaPYeY5u0GLCOze+3vyRMxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwxuh2XG3FXRL1W JOEwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIE/I+9TMUgcUgsCYCDtkfEZYFTb6 MAcPIZ2GLOSfNTShMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIz MDYwMjE4NTM1MlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQC7AuvtN3DQUzeKivmBOnRET8lABtTX/7RvV0FYqbxF9dpq 1wTgf8A8clEIUEbmctM8zNb2ES6dyATKPVXyoFXG6e198GMzjZcXxawTjWjoipovgFtCvGF7pTXj D3YBr9DcABi1+Do6JWsBGuGvaqSIL1DwHo4Jg2YwSM9Pe0v/hjklkNRSbtXpJu3T5dvBMYR55ppZ /cxSuO5eimz20Rnen0SFyXSwXKxBo7hvcGumQ0xw50O6AqukxuplV0PnFlriPgYyNyQOgofNJ299 AbgJQP7MshNGbT9qdg7T8UBdrN+VmpkL71xgOdWOCSYxLvqDWzTC3GkJ+jzGnDCT8YGL --000000000000f5f29705fd2a1218--