From: Florian Fainelli <f.fainelli@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board: arm: Add support for Broadcom BCM7260
Date: Sat, 18 Aug 2018 09:21:50 -0700 [thread overview]
Message-ID: <7e6fdeea-442d-d86c-5ba8-035626bc7a03@gmail.com> (raw)
In-Reply-To: <20180817014406.29998-1-fitzsim@fitzsim.org>
On 08/16/2018 06:44 PM, Thomas Fitzsimmons wrote:
> Add support for loading U-Boot on the Broadcom 7260 SoC. This port
> assumes Broadcom's BOLT bootloader is acting as the second stage
> bootloader, and U-Boot is acting as the third stage bootloader, loaded
> as an ELF program by BOLT.
>
> Signed-off-by: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Looks good to me given the structured you added earlier for 7445
support, just one nit below:
[snip]
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#define CONFIG_SYS_NS16550_COM3 0xf040c000
This is the physical address of UARTA, there are typically 3 UARTs on
those SoCs, is there a reason to name this COM3 and not COM1? If this is
an established u-boot convention, pardon my ignore here.
--
Florian
next prev parent reply other threads:[~2018-08-18 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 1:44 [U-Boot] [PATCH] board: arm: Add support for Broadcom BCM7260 Thomas Fitzsimmons
2018-08-18 16:21 ` Florian Fainelli [this message]
2018-08-23 1:07 ` Thomas Fitzsimmons
2018-08-22 22:37 ` [U-Boot] [PATCH v2 0/2] " Thomas Fitzsimmons
2018-08-22 22:37 ` [U-Boot] [PATCH v2 1/2] arm: bcm7445: Change serial console index Thomas Fitzsimmons
2018-09-11 12:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-08-22 22:37 ` [U-Boot] [PATCH v2 2/2] board: arm: Add support for Broadcom BCM7260 Thomas Fitzsimmons
2018-09-11 12:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6fdeea-442d-d86c-5ba8-035626bc7a03@gmail.com \
--to=f.fainelli@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox