From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Kautuk Consul" <kconsul@ventanamicro.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2 0/3] Add riscv semihosting support in u-boot
Date: Sat, 17 Sep 2022 13:24:51 -0400 [thread overview]
Message-ID: <7f21d911-63fd-856d-bed3-0875da04d249@gmail.com> (raw)
In-Reply-To: <20220916143257.GL6993@bill-the-cat>
On 9/16/22 10:32, Tom Rini wrote:
> On Fri, Sep 16, 2022 at 09:11:11AM -0400, Sean Anderson wrote:
>> Hi Pali,
>>
>> On 9/16/22 05:12, Pali Rohár wrote:
>>> That is strange because I'm not aware of the fact that I'm riscv maintainer.
>>
>> get_maintainer will pick up anyone who has touched a file recently, even in
>> unrelated areas. A quick git log shows that the following commits have
>> overlapping files with this series:
>>
>> 948da7773e arm: Add new config option ARCH_VERY_EARLY_INIT
>> 1a47e6d47c crc16: Move standard CRC-16 implementation from ubifs to lib
>> bb3d71b7ef crc16-ccitt: Rename file with CRC-16-CCITT implementation to crc16-ccitt.c
>> 372779abc3 arm: Introduce new CONFIG_SPL_SYS_NO_VECTOR_TABLE option
>>
>> I'm not a fan of this behavior, so I edit the output of get_maintainers
>> before using it.
>
> Does --no-git provide the behavior you're both looking for? We should
> likely tweak the .get_maintainers.conf file.
>
Yes, but sometimes this information is nice to see. Maybe we should
tweak --git-min-signatures to 2? That would help exclude a lot of
one-off commits, but it wouldn't help with people modifying unrelated
areas (especially in things like Kconfigs/Makefiles). TBH when including
people by activity, I usually inspect the git log and include only
people who are making semantic changes to the file. Of course, this
doesn't work for files which have had few contributors in the past
year...
--Sean
next prev parent reply other threads:[~2022-09-17 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 8:12 [PATCH v2 0/3] Add riscv semihosting support in u-boot Kautuk Consul
2022-09-16 8:12 ` [PATCH v2 1/3] lib: Add common semihosting library Kautuk Consul
2022-09-17 17:39 ` Sean Anderson
2022-09-19 11:14 ` Kautuk Consul
2022-09-16 8:12 ` [PATCH v2 2/3] arch/riscv: add semihosting support for RISC-V Kautuk Consul
2022-09-16 8:12 ` [PATCH v2 3/3] board: qemu-riscv: enable semihosting Kautuk Consul
2022-09-16 9:08 ` [PATCH v2 0/3] Add riscv semihosting support in u-boot Pali Rohár
2022-09-16 9:10 ` Kautuk Consul
2022-09-16 9:12 ` Pali Rohár
2022-09-16 13:11 ` Sean Anderson
2022-09-16 14:32 ` Tom Rini
2022-09-17 17:24 ` Sean Anderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-16 8:19 Kautuk Consul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f21d911-63fd-856d-bed3-0875da04d249@gmail.com \
--to=seanga2@gmail.com \
--cc=kconsul@ventanamicro.com \
--cc=pali@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox