From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B0F9C54E94 for ; Wed, 25 Jan 2023 22:50:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 271878546F; Wed, 25 Jan 2023 23:50:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="zy4yKcYm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F2A784954; Wed, 25 Jan 2023 23:50:27 +0100 (CET) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3702585665 for ; Wed, 25 Jan 2023 23:50:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=khilman@baylibre.com Received: by mail-pj1-x1032.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so102460pjb.5 for ; Wed, 25 Jan 2023 14:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Rw2An9fmmNRHjmRIQOYwVvm8CzzR6o+LuR0fdTz/6m8=; b=zy4yKcYmEVF81aT0s+TDGU/augzaoc7I4SKR+nOvgJuJywxEOvGJMtIrZW+kCSXhBy ltEosJW/sdIzJQzkwmoaiIqPmNZvLKjjIJ5fUwpZKTnr5QZ/55rP5u4bJu+5xUt9EI4N iapz121iu+UhNUTTk8G+pZsAf9Vqo9xF6pi6Y/82fT+Cy/GkQvTxup+d1CiYbOBMxcED 45woD8tmkyPjl4EeXrO2i8Pl6RFZBeNa6updqOfuwqRXjaY3uluyYIq4angClJGKW0rf tqfKML8JC4e2ccaqh4hyZLmwB+0eXf4xAIU4RA9TH3AnqSRukj9IwwNGzDLCPGgpmU1Y jOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rw2An9fmmNRHjmRIQOYwVvm8CzzR6o+LuR0fdTz/6m8=; b=SxEw4L7otVOzKNsWO3Lu1xQx43K2R4AVGb0sl8QXb4se53IEM2b7ZvRLm8mRvB5ad/ ow7nuYa5ZiJmVyIzeIzoVnqDAR057atdNLdJBP9Kn3klSo8ZpSEheyDzfBEBrjLJp+7w kea0Jw41eK8sPmQ826EqQ5VI6U3n5bVHLy/cm6hoX2xpkHKjPActl82uFyAMh1BZtwhp mPVMklOzMPbs4gN0tvHKJ8rwDgpMWdHLPbAL9gNaGVrax5W+Go0SHrBUhLwxrYnY7x2x ClnTdxE/LeBwOkTe/0OvBE2+X57mivVlOI/90qrkRUwvAYAp6+swSz0BHQec7CZVSWio pSsA== X-Gm-Message-State: AFqh2ko3rkm1fK9TA4yI6OdcCs9ZDOV38Y8o4A1lm5VIk36NroQy9JKZ UETRexRxn2e0cAi4AionSTKcw7ztSZQt3Wr6rt8= X-Google-Smtp-Source: AMrXdXsnOxyaLlekkpnA2TnTA051CpdeTRlVTyrSuz/95atFIlNEfJBCBWPwvXvBaoYb4g3vuvKOHA== X-Received: by 2002:a17:903:1210:b0:195:e86b:948b with SMTP id l16-20020a170903121000b00195e86b948bmr27706250plh.50.1674687022417; Wed, 25 Jan 2023 14:50:22 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id o22-20020a170902779600b00192820d00d0sm4143275pll.120.2023.01.25.14.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 14:50:21 -0800 (PST) From: Kevin Hilman To: Niel Fourie , u-boot@lists.denx.de Cc: Niel Fourie , Marek Vasut , Lukasz Majewski , Ramon Fried Subject: Re: [PATCH v2] usb: gadget: ether: split start/stop from init/halt In-Reply-To: <20230120171518.896027-1-lusus@denx.de> References: <20230120171518.896027-1-lusus@denx.de> Date: Wed, 25 Jan 2023 14:50:17 -0800 Message-ID: <7hk01agrfa.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Niel Fourie writes: > Split out _usb_eth_start() from _usb_eth_init() and > usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only > initialises and registers the gadget device, which _usb_eth_halt() > reverses, and together are used for probing and removing the > device. The _usb_eth_start() and _usb_eth_stop() functions connect > and disconnect the gadget as expected by the start()/stop() > callbacks. > > Previously the gadget device was probed on every start() and > removed on every stop(), which is inconsistent with other DM_ETH > drivers. By suggestion from Marek, I was testing this patch and discovered that it broke fastboot over USB support. With this patch applied on top of v2022.10, I'm seeing: => fastboot 0 couldn't find an available UDC g_dnl_register: failed!, error: -19 Kevin