From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Hilman <khilman@kernel.org>
Date: Wed, 21 Jan 2015 11:01:00 -0800
Subject: [U-Boot] Odroid XU3 - exynos5422 - SPL - iRAM/sRAM address
In-Reply-To: <CANoR_OABDwqLLvsC_R1OV_JepfRVm7GJC+ChC4_tHKU27QDd5Q@mail.gmail.com>
	(Suriyan Ramasami's message of "Tue, 20 Jan 2015 15:38:54 -0800")
References: <CANoR_OBusZCF1cRFhrTem1hh86pJpGOFU-u2Jw+MGfAHi1sxXQ@mail.gmail.com>
	<CANoR_OCPauSqFZqos48wBPXjBSu1triHC1ftXko6Rs3y-jaWVg@mail.gmail.com>
	<1421746560.6818.37.camel@collabora.co.uk>
	<1421772007.6818.42.camel@collabora.co.uk>
	<CANoR_OCS5898r2yXRsvVXcm6E12oGDPmHUTh_oqGrXDcgu4D+A@mail.gmail.com>
	<7hy4oxf8cv.fsf@deeprootsystems.com>
	<CANoR_OB-3XnqiMgA7TO+0FznizG1RnijS13+S7Sdgx=q1K1VyA@mail.gmail.com>
	<7hzj9ddqfd.fsf@deeprootsystems.com>
	<CANoR_OA9pnPNeY5YLdXs6UuarHtymwTbe=5HDETJz24SXHyBzg@mail.gmail.com>
	<CANoR_OABDwqLLvsC_R1OV_JepfRVm7GJC+ChC4_tHKU27QDd5Q@mail.gmail.com>
Message-ID: <7hr3uo7yc3.fsf@deeprootsystems.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Suriyan Ramasami <suriyan.r@gmail.com> writes:

> Hello Kevin,
>
> On Tue, Jan 20, 2015 at 3:29 PM, Suriyan Ramasami <suriyan.r@gmail.com> wrote:
>> Hello Kevin,
>>
>> On Tue, Jan 20, 2015 at 2:43 PM, Kevin Hilman <khilman@kernel.org> wrote:
>>> Suriyan Ramasami <suriyan.r@gmail.com> writes:
>>>
>>>> Hello Kevin,
>>>>    These are the changes that would be necessary in uboot mainline for SPL:
>>>>
>>>> arch/arm/cpu/armv7/exynos/Kconfig
>>>> -       select OF_CONTROL
>>>> +       select SUPPORT_SPL
>>>> +       select OF_CONTROL if !SPL_BUILD
>>>>
>>>> configs/odroid-xu3_defconfig
>>>> +CONFIG_SPL=y
>>>>
>>>> include/configs/odroid_xu3.h
>>>> #undef CONFIG_SPL_TEXT_BASE
>>>> #define CONFIG_SPL_TEXT_BASE           0x02027000
>>>>
>>>> #undef CONFIG_SEC_FW_SIZE
>>>> #define CONFIG_SEC_FW_SIZE (15 << 10) /* 15 KB */
>>>
>>> Thanks.  With those changes, a build gives me:
>>>
>>> ./include/common.h:355:73: fatal error: asm/u-boot-sandbox.h: No such file or directory
>>>
>>> Sorry for the dumb questions, but I'm not very familiar with u-boot.
>>> I'm more comofortable in the kernel.
>>>
>>
>> The above used to work (a month ago). I shall check with current
>> mainline uboot and report back.
>>
>
> Sorry for the snafu. I t was my mistake. The correct diff for the
> configs is as below:
>
> diff --git a/arch/arm/cpu/armv7/exynos/Kconfig
> b/arch/arm/cpu/armv7/exynos/Kconfig
> index 7fcb5d2..39953e4 100644
> --- a/arch/arm/cpu/armv7/exynos/Kconfig
> +++ b/arch/arm/cpu/armv7/exynos/Kconfig
> @@ -26,7 +26,8 @@ config TARGET_ODROID
>
>  config TARGET_ODROID_XU3
>         bool "Exynos5422 Odroid board"
> -       select OF_CONTROL
> +       select SUPPORT_SPL
> +       select OF_CONTROL if !SPL_BUILD
>
>  config TARGET_ARNDALE
>         bool "Exynos5250 Arndale board"
> diff --git a/configs/odroid-xu3_defconfig b/configs/odroid-xu3_defconfig
> index 74aa0cf..6000ec1 100644
> --- a/configs/odroid-xu3_defconfig
> +++ b/configs/odroid-xu3_defconfig
> @@ -1,4 +1,5 @@
> -CONFIG_ARM=y
> -CONFIG_ARCH_EXYNOS=y
> -CONFIG_TARGET_ODROID_XU3=y
> +CONFIG_SPL=y
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_EXYNOS=y
> ++S:CONFIG_TARGET_ODROID_XU3=y
>  CONFIG_DEFAULT_DEVICE_TREE="exynos5422-odroidxu3"

Thanks, that gets things building.  Just to double-check, no additional
changes to include/configs/odroid_xu3.h?

Also, which image are you using as your unsigned BL2? spl/u-boot-spl.bin
or spl/smdk5420-spl.bin?  

The later seems to be generated from the former using tools/mkexynosspl,
but not sure exactly what it's doing, or if its needed on all boards or
just the smdk5420 (as the name implies).

Thanks,

Kevin