public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] odroid-XU3: Add entry for DTS EHCI GPIO
Date: Mon, 08 Dec 2014 20:25:59 -0800	[thread overview]
Message-ID: <7hsigpsb3c.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CANoR_OATXZ9ZDkTLjkyCjE_WY5S_wkyQxSoic5i5La5UJOng5g@mail.gmail.com> (Suriyan Ramasami's message of "Mon, 8 Dec 2014 19:36:46 -0800")

Suriyan Ramasami <suriyan.r@gmail.com> writes:

> Hello Hyungwon Hwang,
>
> On Mon, Dec 8, 2014 at 7:01 PM, Hyungwon Hwang <human.hwang@samsung.com> wrote:
>> Dear Sjoerd,
>>
>> On Fri, 05 Dec 2014 21:26:10 +0100
>> Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
>>
>>> Add samsung,vbus-gpio information for the XU3. This allows the usage
>>> of the EHCI controller on the XU3, which is connected to the SMSC
>>> LAN9514 chip (usb hub + network).
>>>
>>> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>>> ---
>>> Changes since v1:
>>>   + Correct gpio number
>>>   + Add USB configuration in the odroid XU3 default config
>>>
>>> Hyungwon could you add this one to your XU3 patchset if you send a
>>> next version (assuming it looks good)?
>>>
>>
>> Does it work only with this patch? I applied this patch on top of my
>> patchset, and connected the ethernet cable to the device. But it
>> seemed not working. Is there anything else that I should do for test?
>>
>>> For usb storage/network support this patch should be combined
>>> with the exynos configuration tweaks patch i submited earlier to the
>>> list: Exynos: Move down common USB configuration
>>>
>>>  arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++
>>>  include/configs/odroid_xu3.h          | 4 ++++
>>>  2 files changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
>>> b/arch/arm/dts/exynos5422-odroidxu3.dts index cff32a9..79a7acd 100644
>>> --- a/arch/arm/dts/exynos5422-odroidxu3.dts
>>> +++ b/arch/arm/dts/exynos5422-odroidxu3.dts
>>> @@ -31,6 +31,10 @@
>>>                       0xb0000000 0xea00000>;
>>>       };
>>>
>>> +     ehci at 12110000 {
>>> +             samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */
>>> +     };
>>> +
>>>       serial at 12C20000 {
>>>               status="okay";
>>>       };
>>> diff --git a/include/configs/odroid_xu3.h
>>> b/include/configs/odroid_xu3.h index 88bb98d..aa0c142 100644
>>> --- a/include/configs/odroid_xu3.h
>>> +++ b/include/configs/odroid_xu3.h
>>> @@ -47,6 +47,10 @@
>>>
>>>  #define
>>> CONFIG_DEFAULT_CONSOLE                "console=ttySAC2,115200n8\0"
>>> +/* USB */
>>> +#define CONFIG_USB_EHCI
>>> +#define CONFIG_USB_EHCI_EXYNOS
>>> +
>>>  /* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */
>>>  #undef CONFIG_EXYNOS_TMU
>>>  #undef CONFIG_TMU_CMD_DTT
>>
>
> In odroid_xu3.h you might want to add the below as well (for LAN + USB storage)
>
> +/* Enable USB */
> +#define CONFIG_CMD_USB
> +#define CONFIG_USB_EHCI
> +#define CONFIG_USB_EHCI_EXYNOS
> +#define CONFIG_USB_STORAGE
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_USB_HOST_ETHER
> +#define CONFIG_USB_ETHER_SMSC95XX

+1

I enabled these locally on v10 so that I could DHCP and TFTP boot.

Kevin

  parent reply	other threads:[~2014-12-09  4:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 20:26 [U-Boot] [PATCH v2] odroid-XU3: Add entry for DTS EHCI GPIO Sjoerd Simons
2014-12-09  3:01 ` Hyungwon Hwang
2014-12-09  3:36   ` Suriyan Ramasami
2014-12-09  4:10     ` Hyungwon Hwang
2014-12-09  7:44       ` Sjoerd Simons
2014-12-09  4:25     ` Kevin Hilman [this message]
2014-12-22 12:22 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hsigpsb3c.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox