public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] fix build without CONFIG_NET_MULTI
@ 2005-06-30  8:39 Murray.Jensen at csiro.au
  2005-06-30 11:11 ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Murray.Jensen at csiro.au @ 2005-06-30  8:39 UTC (permalink / raw)
  To: u-boot

This is an older patch which fixed building without CONFIG_NET_MULTI. I'm
not sure if its still required or not, since I now use CONFIG_NET_MULTI
when building for my boards. I guess it might help someone if they search
the list after striking a similar problem. I would think this would need
some testing before it gets applied to the central repository. Cheers!
								Murray...
--
Murray Jensen, CSIRO Manufacturing & Infra. Tech.      Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia.         Fax: +61 3 9662 7853
Internet: Murray.Jensen at csiro.au

To the extent permitted by law, CSIRO does not represent, warrant and/or
guarantee that the integrity of this communication has been maintained or
that the communication is free of errors, virus, interception or interference.

The information contained in this e-mail may be confidential or privileged.
Any unauthorised use or disclosure is prohibited. If you have received this
e-mail in error, please delete it immediately and notify Murray Jensen on
+61 3 9662 7763. Thank you.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 721 bytes
Desc: no-net-multi-fix.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050630/cb34a908/attachment.bin 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] fix build without CONFIG_NET_MULTI
  2005-06-30  8:39 [U-Boot-Users] [PATCH] fix build without CONFIG_NET_MULTI Murray.Jensen at csiro.au
@ 2005-06-30 11:11 ` Wolfgang Denk
  2005-06-30 13:48   ` Murray.Jensen at csiro.au
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2005-06-30 11:11 UTC (permalink / raw)
  To: u-boot

In message <29533.1120120770@gerd> you wrote:
>
> This is an older patch which fixed building without CONFIG_NET_MULTI. I'm
> not sure if its still required or not, since I now use CONFIG_NET_MULTI
> when building for my boards. I guess it might help someone if they search
> the list after striking a similar problem. I would think this would need
> some testing before it gets applied to the central repository. Cheers!

Please don't post random patches where you don't even  know  yourself
if  they  really  fix  a problem or not. And please don't continue to
ignore the patch submission guidelines.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I read part of it all the way through.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] fix build without CONFIG_NET_MULTI
  2005-06-30 11:11 ` Wolfgang Denk
@ 2005-06-30 13:48   ` Murray.Jensen at csiro.au
  0 siblings, 0 replies; 3+ messages in thread
From: Murray.Jensen at csiro.au @ 2005-06-30 13:48 UTC (permalink / raw)
  To: u-boot

On Thu, 30 Jun 2005 13:11:49 +0200, Wolfgang Denk writes:
>Please don't post random patches where you don't even  know  yourself
>if  they  really  fix  a problem or not.

Its hardly random. This was a patch which fixed a specific problem in the
past - i.e. the case where CONFIG_NET_MULTI is NOT defined.

It doesn't look like there are a lot of boards where this variable *isn't*
defined. Mine was one of them though (since it is many years old now).

But I have since decided that CONFIG_NET_MULTI is a very good thing and have
started using it, but I thought my patch might help someone else, so I posted
it anyway, in the spirit of cooperation which our opensource community should
encourage.

At the moment though, getting back into this mailing list after quite a long
break, it feels like this spirit might be waning a bit.

>And please don't continue to
>ignore the patch submission guidelines.

No worries - when I find them, I will comply with them. See previous email.
Cheers!
								Murray...
--
Murray Jensen, CSIRO Manufacturing & Infra. Tech.      Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia.         Fax: +61 3 9662 7853
Internet: Murray.Jensen at csiro.au

To the extent permitted by law, CSIRO does not represent, warrant and/or
guarantee that the integrity of this communication has been maintained or
that the communication is free of errors, virus, interception or interference.

The information contained in this e-mail may be confidential or privileged.
Any unauthorised use or disclosure is prohibited. If you have received this
e-mail in error, please delete it immediately and notify Murray Jensen on
+61 3 9662 7763. Thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-06-30 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-30  8:39 [U-Boot-Users] [PATCH] fix build without CONFIG_NET_MULTI Murray.Jensen at csiro.au
2005-06-30 11:11 ` Wolfgang Denk
2005-06-30 13:48   ` Murray.Jensen at csiro.au

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox