From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/3] log: Fix segfault in sandbox when LOG_LEVEL_DEFAULT >= LOGL_DEBUG
Date: Sun, 13 Sep 2020 16:13:58 -0400 [thread overview]
Message-ID: <8021fb82-3fe7-b1b5-806e-26f4e40d4a5a@gmail.com> (raw)
In-Reply-To: <20200912214544.362594-1-seanga2@gmail.com>
On 9/12/20 5:45 PM, Sean Anderson wrote:
> Since the syslog feature has been introduced, sandbox no longer boots when
> LOG_LEVEL_DEFAULT prints cdebug messages. This is because it tries to call
> net_init before initf_dm.
>
>
> Sean Anderson (3):
> dev: Disambiguate errors in uclass_find
> net: Expose some errors generated in net_init
> log: syslog: Handle errors in net_init
>
> common/log_syslog.c | 4 +++-
> drivers/core/uclass.c | 16 +++++++++++++++-
> include/net.h | 2 +-
> net/eth-uclass.c | 3 +++
> net/net.c | 15 +++++++++++----
> test/dm/core.c | 2 +-
> test/dm/test-main.c | 2 +-
> 7 files changed, 35 insertions(+), 9 deletions(-)
>
This causes CI to fail in an interesting way [1]. Running `ut log` on a
fresh boot will have no failures. However, if `ut log` is run after `ut
dm`, then the tests will fail. From further investigation, it appears
that sb_log_tx_handler is not called at all when the tests fail.
I don't know whether this is a "real" test failure or a failure of the
unit testing framework. `ut dm` doesn't appear to be idempotent; every
time I run it on the same boot I get additional errors. What's stranger
is that running `ut all` has no failures, but running `ut dm` has 2
(both for usb_flash).
--Sean
[1] https://dev.azure.com/seanga2/u-boot/_build/results?buildId=30&view=logs&j=50449d1b-398e-53ae-48fa-6bf338edeb51&t=97605dd2-f5a5-5dd7-2118-315ffdc8bcd6&l=455
prev parent reply other threads:[~2020-09-13 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 21:45 [PATCH 0/3] log: Fix segfault in sandbox when LOG_LEVEL_DEFAULT >= LOGL_DEBUG Sean Anderson
2020-09-12 21:45 ` [PATCH 1/3] dev: Disambiguate errors in uclass_find Sean Anderson
2020-09-17 1:09 ` Simon Glass
2020-09-17 1:44 ` Sean Anderson
2020-09-17 3:44 ` Simon Glass
2020-09-12 21:45 ` [PATCH 2/3] net: Expose some errors generated in net_init Sean Anderson
2020-09-17 1:09 ` Simon Glass
2020-10-12 1:15 ` Tom Rini
2020-09-12 21:45 ` [PATCH 3/3] log: syslog: Handle errors " Sean Anderson
2020-09-17 1:09 ` Simon Glass
2020-10-12 1:15 ` Tom Rini
2020-09-13 20:13 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8021fb82-3fe7-b1b5-806e-26f4e40d4a5a@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox