From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 412A4C3601A for ; Mon, 7 Apr 2025 08:26:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B331A82C55; Mon, 7 Apr 2025 10:26:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="bbyYxn5I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 22D8882C87; Mon, 7 Apr 2025 10:26:26 +0200 (CEST) Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E531682BCD for ; Mon, 7 Apr 2025 10:26:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 5378QMCn814269 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Apr 2025 03:26:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1744014382; bh=bGmmOzmkuT/6rIQ9m01GNWrbX2szUY+CYH3dYTBy4RE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=bbyYxn5Ix+ffI9Pi65FW6mDL3Bpd1UcrVw7Ulxy6mcu3d8nY9Dmz00gCJ4lGKIFat HBMrD+oq+C/qMRKDL6aQyIDNIYxdhuw50kIbfY+R+LEggAI5h1gohHzxTsp4+Js5MV T4qleBpYEKoVeJUM6eIWteRFWF27TBD6AooKrgW8= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 5378QMns021292 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Apr 2025 03:26:22 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7 Apr 2025 03:26:21 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 7 Apr 2025 03:26:21 -0500 Received: from [10.24.69.37] (a0497641-hp-z2-tower-g9-workstation-desktop-pc.dhcp.ti.com [10.24.69.37] (may be forged)) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 5378QJJ8080214; Mon, 7 Apr 2025 03:26:19 -0500 Message-ID: <80256fa7-0903-4d89-a5cc-b521283cd17a@ti.com> Date: Mon, 7 Apr 2025 13:56:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mach-k3: common_fdt: Fix Label Issue To: "Kumar, Udit" , Daniel Schultz , , , , CC: , References: <20250407060711.3160366-1-d.schultz@phytec.de> <92ee150b-1873-4856-a3cb-8e9d6af78c33@ti.com> Content-Language: en-US From: Neha Malcom Francis In-Reply-To: <92ee150b-1873-4856-a3cb-8e9d6af78c33@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Udit On 07/04/25 13:51, Kumar, Udit wrote: > Hi Daniel. > > Thanks for patch > > On 4/7/2025 11:37 AM, Daniel Schultz wrote: >> Labels are not allowed before declarations. Add a semicolon after the >> label to introduce an empty statement. This will fix following error: >> >> arch/arm/mach-k3/common_fdt.c: In function 'fdt_fixup_reserved': >> arch/arm/mach-k3/common_fdt.c:156:2: error: a label can only be part >> of a statement and a declaration is not a statement >>    156 |  struct fdt_memory carveout = { >>        |  ^~~~~~ >> make[1]: *** [scripts/Makefile.build:256: >> arch/arm/mach-k3/common_fdt.o] Error 1 >> make: *** [Makefile:1919: arch/arm/mach-k3] Error 2 > > Is there some specific compiler option you are using, Sorry but I don't > see this error . > > i just build sha id e458e103d4f5fb7aaf13e744c65916ab3ba4a18d of next > I had run into the same issue when I was using v10.1 of the Arm GNU toolchain, moving to v14.2, I no longer see it. > >> >> Fixes: 096aa229a9e ("mach-k3: common_fdt: create a reserved memory node") >> >> Signed-off-by: Daniel Schultz >> --- >> >> I'm open to other suggestions! This is just the easiest way to fix this >> compile error. BTW, master is fine since 096aa229a9e is only on next. >> >>   arch/arm/mach-k3/common_fdt.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-k3/common_fdt.c >> b/arch/arm/mach-k3/common_fdt.c >> index 361b0c0b31b..7178918a12c 100644 >> --- a/arch/arm/mach-k3/common_fdt.c >> +++ b/arch/arm/mach-k3/common_fdt.c >> @@ -152,7 +152,7 @@ int fdt_fixup_reserved(void *blob, const char *name, >>           } >>       } >>   -add_carveout: >> +add_carveout: ; >>       struct fdt_memory carveout = { >>           .start = new_address, >>           .end = new_address + new_size - 1, > > My suggestion will be to move this struct at start of function. > > and change only size here > > carveout.end = new_address + new_size - 1; > > -- Thanking You Neha Malcom Francis