From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7811CD128A for ; Sun, 31 Mar 2024 23:48:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 15B4987E82; Mon, 1 Apr 2024 01:48:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=manjaro.org header.i=@manjaro.org header.b="W1js/S/U"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 881EA88131; Mon, 1 Apr 2024 01:48:45 +0200 (CEST) Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6101587DCD for ; Mon, 1 Apr 2024 01:48:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dsimic@manjaro.org MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1711928922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sr2fl89rVPYPlAA4zI8CkDjf2GNubdNcxJ3RIaQszPg=; b=W1js/S/U+mMlPKOBb85euBw72H6cOZZ1lVLZJ5TSsrdXMPq5KPLQXNZ8hYP2Midl1kVChb 3ZxdRsQiUUSfqvIOHSfmf7ZvSjW28Yvtq+sH7O7iZyYfu9UpWT0BOKHFKtfzFqHopvyjk0 ccIEVaKAdsgPXu4Dc98VSkj8AmszDNqnlZUn2CLWA5zjndRTyWmnFAdtxPvPmOD+DHbOKB 9IEpatuW7pNqawWmts1U8hgM70xk1zhJ3I2+WHcPpfwQGhTkxrIHwGmpGncJAgiPRFaAaf SxMm0IIu6FHFCko4Aj857UHUpGra/Jqd5K44IaPL+8oH5F24aMDETUbhkHq8sg== Date: Mon, 01 Apr 2024 01:48:42 +0200 From: Dragan Simic To: Jonas Karlman Cc: Kever Yang , Simon Glass , Philipp Tomsich , Tom Rini , FUKAUMI Naoki , Christopher Obbard , Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH 28/31] rockchip: rk3399-rock-pi-4: Sync device tree from linux v6.8 In-Reply-To: References: <20240331202921.262323-1-jonas@kwiboo.se> <20240331202921.262323-29-jonas@kwiboo.se> <3de901ef24bac4a84be53de528b2b766@manjaro.org> <2db72cee-f53e-4b2e-9e35-24883bc63bd6@kwiboo.se> <75e6364e805a9c5e13cab992b4c19b42@manjaro.org> Message-ID: <802b008919163cc7281f998e7c5d0e87@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2024-04-01 01:41, Jonas Karlman wrote: > On 2024-04-01 01:30, Dragan Simic wrote: >> On 2024-04-01 01:14, Jonas Karlman wrote: >>> On 2024-04-01 00:53, Dragan Simic wrote: >>>> Please see my comments below. >>>> >>>> On 2024-03-31 22:28, Jonas Karlman wrote: >>>>> Sync rk3399-rock-pi-4 related device tree from linux v6.8. >>>>> >>>>> Add SPI flash related options to support booting from SPI flash. >>>>> >>>>> Add AHCI=y, SCSI_AHCI=y, AHCI_PCI=y and SCSI=y to support PCIe SATA >>>>> boot. >>>> >>>> As we know, these boards have no standard connectors for PCI Express >>>> expansion cards, which makes me wonder how many users actually use >>>> M.2 >>>> PCI Express modules with SATA controllers on them with these boards, >>>> and need support for them in U-Boot? >>>> >>>> I mean, it can't hurt, but frankly, I'm not 100% sure about it. >>> >>> With the M.2 Extension Board [1] and a M.2 to PCIe X4 adapter it is >>> very >>> easy to convert the M.2 slot into a standard PCIe X4 slot and use it >>> with a PCIe SATA card. At least that is how I have tested and used >>> this. >> >> I was aware of the M.2 extension board sold by Radxa, but frankly, >> using it together with another adapter (M.2 to standard PCIe x4 slot) >> is a cumbersome setup. The whole thing becomes at least three times >> the size of the SBC, with cables and a dangling PCIe card. :) > > I know, it is not ideal, but works for my testing and development > proposes :-) > >> I had in mind an M.2 module with a PCIe SATA controller. [2] >> Something >> like that, used together with the M.2 extension board, would actually >> make a rather neat setup. > > I guess the Radxa Penta SATA HAT [3] is most likely use case for having > PCIe AHCI enabled. Ah, thanks for reminding me about this hat! I saw it once or twice, but I somehow forgot about it. Yes, that's very nice, and surely a use case for having AHCI support enabled. > [3] https://radxa.com/products/accessories/penta-sata-hat/ > > Regards, > Jonas > >> >> [2] >> https://www.reddit.com/r/selfhosted/comments/s0bf1d/m2_sata_expansion_anyone_use_something_like_this/ >> >>> I do think there will be many users of PCIe AHCI/SATA, but with this >>> series I try to get all boards to have same feature set as long as >>> there >>> is some way to use a feature. >> >> I guess it can't hurt in the end. >> >>> [1] https://radxa.com/products/accessories/m2-extension-board >>> >>>>> Change to SPL_MAX_SIZE=0x40000, SPL can be up to 256 KiB. >>>>> >>>>> Add ROCKCHIP_IODOMAIN=y to configure io-domain voltage. >>>>> >>>>> Add PHY_REALTEK=y and DM_ETH_PHY=y to support ethernet PHY. >>>>> >>>>> Remove SPL_TINY_MEMSET=y to use full memset in SPL. >>>>> >>>>> Signed-off-by: Jonas Karlman >>>> >>>> Otherwise, looking good to me. >>>> >>>> Reviewed-by: Dragan Simic >>> >>> Thanks! >>> >>> Regards, >>> Jonas >>> >>>>> --- >>>>> arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi | 12 ++++++++++ >>>>> arch/arm/dts/rk3399-rock-4c-plus.dts | 1 + >>>>> arch/arm/dts/rk3399-rock-4se-u-boot.dtsi | 12 ++++++++++ >>>>> arch/arm/dts/rk3399-rock-pi-4.dtsi | 4 +++- >>>>> arch/arm/dts/rk3399-rock-pi-4c-u-boot.dtsi | 7 ++++++ >>>>> arch/arm/dts/rk3399-rock-pi-4c.dts | 10 ++++++++ >>>>> configs/rock-4c-plus-rk3399_defconfig | 24 >>>>> +++++++++++++++----- >>>>> configs/rock-4se-rk3399_defconfig | 23 >>>>> +++++++++++++++++-- >>>>> configs/rock-pi-4-rk3399_defconfig | 8 +++++++ >>>>> configs/rock-pi-4c-rk3399_defconfig | 24 >>>>> ++++++++++++++++++-- >>>>> 10 files changed, 114 insertions(+), 11 deletions(-) >>>>> >>> [snip]