From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bosch Date: Tue, 07 Jan 2020 22:43:41 +0100 Subject: [PATCH v1 0/1] arm: Add support for SoC S5P4418 In-Reply-To: <20200106210720.GM4866@bill-the-cat> References: <20200106210720.GM4866@bill-the-cat> Message-ID: <80a2d0977057b86e5ea1020d2e804258@posteo.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, thanks a lot for your quick reply. On 06.01.2020 22:07, Tom Rini wrote: > On Mon, Jan 06, 2020 at 09:58:47PM +0100, Stefan Bosch wrote: >> This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418 SoC, >> especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on >> https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. For >> v2016.01 I >> have also made a working SPL (FriendlyARM U-Boot is using a closed >> source >> 2nd-bootloader). My plan is to migrate this also to the current >> U-Boot. >> >> Issues: >> Please send me a value for "#define MACH_TYPE_S5P4418" for >> arch/arm/include/asm/mach-types.h. > > Do you really need to support non-DT kernels? > I have adopted this from the original Code. What is the alternative? Could you please give me more details (e.g. an example-board). >> The size of the patch is over 700kB, so I will upload it on >> http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise >> instructed. > > Ah, I would suggest splitting things up into smaller logical chunks (a > patch per driver, separate SoC from board, etc) so they're all able to > make it to patchwork, thanks! Ok, I will try to split the patch into chunks <= 100kB without loosing the logic ;-) Regards, Stefan