[PATCH v1 0/1] arm: Add support for SoC S5P4418

[PATCH v1 0/1] arm: Add support for SoC S5P4418

[Stefan Bosch]

This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418 SoC, 
especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on 
https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. For 
v2016.01 I have also made a working SPL (FriendlyARM U-Boot is using a 
closed source 2nd-bootloader). My plan is to migrate this also to the 
current U-Boot.

Issues:
Please send me a value for "#define MACH_TYPE_S5P4418" for 
arch/arm/include/asm/mach-types.h.
The size of the patch is over 700kB, so I will upload it on 
http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise 
instructed.

[PATCH v1 0/1] arm: Add support for SoC S5P4418

[Tom Rini]

On Mon, Jan 06, 2020 at 09:58:47PM +0100, Stefan Bosch wrote:
> This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418 SoC,
> especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on
> https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. For v2016.01 I
> have also made a working SPL (FriendlyARM U-Boot is using a closed source
> 2nd-bootloader). My plan is to migrate this also to the current U-Boot.
> 
> Issues:
> Please send me a value for "#define MACH_TYPE_S5P4418" for
> arch/arm/include/asm/mach-types.h.

Do you really need to support non-DT kernels?

> The size of the patch is over 700kB, so I will upload it on
> http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise
> instructed.

Ah, I would suggest splitting things up into smaller logical chunks (a
patch per driver, separate SoC from board, etc) so they're all able to
make it to patchwork, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200106/551421fc/attachment.sig>

[PATCH v1 0/1] arm: Add support for SoC S5P4418

[Stefan Bosch]

Hi Tom,

thanks a lot for your quick reply.

On 06.01.2020 22:07, Tom Rini wrote:
> On Mon, Jan 06, 2020 at 09:58:47PM +0100, Stefan Bosch wrote:
>> This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418 SoC,
>> especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on
>> https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. For 
>> v2016.01 I
>> have also made a working SPL (FriendlyARM U-Boot is using a closed 
>> source
>> 2nd-bootloader). My plan is to migrate this also to the current 
>> U-Boot.
>> 
>> Issues:
>> Please send me a value for "#define MACH_TYPE_S5P4418" for
>> arch/arm/include/asm/mach-types.h.
> 
> Do you really need to support non-DT kernels?
> 
I have adopted this from the original Code. What is the alternative?
Could you please give me more details (e.g. an example-board).

>> The size of the patch is over 700kB, so I will upload it on
>> http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise
>> instructed.
> 
> Ah, I would suggest splitting things up into smaller logical chunks (a
> patch per driver, separate SoC from board, etc) so they're all able to
> make it to patchwork, thanks!

Ok, I will try to split the patch into chunks <= 100kB without loosing 
the logic ;-)


Regards,
Stefan

[PATCH v1 0/1] arm: Add support for SoC S5P4418

[Lukasz Majewski]

Hi Stefan,

> This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418
> SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is
> based on https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01.
> For v2016.01 I have also made a working SPL (FriendlyARM U-Boot is
> using a closed source 2nd-bootloader). My plan is to migrate this
> also to the current U-Boot.

Is this somewhat related to Nexell's S5P6818 soc?

There were some patches [1] posted for U-Boot.

For the closed source 2nd bootloader - there are some alternatives on
the Internet with a source code [2], [3].

> 
> Issues:
> Please send me a value for "#define MACH_TYPE_S5P4418" for 
> arch/arm/include/asm/mach-types.h.

I think that non-dt device is a no go nowadays... (as we do strive to
switch to DTS as much as possible in U-Boot now).

> The size of the patch is over 700kB, so I will upload it on 
> http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise 
> instructed.
> 


Links:

[1] -
https:https://github.com/metro94/s5p6818_bootloader//patchwork.ozlabs.org/cover/842828/
[2] - https://github.com/metro94/s5p6818_bootloader
[3] - https://github.com/NexellCorp/bl1_s5p4418

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200107/96d28e2f/attachment.sig>

[PATCH v1 0/1] arm: Add support for SoC S5P4418

[Stefan Bosch]

Hi Lukasz,

On 07.01.2020 11:57, Lukasz Majewski wrote:
> Hi Stefan,
> 
>> This patch adds support for SAMSUNG's ARM Cortex-A9 based S5P4418
>> SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is
>> based on https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01.
>> For v2016.01 I have also made a working SPL (FriendlyARM U-Boot is
>> using a closed source 2nd-bootloader). My plan is to migrate this
>> also to the current U-Boot.
> 
> Is this somewhat related to Nexell's S5P6818 soc?
> 
> There were some patches [1] posted for U-Boot.
> 
Yes, I think the S5P6818 is a follow-up of the S5P4418. Is it planed to
include those patches into U-Boot master? Or is there a branch where 
those
patches are already included so I can have a look at it and to be able 
to
use those patches where possible?

> For the closed source 2nd bootloader - there are some alternatives on
> the Internet with a source code [2], [3].
> 
Thanks a lot for the links. I did some research on this subject but I 
have not
found any source code for the S5P4418 2ndBootloader. Unfortunately, the
S5P6818 2ndBootloader is not of much use because the initialization of 
the
DDR-Ram Controller is different. So I will have a lock at  [3].

>> 
>> Issues:
>> Please send me a value for "#define MACH_TYPE_S5P4418" for
>> arch/arm/include/asm/mach-types.h.
> 
> I think that non-dt device is a no go nowadays... (as we do strive to
> switch to DTS as much as possible in U-Boot now).
> 
See my reply to Tom Rini.

>> The size of the patch is over 700kB, so I will upload it on
>> http://www.denx.de/wiki/attach/U-Boot/TooBigPatches if not otherwise
>> instructed.
>> 
> 
> 
> Links:
> 
> [1] -
> https:https://github.com/metro94/s5p6818_bootloader//patchwork.ozlabs.org/cover/842828/
> [2] - https://github.com/metro94/s5p6818_bootloader
> [3] - https://github.com/NexellCorp/bl1_s5p4418
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: 
> lukma at denx.de

Regards,
Stefan Bosch