From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan =?ISO-8859-1?Q?Br=FCns?= Date: Wed, 13 Dec 2017 03:01:11 +0100 Subject: [U-Boot] [linux-sunxi] Re: [PATCH 12/16] configs: sun50i: enable ums on bananapi-m64 In-Reply-To: <8654871.lRVQAXlMUb@ice-x220i> References: <1513061911-30076-1-git-send-email-jagan@amarulasolutions.com> <20171212081213.tzz76ujoavxys35v@flea.lan> <8654871.lRVQAXlMUb@ice-x220i> Message-ID: <8149014.RJeykUPXEC@pebbles> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Wednesday, December 13, 2017 2:36:26 AM CET Icenowy Zheng wrote: > 在 2017年12月12日星期二 CST 下午4:12:13，Maxime Ripard 写道： > > > Hi, > > > > On Tue, Dec 12, 2017 at 12:28:27PM +0530, Jagan Teki wrote: > > > This patch enable ums through CMD_USB_MASS_STORAGE. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > > > > configs/bananapi_m64_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/configs/bananapi_m64_defconfig > > > b/configs/bananapi_m64_defconfig index 55feafe..d4aade5 100644 > > > --- a/configs/bananapi_m64_defconfig > > > +++ b/configs/bananapi_m64_defconfig > > > @@ -11,6 +11,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64" > > > > > > CONFIG_SPL=y > > > # CONFIG_CMD_FLASH is not set > > > # CONFIG_CMD_FPGA is not set > > > > > > +CONFIG_CMD_USB_MASS_STORAGE=y > > > > How does that work with the current over-size issue we have on the > > A64? > > > > And I'd also like to keep the way we did things for several years now, > > which is to *not* have board-specific options selected besides the > > hardware-related ones. > > > > If you want to enable a general feature, do it for all the boards so > > that our users will have a consistent experience across boards, and we > > will not have to always chase all the defconfigs to provide it. > > I think there's a problem on A64 -- the Pine series are all designed to be > host-only, and it's the most popular A64 board series. No, it just means the *initial* role of the Pine will be Host, but the roles can be swapped using HNP (Host Negotiation Protocol) afterwards, which is pure software. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: This is a digitally signed message part. URL: