public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ron Madrid <ron_madrid@sbcglobal.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions
Date: Wed, 18 Feb 2009 12:02:02 -0800 (PST)	[thread overview]
Message-ID: <82808.89665.qm@web83505.mail.sp1.yahoo.com> (raw)
In-Reply-To: <20090218140159.e4880db0.kim.phillips@freescale.com>

--- On Wed, 2/18/09, Kim Phillips <kim.phillips@freescale.com> wrote:
> diff --git a/include/configs/SIMPC8313.h
> b/include/configs/SIMPC8313.h
> index f62a705..6219722 100644
> --- a/include/configs/SIMPC8313.h
> +++ b/include/configs/SIMPC8313.h
> @@ -205,6 +205,7 @@
>  #define CONFIG_SYS_NS16550
>  #define CONFIG_SYS_NS16550_SERIAL
>  #define CONFIG_SYS_NS16550_REG_SIZE	1
> +#define CONFIG_SYS_NS16550_MIN_FUNCTIONS

If you case the CONFIG_SYS_NS16550_MIN_FUNCTIONS within a #ifdef
CONFIG_NAND_SPL you don't need the following definitions.

> +#ifndef CONFIG_SYS_NS16550_MIN_FUNCTIONS
>  char	NS16550_getc   (NS16550_t com_port);
>  int	NS16550_tstc   (NS16550_t com_port);
>  void	NS16550_reinit (NS16550_t com_port, int
> baud_divisor);
> +#else
> +#define NS16550_getc(com_port) 0
> +#define NS16550_tstc(com_port) 0
> +#define NS16550_reinit(com_port, baud_divisor)
> +#endif

I was going to send a patch after this one was accepted that takes care of
the SIMPC8313 build.  Should I have sent the two of them together?  I
thought that they would be considered too different.  It would be this
below.

diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h
index a616236..59e43be 100644
--- a/include/configs/SIMPC8313.h
+++ b/include/configs/SIMPC8313.h
@@ -212,6 +212,10 @@
 #define CONFIG_SYS_NS16550_COM1		(CONFIG_SYS_IMMR+0x4500)
 #define CONFIG_SYS_NS16550_COM2		(CONFIG_SYS_IMMR+0x4600)
 
+#ifdef CONFIG_NAND_SPL
+#define CONFIG_NS16550_MIN_FUNCTIONS
+#endif
+
 /* Use the HUSH parser */
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2	"> "

If you'd like, I can send this one now or you could put the new config
option inside of a #ifdef CONFIG_NAND_SPL.

Ron

  parent reply	other threads:[~2009-02-18 20:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 20:14 [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions Ron Madrid
2009-02-18 18:21 ` Kim Phillips
2009-02-18 18:12   ` Scott Wood
2009-02-18 18:29   ` Wolfgang Denk
2009-02-18 20:01     ` Kim Phillips
2009-02-18 19:54       ` Scott Wood
2009-02-18 20:02       ` Ron Madrid [this message]
2009-02-18 20:45         ` Kim Phillips
2009-02-18 22:11         ` Wolfgang Denk
2009-02-18 23:23           ` Kim Phillips
2009-02-18 23:36             ` Wolfgang Denk
2009-02-18 18:30   ` Kim Phillips
2009-02-18 19:02     ` Ron Madrid
2009-02-18 21:58       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82808.89665.qm@web83505.mail.sp1.yahoo.com \
    --to=ron_madrid@sbcglobal.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox