public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: Nikhil M Jain <n-jain1@ti.com>, <u-boot@lists.denx.de>
Cc: <trini@konsulko.com>, <vigneshr@ti.com>, <nsekhar@ti.com>,
	<sjg@chromium.org>
Subject: Re: [PATCH 6/8] drivers: video: Kconfig: Add config remove video
Date: Fri, 12 May 2023 17:12:38 +0530	[thread overview]
Message-ID: <83baec46-e3dc-e36a-1939-c3db7316d98f@ti.com> (raw)
In-Reply-To: <20230511095958.189477-7-n-jain1@ti.com>

Hi Nikhil,

Thanks for the patch.

Subject: Add Kconfig for calling video remove method

On 11/05/23 15:29, Nikhil M Jain wrote:
> Add VIDEO_REMOVE configs to allow user to control removing of video
> driver, in between stages.

This is required since user may want to either call the remove method
of video driver and reset the display or not call the remove method
to continue displaying until next stage.

> 
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
> ---
>  drivers/video/Kconfig | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index fcc0e85d2e..c5863f4dd5 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -840,6 +840,12 @@ config IHS_VIDEO_OUT
>  	  out On-screen Display (OSD) used on gdsys FPGAs to control dynamic
>  	  textual overlays of the display outputs.
>  
> +config VIDEO_REMOVE
> +	bool "Remove video driver"
> +	help
> +		Use this option to specify if you want to remove video driver before
> +		loading OS.

to call remove method of video driver in u-boot proper stage

> +
>  config SPLASH_SCREEN
>  	bool "Show a splash-screen image"
>  	help
> @@ -1063,6 +1069,12 @@ config SPL_SYS_WHITE_ON_BLACK
>  	 This can be better in low-light situations or to reduce eye strain in
>  	 some cases.
>  
> +config SPL_VIDEO_REMOVE
> +	bool "Remove video driver after SPL stage"
> +	help
> +	 if this  option is enabled video driver will be removed at the end of
> +	 SPL stage, beforeloading the next stage.
> +

to call remove method of video driver in u-boot SPL stage
With suggested changes,
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh

>  if SPL_SPLASH_SCREEN
>  
>  config SPL_SPLASH_SCREEN_ALIGN

  reply	other threads:[~2023-05-12 11:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11  9:59 [PATCH 0/8] Updats SPL splashscreen framework for AM62x Nikhil M Jain
2023-05-11  9:59 ` [PATCH 1/8] common: spl: spl: Update stack pointer address Nikhil M Jain
2023-05-12  8:09   ` Devarsh Thakkar
2023-06-02 15:50     ` Tom Rini
2023-06-08 11:56     ` Nikhil M Jain
2023-05-11  9:59 ` [PATCH 2/8] arch: arm: mach-k3: common: Return a pointer after setting page table Nikhil M Jain
2023-05-12  8:51   ` Devarsh Thakkar
2023-05-11  9:59 ` [PATCH 3/8] board: ti: am62x: evm: Update function calls for splash screen Nikhil M Jain
2023-05-12 10:57   ` Devarsh Thakkar
2023-05-11  9:59 ` [PATCH 4/8] include: video: Reserve video using blob Nikhil M Jain
2023-05-12 11:11   ` Devarsh Thakkar
2023-05-11  9:59 ` [PATCH 5/8] common: board_f: Pass frame buffer info from SPL to u-boot Nikhil M Jain
2023-05-12 11:29   ` Devarsh Thakkar
2023-05-11  9:59 ` [PATCH 6/8] drivers: video: Kconfig: Add config remove video Nikhil M Jain
2023-05-12 11:42   ` Devarsh Thakkar [this message]
2023-05-11  9:59 ` [PATCH 7/8] common: spl: spl: Remove video driver Nikhil M Jain
2023-05-12 11:42   ` Devarsh Thakkar
2023-05-11  9:59 ` [PATCH 8/8] configs: am62x_evm_a53: Add bloblist address Nikhil M Jain
2023-05-12 11:46   ` Devarsh Thakkar
2023-05-11 13:09 ` [PATCH 0/8] Updats SPL splashscreen framework for AM62x Tom Rini
2023-05-12  6:01 ` Devarsh Thakkar
2023-06-01 16:40 ` Tom Rini
2023-06-02  4:39   ` [EXTERNAL] " Nikhil M Jain
2023-06-02  6:19     ` Nikhil M Jain
2023-06-02 15:51       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83baec46-e3dc-e36a-1939-c3db7316d98f@ti.com \
    --to=devarsht@ti.com \
    --cc=n-jain1@ti.com \
    --cc=nsekhar@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox