From: Wolfgang Denk <wd@denx.de>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Roland Gaudig <roland.gaudig-oss@weidmueller.com>,
u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Roland Gaudig <roland.gaudig@weidmueller.com>
Subject: Re: [PATCH 1/3] cmd: setexpr: add fmt format string operation
Date: Tue, 29 Jun 2021 10:44:45 +0200 [thread overview]
Message-ID: <84286.1624956285@gemini.denx.de> (raw)
In-Reply-To: <4c69688f-c187-ad14-5cfe-cdcddc71f5c8@prevas.dk>
Dear Rasmus,
In message <4c69688f-c187-ad14-5cfe-cdcddc71f5c8@prevas.dk> you wrote:
>
> I think this allows a lone % to appear at the end of the string after
> the actual %d, i.e. it seems "%d bla %" would be accepted.
there are a lot of highly unintuitive restrictions in that code,
indeed.
> I think allowing "arbitrary" format strings, restricted to those
> expected exactly one integer argument, is too fragile and error-prone.
Indeed. See for example the "printf" (bash) shell builtin - we
should have a similar flexibility here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Humanity has the stars in its future, and that future is too
important to be lost under the burden of juvenile folly and ignorant
superstition. - Isaac Asimov
next prev parent reply other threads:[~2021-06-29 8:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:17 [PATCH 0/3] cmd: setexpr: add fmt format string operation Roland Gaudig
2021-06-28 15:17 ` [PATCH 1/3] " Roland Gaudig
2021-06-28 17:39 ` Rasmus Villemoes
2021-06-29 8:44 ` Wolfgang Denk [this message]
2021-06-29 8:41 ` Wolfgang Denk
2021-06-28 15:17 ` [PATCH 2/3] doc: usage: add description for setexpr command Roland Gaudig
2021-07-05 15:29 ` Simon Glass
2021-06-28 15:17 ` [PATCH 3/3] test: cmd: setexpr: add tests for format string operations Roland Gaudig
2021-07-05 15:29 ` Simon Glass
2021-06-29 8:37 ` [PATCH 0/3] cmd: setexpr: add fmt format string operation Wolfgang Denk
2021-06-29 9:41 ` Roland Gaudig (OSS)
2021-06-29 10:34 ` Marek Behun
2021-06-29 10:40 ` Wolfgang Denk
2021-06-30 8:30 ` Roland Gaudig (OSS)
2021-06-29 13:57 ` Sean Anderson
2021-06-29 15:13 ` Wolfgang Denk
2021-06-30 16:17 ` Sean Anderson
2021-06-30 17:11 ` Marek Behún
2021-07-02 10:50 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84286.1624956285@gemini.denx.de \
--to=wd@denx.de \
--cc=rasmus.villemoes@prevas.dk \
--cc=roland.gaudig-oss@weidmueller.com \
--cc=roland.gaudig@weidmueller.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox