From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Date: Wed, 1 Feb 2017 14:01:11 +0200 Subject: [U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address In-Reply-To: References: <1485789316-22216-1-git-send-email-rogerq@ti.com> <1485789316-22216-7-git-send-email-rogerq@ti.com> <46904e6c-9099-4cce-b6cc-fa457bbd4b43@ti.com> <4b608991-cc94-be87-a25d-cf3db8b999f1@ti.com> Message-ID: <8429311a-dfd2-e256-8dfd-17a840f169a4@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/02/17 12:47, Lokesh Vutla wrote: > > > On Wednesday 01 February 2017 03:12 PM, Roger Quadros wrote: >> On 31/01/17 06:17, Lokesh Vutla wrote: >>> >>> >>> On Monday 30 January 2017 08:45 PM, Roger Quadros wrote: >>>> In stead of defining the board EEPROM address in the board headers >>>> let's define them in the board config files and make them >>>> configurable by Kconfig. >>>> >>>> Signed-off-by: Roger Quadros >>>> --- >>>> arch/arm/Kconfig | 10 ++++++++++ >>>> configs/am57xx_evm_defconfig | 2 ++ >>>> configs/am57xx_evm_nodt_defconfig | 2 ++ >>>> configs/am57xx_hs_evm_defconfig | 2 ++ >>>> configs/dra7xx_evm_defconfig | 2 ++ >>>> configs/dra7xx_hs_evm_defconfig | 2 ++ >>>> include/configs/am57xx_evm.h | 4 ---- >>>> include/configs/dra7xx_evm.h | 4 ---- >>>> 8 files changed, 20 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>>> index c04adfb..19886ad 100644 >>>> --- a/arch/arm/Kconfig >>>> +++ b/arch/arm/Kconfig >>>> @@ -1009,6 +1009,16 @@ config TARGET_THUNDERX_88XX >>>> >>>> endchoice >>>> >>>> +config EEPROM_BUS_ADDRESS >>>> + int "Board EEPROM's I2C bus address" >>>> + range 0 8 >>>> + default 0 >>>> + >>>> +config EEPROM_CHIP_ADDRESS >>>> + hex "Board EEPROM's I2C chip address" >>>> + range 0 0xff >>>> + default 0x50 >>>> + >>> >>> IMO, these should be placed in board/ti/common/Kconfig. Also need not >>> specify the value explicitly in defconfig if default value is used. >> >> "board/ti/common/Kconfig" is not used by keystone >> Is it OK to source it in board/ti/ks2_evm/Kconfig? > > yes. I don't see any problem with that :) > If I do that I get the below error. I think it is because SPL_NAND is being enabled but not required for K2? Are all options in ti/common/Kconfig relevant for K2? CC spl/common/spl/spl_nand.o common/spl/spl_nand.c: In function 'spl_nand_load_image': common/spl/spl_nand.c:139:41: error: 'CONFIG_SYS_NAND_U_BOOT_OFFS' undeclared (first use in this function) err = spl_nand_load_element(spl_image, CONFIG_SYS_NAND_U_BOOT_OFFS, ^ common/spl/spl_nand.c:139:41: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:280: recipe for target 'spl/common/spl/spl_nand.o' failed make[2]: *** [spl/common/spl/spl_nand.o] Error 1 scripts/Makefile.spl:296: recipe for target 'spl/common/spl' failed make[1]: *** [spl/common/spl] Error 2 Makefile:1330: recipe for target 'spl/u-boot-spl' failed make: *** [spl/u-boot-spl] Error 2 -- cheers, -roger