From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Tom Rini <trini@konsulko.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome.forissier@linaro.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Marek Vasut <marex@denx.de>, Michal Simek <michal.simek@amd.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
Rasmus Villemoes <ravi@prevas.dk>, Simon Glass <sjg@chromium.org>,
Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Subject: RE: [PATCH V3 2/3] test: cmd: nvedit: Add basic unit tests
Date: Fri, 6 Jun 2025 21:40:28 +0000 [thread overview]
Message-ID: <84931c2fbfe6497ebff69e54f92bcd06@dh-electronics.com> (raw)
In-Reply-To: <20250603201249.GA1510455@bill-the-cat>
From: Tom Rini <trini@konsulko.com>
Sent: Tuesday, June 3, 2025 10:13 PM
> On Fri, May 09, 2025 at 09:00:42PM +0200, Christoph Niedermaier wrote:
>
>> Add basic unit tests for argument checking of the env command.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> [snip]
>> + /* Binary format with checksum and with wrong size */
>> + ut_asserteq(1, run_commandf("env import -c ${loadaddr} %x", offsetof(env_t, data)));
>
> This will be "unsigned long int" on 64bit or "unsigned int" on 32bit,
> and so we can't use %x here.
I will have a look at it and make a new version. I may not get round to
it straight away.
Thanks and regards
Christoph
next prev parent reply other threads:[~2025-06-06 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 19:00 [PATCH V3 0/3] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-05-09 19:00 ` [PATCH V3 1/3] cmd: nvedit: Convert the parsing of arguments to getopt() Christoph Niedermaier
2025-05-09 19:00 ` [PATCH V3 2/3] test: cmd: nvedit: Add basic unit tests Christoph Niedermaier
2025-06-03 20:12 ` Tom Rini
2025-06-06 21:40 ` Christoph Niedermaier [this message]
2025-05-09 19:00 ` [PATCH V3 3/3] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-05-12 7:37 ` [PATCH V3 0/3] " Andy Shevchenko
2025-05-12 8:22 ` Christoph Niedermaier
2025-05-12 8:38 ` Andy Shevchenko
2025-05-12 15:15 ` Christoph Niedermaier
2025-05-12 18:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84931c2fbfe6497ebff69e54f92bcd06@dh-electronics.com \
--to=cniedermaier@dh-electronics.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ansuelsmth@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=patrick.delaunay@foss.st.com \
--cc=ravi@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox