public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Johan Jonker <jbx6244@gmail.com>,
	dario.binacchi@amarulasolutions.com,
	michael@amarulasolutions.com, sjg@chromium.org
Cc: philipp.tomsich@vrull.eu, u-boot@lists.denx.de,
	yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v2 05/10] rockchip: timer: dw-apb-timer: convert dev_read_addr output to phys_addr_t
Date: Thu, 16 Feb 2023 15:42:16 +0800	[thread overview]
Message-ID: <84bbfbf6-276b-0feb-fa02-ec6baf082453@rock-chips.com> (raw)
In-Reply-To: <31504d5d-4884-e60c-85db-4ded476dd071@gmail.com>


On 2023/2/7 22:53, Johan Jonker wrote:
> The fdt_addr_t and phys_addr_t size have been decoupled.
> A 32bit CPU can expect 64-bit data from the device tree parser,
> so convert dev_read_addr output to phys_addr_t in the
> dw-apb-timer.c file.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/timer/dw-apb-timer.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/timer/dw-apb-timer.c b/drivers/timer/dw-apb-timer.c
> index 10f0a9f6..f55a3c54 100644
> --- a/drivers/timer/dw-apb-timer.c
> +++ b/drivers/timer/dw-apb-timer.c
> @@ -23,7 +23,7 @@
>   #define DW_APB_CTRL		0x8
>
>   struct dw_apb_timer_priv {
> -	fdt_addr_t regs;
> +	phys_addr_t regs;
>   	struct reset_ctl_bulk resets;
>   };
>
> @@ -92,7 +92,7 @@ static int dw_apb_timer_of_to_plat(struct udevice *dev)
>   	if (CONFIG_IS_ENABLED(OF_REAL)) {
>   		struct dw_apb_timer_priv *priv = dev_get_priv(dev);
>
> -		priv->regs = dev_read_addr(dev);
> +		priv->regs = (phys_addr_t)dev_read_addr(dev);
>   	}
>
>   	return 0;
> --
> 2.20.1
>

  reply	other threads:[~2023-02-16  7:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 14:49 [PATCH v2 00/10] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-02-07 14:51 ` [PATCH v2 01/10] include: fdtdec: decouple fdt_addr_t and phys_addr_t size Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:52 ` [PATCH v2 02/10] include: dm: ofnode: fix headers Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:52 ` [PATCH v2 03/10] core: remap: convert regmap_init_mem_plat() input to phys_addr_t Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:53 ` [PATCH v2 04/10] rockchip: adc: rockchip-saradc: convert dev_read_addr output " Johan Jonker
2023-02-16  7:42   ` Kever Yang
2023-02-07 14:53 ` [PATCH v2 05/10] rockchip: timer: dw-apb-timer: " Johan Jonker
2023-02-16  7:42   ` Kever Yang [this message]
2023-02-07 14:54 ` [PATCH v2 06/10] rockchip: mtd: raw: rockchip_nfc " Johan Jonker
2023-02-16  7:34   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:54 ` [PATCH v2 07/10] mtd: nand: raw: rockchip_nfc: remove the compatible string "rockchip,rk3308-nfc" Johan Jonker
2023-02-16  7:29   ` Michael Nazzareno Trimarchi
2023-02-16  7:42   ` Kever Yang
2023-02-07 14:54 ` [PATCH v2 08/10] mtd: nand: raw: rockchip_nfc: add layout structure Johan Jonker
2023-02-16  7:26   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:55 ` [PATCH v2 09/10] mtd: nand: raw: rockchip_nfc: add flash_node to chip stucture Johan Jonker
2023-02-16  7:24   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:56 ` [PATCH v2 10/10] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-02-16  7:43   ` Kever Yang
2023-02-13 14:18 ` [PATCH v1] mtd: nand: raw: rockchip_nfc: fix oobfree offset and description Johan Jonker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84bbfbf6-276b-0feb-fa02-ec6baf082453@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=jbx6244@gmail.com \
    --cc=michael@amarulasolutions.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=yifeng.zhao@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox