From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Mon, 20 Aug 2012 15:12:14 +0200 (CEST)
Subject: [U-Boot] [PATCH 6/7] mx35: Fix eSDHC clocks
In-Reply-To: <503233AF.70203@denx.de>
Message-ID: <856463492.2593905.1345468334404.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

> > 
> > OK, then this patch does the job for the single eSDHC instance use
> > case, which
> > will still use gd->sdhc_clk.
> 
> Yes, but then we do not need ESDHC1, ESDHC2 and ESDHC3, because the
> driver does not support different clocks.

We need them: Yes, the driver supports a single eSDHC instance and a single
clock with gd->sdhc_clk and fsl_esdhc_mmc_init(), but there is a choice to
determine at compile time depending on CONFIG_SYS_FSL_ESDHC_ADDR. You don't want
to use the clock of eSDHC1 if CONFIG_SYS_FSL_ESDHC_ADDR selects eSDHC2. This is
use case exists on i.MX with cpu_mmc_init() if a single eSDHC instance is
needed.

> > I will make another patch before or after this one
> > for the multi-instance use case.
> 
> Fine.

OK.

> > I will do the same in the v2 of my mx5 clock
> > series (for gd->sdhc_clk). I think I also have the same stuff for
> > mx25.
> 
> Ok - I read the series for MX5, but I need to check it with the
> manuals
> to understand the changes. I need some more time...

No problem.

Best regards,
Beno?t