Re: [Upstream] [PATCH v2 0/3] Add support for all variants of the phyCORE-i.MX93 SOM

[Christoph Stoidner <C.Stoidner@phytec.de>]

On Mi, 2024-11-13 at 20:47 +0100, Wadim Egorov wrote:
> 
> 
> Am 13.11.24 um 17:00 schrieb Christoph Stoidner:
> > The phyCORE-i.MX 93 is available in various variants (e.g.
> > different ram
> > sizes, eMMC HS400 yes/no). It's eeprom contains information which
> > features
> > the existing module supports.
> > 
> > Extend the existing board-code to support all the SOM variants. The
> > spl/u-boot
> > evaluates the eeprom information and enables supported features
> > accordingly.
> > The resulting spl and u-boot binary is able to boot each phyCORE-
> > i.MX 93 SOM
> > variant on each carrier board.
> > 
> > Changes in v2:
> > 
> > patch #1:
> > - remove multiple blank lines
> > - add update of 1GB ram timings to commit message
> > 
> > patch #2:
> > - encapsulate handling of feature flag VOLTAGE into own function
> > - move definition of enum phytec_imx93_ddr_eeprom_code into header
> > file
> > 
> > patch #3:
> > - just rename imx93-phyboard-segin_defconfig and add needed
> > CONFIGs,
> >    instead of creating an entirely new second defconfig
> 
> Don't forget to update the docs "Build U-Boot" chapter mentioning the
> new defconfig.

Good point, thanks! I will add that in the v3.

> 
> 
> > - remove wrong comment from imx93-phyboard-segin-u-boot.dtsi
> > - improve commit message
> > 
> > Christoph Stoidner (3):
> >    board: phytec: phycore-imx93: Add 2GB LPDDR4X RAM timings
> >    board: phytec: imx93: Add eeprom-based hardware introspection
> >    board: phytec: imx93: Add phyCORE-i.MX 93 support for all SOM
> > variants
> > 
> >   arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi |  25 +-
> >   arch/arm/mach-imx/imx9/Kconfig                |   2 +
> >   arch/arm/mach-imx/imx9/soc.c                  |   2 +-
> >   board/phytec/common/Kconfig                   |   8 +
> >   board/phytec/common/Makefile                  |   1 +
> >   board/phytec/common/imx93_som_detection.c     | 111 +++
> >   board/phytec/common/imx93_som_detection.h     |  51 ++
> >   board/phytec/phycore_imx93/Kconfig            |  28 +
> >   board/phytec/phycore_imx93/MAINTAINERS        |   7 +-
> >   board/phytec/phycore_imx93/lpddr4_timing.c    | 793
> > ++++++++++++++++--
> >   board/phytec/phycore_imx93/phycore-imx93.c    |  51 ++
> >   board/phytec/phycore_imx93/spl.c              |  48 ++
> >   ...egin_defconfig => imx93-phycore_defconfig} |   4 +-
> >   13 files changed, 1064 insertions(+), 67 deletions(-)
> >   create mode 100644 board/phytec/common/imx93_som_detection.c
> >   create mode 100644 board/phytec/common/imx93_som_detection.h
> >   rename configs/{imx93-phyboard-segin_defconfig => imx93-
> > phycore_defconfig} (98%)
> > 
>