From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 217CBC77B60 for ; Mon, 3 Apr 2023 11:41:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D65C685BB7; Mon, 3 Apr 2023 13:41:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="D7dvmW08"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2BFD85BB7; Mon, 3 Apr 2023 13:41:36 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0485B8576A for ; Mon, 3 Apr 2023 13:41:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devarsht@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 333BfRMw025051; Mon, 3 Apr 2023 06:41:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680522087; bh=FQvyqE5fYxuSUWYGA7fecUqrsCkcSiTQbys2fNaxTQE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=D7dvmW08uZu8X5qNKB+Gw+j93tNr/z0eWruX9JrU8/xXCD3PWZlAs9/H+weONAyfB l38nyh/pxpxCR2gSq3S68HEtx5dlo+o69sjas3Y/ZmazGzGnUL9ZRSxnY39kjAfW/5 SjYYTUEdpPDAguUC889dlYzMHRKSTuqVEKU78vVE= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 333BfRL4063182 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Apr 2023 06:41:27 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 3 Apr 2023 06:41:27 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 3 Apr 2023 06:41:27 -0500 Received: from [172.24.145.199] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 333BfPRA112756; Mon, 3 Apr 2023 06:41:25 -0500 Message-ID: <85b3b74a-de19-ee78-301c-e2a42ccb2910@ti.com> Date: Mon, 3 Apr 2023 17:11:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH V5 12/13] include: Enable video related global data variable and splash at SPL Content-Language: en-US To: Nikhil M Jain , , CC: , , References: <20230403081443.77933-1-n-jain1@ti.com> <20230403081443.77933-13-n-jain1@ti.com> From: Devarsh Thakkar In-Reply-To: <20230403081443.77933-13-n-jain1@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On 03/04/23 13:44, Nikhil M Jain wrote: > To include video related global data variables and splash functions at > SPL, use CONFIG_IS_ENABLED. s/at SPL/at both SPL and u-boot proper > > Replace CONFIG_CMD_BMP with CONFIG_BMP to enable splash_display function > at u-boot proper and SPL. > > Signed-off-by: Nikhil M Jain After above change, Reviewed-by: Devarsh Thakkar Regards Devarsh > --- > V5: > - Replace CONFIG_CMD_BMP with CONFIG_BMP. > > V4: > - No change. > > V3 (patch introduced): > - Include video related global data variables. > - Include splash display functions. > > include/asm-generic/global_data.h | 4 ++-- > include/splash.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h > index 987fb66c17..65bf8df1e5 100644 > --- a/include/asm-generic/global_data.h > +++ b/include/asm-generic/global_data.h > @@ -68,7 +68,7 @@ struct global_data { > * @mem_clk: memory clock rate in Hz > */ > unsigned long mem_clk; > -#if defined(CONFIG_VIDEO) > +#if CONFIG_IS_ENABLED(VIDEO) > /** > * @fb_base: base address of frame buffer memory > */ > @@ -359,7 +359,7 @@ struct global_data { > */ > struct membuff console_in; > #endif > -#ifdef CONFIG_VIDEO > +#if CONFIG_IS_ENABLED(VIDEO) > /** > * @video_top: top of video frame buffer area > */ > diff --git a/include/splash.h b/include/splash.h > index 33e45e6941..b6a100ffc3 100644 > --- a/include/splash.h > +++ b/include/splash.h > @@ -49,7 +49,7 @@ struct splash_location { > char *ubivol; /* UBI volume-name for ubifsmount */ > }; > > -#ifdef CONFIG_SPLASH_SOURCE > +#if CONFIG_IS_ENABLED(SPLASH_SOURCE) > int splash_source_load(struct splash_location *locations, uint size); > #else > static inline int splash_source_load(struct splash_location *locations, > @@ -61,13 +61,13 @@ static inline int splash_source_load(struct splash_location *locations, > > int splash_screen_prepare(void); > > -#ifdef CONFIG_SPLASH_SCREEN_ALIGN > +#if CONFIG_IS_ENABLED(SPLASH_SCREEN_ALIGN) > void splash_get_pos(int *x, int *y); > #else > static inline void splash_get_pos(int *x, int *y) { } > #endif > > -#if defined(CONFIG_SPLASH_SCREEN) && defined(CONFIG_CMD_BMP) > +#if CONFIG_IS_ENABLED(SPLASH_SCREEN) && CONFIG_IS_ENABLED(BMP) > int splash_display(void); > #else > static inline int splash_display(void)