From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Fri, 8 Jul 2011 15:53:17 +0530 (IST) Subject: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD In-Reply-To: <1773826644.46838.1310120108778.JavaMail.root@ahm.einfochips.com> Message-ID: <867041231.46865.1310120597114.JavaMail.root@ahm.einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, Thanks for info, I have seen that. But i am not adding support for GPIO commands. In reference to >> +#define GPLR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x00) >> +#define GPDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x0c) >> +#define GPSR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x18) >> +#define GPCR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x24) >> +#define GSDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x54) >> +#define GCDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x60) > Please use a C struct to dsescribe the register layout. I have followed similar way of using GPIO as used by "drivers/gpio/kw_gpio.c" and defined in "include/asm/arch-kirkwood/gpio.h", so actually i am not adding GPIO support rather i wrote functions that are required by the Ethernet and other drivers. Regards, Ajay Bhargav