From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 10 Feb 2021 17:10:16 +0100 Subject: [PATCH] efidebug: Introduce bootmgr command In-Reply-To: References: <20210210105425.356131-1-ilias.apalodimas@linaro.org> <75527.1612956227@gemini.denx.de> <79242.1612959975@gemini.denx.de> Message-ID: <86821.1612973416@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ilias, In message you wrote: > > > In this case, "debug" would just be a sub-command of the "efi" > > command, with more sub-commands under efi (like bootmgr or such) > > following, same as we did for example with "env" (where many > > commands maintain backward compatibility, but here this was > > necessary because these have been in use forever): > > > > env print -> printenv > > env save -> saveenv > > env set -> setenv > > > > Yes, but it would still look a bit strange, because the efidebug command was > overloaded in our case. So you could test capsules, set EFI bootmgr variables, > dump EFI tables amongst other things. The saveenv & friends had a tightly > defined scope already. > So that would require a lot of code to keep the convention running, but since > it's rarely used, I don't think it's worth the effort or the additional > complexity (once again unless someone has a valid reason), hence my suggestion > to define it properly while we still have time. Indeed - if it was rarely used before, it makes a lot of sense to break combined functionality into separate subcommands (probably also with separate Kconfig options so you can select what you really need only). Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The biggest difference between time and space is that you can't reuse time. - Merrick Furst