public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Humphreys <j-humphreys@ti.com>
To: Nishanth Menon <nm@ti.com>, Tom Rini <trini@konsulko.com>
Cc: Kamlesh Gurudasani <kamlesh@ti.com>,
	Sinthu Raja <sinthu.raja@ti.com>,
	Neha Malcom Francis <n-francis@ti.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Roger Quadros <rogerq@kernel.org>, Simon Glass <sjg@chromium.org>,
	Andrew Davis <afd@ti.com>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Nikhil M Jain <n-jain1@ti.com>,
	"Manorit Chawdhry" <m-chawdhry@ti.com>,
	Bryan Brattlof <bb@ti.com>,
	Robert Nelson <robertcnelson@gmail.com>, <u-boot@lists.denx.de>,
	Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH V2 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script
Date: Fri, 12 Jan 2024 15:13:46 -0600	[thread overview]
Message-ID: <86a5padzlh.fsf@udb0321960.dhcp.ti.com> (raw)
In-Reply-To: <20240109191506.3820908-3-nm@ti.com>

Nishanth Menon <nm@ti.com> writes:

> Stop using the findfdt script and switch to setting the fdtfile from
> C code.
>
> While at this, replace findfdt in environment with a warning as it is
> no longer needed
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes from V1: None.
> I have retained the central call ti_set_fdt_env() to retain the
> population of fdtfile name using the CONFIG fall back logic and the
> population of (now deprecated) legacy variables for downstream script
> users.
>
> V1: https://lore.kernel.org/r/20240108173301.2692332-3-nm@ti.com
>
>  board/ti/am62ax/am62ax.env       |  1 -
>  board/ti/am62ax/evm.c            | 10 ++++++++++
>  configs/am62ax_evm_a53_defconfig |  1 +
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env
> index a6d967e982d4..334374abb73e 100644
> --- a/board/ti/am62ax/am62ax.env
> +++ b/board/ti/am62ax/am62ax.env
> @@ -1,5 +1,4 @@
>  #include <env/ti/ti_common.env>
> -#include <env/ti/default_findfdt.env>
>  #include <env/ti/mmc.env>
>  
>  name_kern=Image
> diff --git a/board/ti/am62ax/evm.c b/board/ti/am62ax/evm.c
> index cd3360a43029..62d3664936e7 100644
> --- a/board/ti/am62ax/evm.c
> +++ b/board/ti/am62ax/evm.c
> @@ -13,6 +13,8 @@
>  #include <fdt_support.h>
>  #include <spl.h>
>  
> +#include "../common/fdt_ops.h"
> +
>  int board_init(void)
>  {
>  	return 0;
> @@ -27,3 +29,11 @@ int dram_init_banksize(void)
>  {
>  	return fdtdec_setup_memory_banksize();
>  }
> +
> +#ifdef CONFIG_BOARD_LATE_INIT
> +int board_late_init(void)
> +{
> +	ti_set_fdt_env(NULL, NULL);
> +	return 0;
> +}
> +#endif
> diff --git a/configs/am62ax_evm_a53_defconfig b/configs/am62ax_evm_a53_defconfig
> index 38083586a3ec..e5fcd8cc5b6f 100644
> --- a/configs/am62ax_evm_a53_defconfig
> +++ b/configs/am62ax_evm_a53_defconfig
> @@ -24,6 +24,7 @@ CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
>  CONFIG_BOOTSTD_FULL=y
>  CONFIG_BOOTSTD_DEFAULTS=y
>  CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
> +CONFIG_BOARD_LATE_INIT=y
>  CONFIG_SPL_MAX_SIZE=0x58000
>  CONFIG_SPL_PAD_TO=0x0
>  CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> -- 
> 2.43.0

Reviewed-by: Jonathan Humphreys <j-humphreys@ti.com>

  reply	other threads:[~2024-01-12 21:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 19:14 [PATCH V2 00/10] board/ti: k3 boards: Stop using findfdt Nishanth Menon
2024-01-09 19:14 ` [PATCH V2 01/10] board: ti: common: Introduce a common fdt ops library Nishanth Menon
2024-01-12 21:13   ` Jon Humphreys
2024-01-09 19:14 ` [PATCH V2 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script Nishanth Menon
2024-01-12 21:13   ` Jon Humphreys [this message]
2024-01-09 19:14 ` [PATCH V2 03/10] board: ti: am62x: " Nishanth Menon
2024-01-12 21:14   ` Jon Humphreys
2024-01-09 19:14 ` [PATCH V2 04/10] board: ti: am64x: " Nishanth Menon
2024-01-12 21:14   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 05/10] board: ti: am65x: " Nishanth Menon
2024-01-12 21:14   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 06/10] board: ti: j721e: " Nishanth Menon
2024-01-12 21:14   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 07/10] board: ti: j721s2: " Nishanth Menon
2024-01-12 21:15   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 08/10] board: beagle: beagleboneai64: " Nishanth Menon
2024-01-12 21:15   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 09/10] board: beagle: beagleplay: " Nishanth Menon
2024-01-12 21:15   ` Jon Humphreys
2024-01-09 19:15 ` [PATCH V2 10/10] include: env: ti: Drop default_findfdt Nishanth Menon
2024-01-10 17:31   ` Roger Quadros
2024-01-10 18:34     ` Nishanth Menon
2024-01-12 21:15   ` Jon Humphreys
2024-01-11 10:17 ` [PATCH V2 00/10] board/ti: k3 boards: Stop using findfdt Roger Quadros
2024-01-20 16:36 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5padzlh.fsf@udb0321960.dhcp.ti.com \
    --to=j-humphreys@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=kamlesh@ti.com \
    --cc=m-chawdhry@ti.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=n-francis@ti.com \
    --cc=n-jain1@ti.com \
    --cc=nm@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=rogerq@kernel.org \
    --cc=sinthu.raja@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox