From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69708C433EF for ; Fri, 3 Sep 2021 14:23:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7881D610A2 for ; Fri, 3 Sep 2021 14:23:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7881D610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 18B518348D; Fri, 3 Sep 2021 16:23:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=agner.ch header.i=@agner.ch header.b="eXNTQmSd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A2D5B834F6; Fri, 3 Sep 2021 16:23:05 +0200 (CEST) Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1FCF68330B for ; Fri, 3 Sep 2021 16:23:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan@agner.ch Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id A30145C037C; Fri, 3 Sep 2021 16:23:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1630678981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S0HE5VElL53deDnObkYMf7Y1NjWpaer2061CMZHtMcA=; b=eXNTQmSd8veo344fA9H71suh0+56e6162iUZ9DAu/09NOoocL0ZMl2AJVkxNqn2CnBI0CW 9CVvnjcrTwU1yMxdxc+E7JLHIqXVEbXJm1x250WFMyKRV8U5ObtWySIWjmJXMcgShy8Ari EaP71DwZj7uy6iix5G/N+4ZODzALUgA= MIME-Version: 1.0 Date: Fri, 03 Sep 2021 16:23:00 +0200 From: Stefan Agner To: Marek Szyprowski Cc: u-boot@lists.denx.de, Matthias Brugger , Sylwester Nawrocki , Nicolas Saenz Julienne , Jaehoon Chung , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] ARM: bcm283x: change the virtual address of the XHCI PCI device base In-Reply-To: <20210617092203.19825-1-m.szyprowski@samsung.com> References: <20210617092203.19825-1-m.szyprowski@samsung.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <86ccace661f55061a4e3562ee2120ed8@agner.ch> X-Sender: stefan@agner.ch Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021-06-17 11:22, Marek Szyprowski wrote: > Move the XHCI PCI device base up in the virtual address space. This fixes > initialization failure observed with newer Raspberry Pi firmware, later > than 63b1922311 ("firmware: arm_loader: Update armstubs with those from > PR 117). It looks that chosing 0xff800000 as the XHCI PCI device base > conflicts with the updated ARM/VideoCore firmware. > > This also requires to reduce the size of the mapped PCI device region > from 8MiB to 4MiB to fit into 32bit address space. This is still enough > for the XHCI PCI device. > > Signed-off-by: Marek Szyprowski > --- > This fixes the issue observed on ARM 32bit after upgrading the RPi4 > firmware files, described some time ago here: > https://lists.denx.de/pipermail/u-boot/2021-February/442317.html This also fixes an issue we are seeing in Home Assistant: https://github.com/home-assistant/operating-system/issues/1490 It does seem that it depends on the binary size (since USB enumeration worked with 2021.04 at one point, but after enabling more configurations it caused issues). So: Tested-by: Stefan Agner I've seen that this did not make it into master yet, which tree is this expected to get merged through? -- Stefan > --- > arch/arm/mach-bcm283x/init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-bcm283x/init.c b/arch/arm/mach-bcm283x/init.c > index 49027ce0a2..9803499985 100644 > --- a/arch/arm/mach-bcm283x/init.c > +++ b/arch/arm/mach-bcm283x/init.c > @@ -14,7 +14,7 @@ > #include > > #define BCM2711_RPI4_PCIE_XHCI_MMIO_PHYS 0x600000000UL > -#define BCM2711_RPI4_PCIE_XHCI_MMIO_SIZE 0x800000UL > +#define BCM2711_RPI4_PCIE_XHCI_MMIO_SIZE 0x400000UL > > #ifdef CONFIG_ARM64 > #include > @@ -148,7 +148,7 @@ int mach_cpu_init(void) > > #ifdef CONFIG_ARMV7_LPAE > #ifdef CONFIG_TARGET_RPI_4_32B > -#define BCM2711_RPI4_PCIE_XHCI_MMIO_VIRT 0xff800000UL > +#define BCM2711_RPI4_PCIE_XHCI_MMIO_VIRT 0xffc00000UL > #include > #include