From: Jon Humphreys <jhumphreysti@gmail.com>
To: Jerome Forissier <jerome.forissier@linaro.org>, <u-boot@lists.denx.de>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Javier Tia <javier.tia@linaro.org>,
Maxim Uvarov <muvarov@gmail.com>,
"Jerome Forissier" <jerome.forissier@linaro.org>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Michal Simek <michal.simek@amd.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH v4 10/14] net-lwip: add wget command
Date: Mon, 24 Jun 2024 01:25:19 -0500 [thread overview]
Message-ID: <86cyo6vovk.fsf@udb0321960.dhcp.ti.com> (raw)
In-Reply-To: <86frt2vp2k.fsf@udb0321960.dhcp.ti.com>
Subject: [PATCH] net-lwip: fixes off-by-one array access error with wget
When wget parses the url and extracts the host, it is off by one on the
index to terminate the character array.
Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
---
net-lwip/wget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net-lwip/wget.c b/net-lwip/wget.c
index 069299bd469..63b19b99112 100644
--- a/net-lwip/wget.c
+++ b/net-lwip/wget.c
@@ -51,7 +51,7 @@ static int parse_url(char *url, char *host, u16 *port, char **path)
return -EINVAL;
memcpy(host, p, pp - p);
- host[pp - p + 1] = '\0';
+ host[pp - p] = '\0';
if (*pp == ':') {
/* Parse port number */
--
2.34.1
next prev parent reply other threads:[~2024-06-24 12:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 15:32 [PATCH v4 00/14] Introduce the lwIP network stack Jerome Forissier
2024-06-17 15:32 ` [PATCH v4 01/14] flash: prefix error codes with FL_ Jerome Forissier
2024-06-18 16:22 ` Tom Rini
2024-06-19 7:29 ` Ilias Apalodimas
2024-06-17 15:32 ` [PATCH v4 02/14] net: introduce alternative implementation as net-lwip/ Jerome Forissier
2024-06-18 17:59 ` Tom Rini
2024-06-19 9:06 ` Jerome Forissier
2024-06-17 15:32 ` [PATCH v4 03/14] net: split include/net.h into net{, -common, -legacy, -lwip}.h Jerome Forissier
2024-06-17 15:32 ` [PATCH v4 04/14] net-lwip: build lwIP Jerome Forissier
2024-06-17 15:32 ` [PATCH v4 05/14] net-lwip: add DHCP support and dhcp commmand Jerome Forissier
2024-06-17 16:54 ` Heinrich Schuchardt
2024-06-19 9:37 ` Jerome Forissier
2024-06-19 10:07 ` Ilias Apalodimas
2024-06-17 15:32 ` [PATCH v4 06/14] net-lwip: add TFTP support and tftpboot command Jerome Forissier
2024-06-17 15:32 ` [PATCH v4 07/14] net-lwip: add ping command Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 08/14] net-lwip: add dns command Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 09/14] net: split cmd/net.c into cmd/net.c and cmd/net-common.c Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 10/14] net-lwip: add wget command Jerome Forissier
2024-06-24 6:21 ` Jon Humphreys
2024-06-24 6:25 ` Jon Humphreys [this message]
2024-06-24 8:50 ` Jerome Forissier
2024-06-24 6:26 ` Jon Humphreys
2024-06-24 8:52 ` Jerome Forissier
2024-06-24 8:49 ` Jerome Forissier
2024-06-25 3:20 ` Jon Humphreys
2024-06-25 7:43 ` Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 11/14] cmd: bdinfo: enable -e when CONFIG_CMD_NET_LWIP=y Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 12/14] configs: add qemu_arm64_lwip_defconfig Jerome Forissier
2024-06-19 12:14 ` Ilias Apalodimas
2024-06-17 15:33 ` [PATCH v4 13/14] MAINTAINERS: net-lwip: add myself as a maintainer Jerome Forissier
2024-06-17 15:33 ` [PATCH v4 14/14] CI: add qemu_arm64_lwip to the test matrix Jerome Forissier
2024-06-18 20:21 ` [PATCH v4 00/14] Introduce the lwIP network stack Tom Rini
2024-06-19 7:24 ` Ilias Apalodimas
2024-06-19 14:47 ` Jerome Forissier
2024-06-19 15:07 ` Tom Rini
2024-06-19 16:45 ` Jerome Forissier
2024-06-19 17:19 ` Peter Robinson
2024-06-20 8:05 ` Jerome Forissier
2024-06-20 17:10 ` Tim Harvey
2024-06-21 12:59 ` Jerome Forissier
2024-06-21 16:08 ` Tim Harvey
2024-06-21 17:56 ` Jerome Forissier
2024-06-21 18:42 ` Fabio Estevam
2024-06-22 8:08 ` Maxim Uvarov
2024-06-24 22:28 ` Tim Harvey
2024-06-25 8:02 ` Jerome Forissier
2024-06-26 16:00 ` Tim Harvey
2024-06-28 9:50 ` Jerome Forissier
2024-06-28 15:48 ` Tim Harvey
2024-07-01 9:58 ` Jerome Forissier
2024-07-01 16:06 ` Tim Harvey
2024-06-21 14:57 ` Simon Glass
2024-06-21 17:55 ` Jerome Forissier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyo6vovk.fsf@udb0321960.dhcp.ti.com \
--to=jhumphreysti@gmail.com \
--cc=akashi.tkhro@gmail.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=ilias.apalodimas@linaro.org \
--cc=javier.tia@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=muvarov@gmail.com \
--cc=pbrobinson@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox