From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Sun, 9 Dec 2018 21:53:23 +0100 Subject: [U-Boot] [PATCH] test: hexdump: fix misplaced return In-Reply-To: References: <20181204203008.28843-1-simon.k.r.goldschmidt@gmail.com> Message-ID: <86de44cf-49de-60cc-383e-83deebf6e1f3@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 05.12.2018 um 13:55 schrieb Simon Glass: > On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt > wrote: >> >> One of the hexdump tests in test/lib/hexdump.c returns right at the >> start of the function without testing anything. >> >> Fix this by moving the 'return 0;' statement to the end of the function. >> >> Signed-off-by: Simon Goldschmidt >> --- >> >> test/lib/hexdump.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > That's one way to make a test pass. > > Reviewed-by: Simon Glass Is there a plan to make all tests under test/ run with 'make check'? Seems like this one is not included there? Simon