From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1501CD128A for ; Wed, 10 Apr 2024 19:03:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2438487572; Wed, 10 Apr 2024 21:03:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="FjaWqZBx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8F1F087572; Wed, 10 Apr 2024 20:57:31 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 39A6B8815A for ; Wed, 10 Apr 2024 20:57:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=j-humphreys@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 43AIvPji002639; Wed, 10 Apr 2024 13:57:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1712775445; bh=lmbiyGocazFJMrgHxFxjhTLYm7for5tdkzd7SFQFD7I=; h=From:To:CC:Subject:In-Reply-To:References:Date; b=FjaWqZBxU++pDq+aZKd9I41Yc1mzTh94HG/sOIHMtKVnzBl1TypQrh4NEgwpjSvK+ xB0g2sJBCFPEkIH8DwA0n8SeRjXDY3HGUj8X9vbctNIGlx9bg+1lOP7Vwz7g2NrF2t KOTRfjtsItUmt4+NfU6icheNEnnBVNAaoqTTluRI= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 43AIvPbA024093 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Apr 2024 13:57:25 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 10 Apr 2024 13:57:24 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 10 Apr 2024 13:57:24 -0500 Received: from localhost (udb0321960.dhcp.ti.com [128.247.81.241]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 43AIvOPc126502; Wed, 10 Apr 2024 13:57:24 -0500 From: Jon Humphreys To: Andrew Davis , Neha Malcom Francis , Vignesh Raghavendra , Nishanth Menon , "Simon Glass" , Tom Rini CC: , Andrew Davis Subject: Re: [PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP In-Reply-To: <20240410183834.153876-1-afd@ti.com> References: <20240410183834.153876-1-afd@ti.com> Date: Wed, 10 Apr 2024 13:57:24 -0500 Message-ID: <86o7ahyrjf.fsf@udb0321960.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Approved-At: Wed, 10 Apr 2024 21:03:06 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Andrew Davis writes: > When we find a certificate on an image to be booted on a GP device we > print out a message explaining that the certificate is being skipped. > This message is rather long and is printed for every image. Shorten > the message and make the long version into a debug message. > > Signed-off-by: Andrew Davis > --- > arch/arm/mach-k3/security.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-k3/security.c b/arch/arm/mach-k3/security.c > index 22697a263a8..7c46914d9dd 100644 > --- a/arch/arm/mach-k3/security.c > +++ b/arch/arm/mach-k3/security.c > @@ -50,7 +50,7 @@ void ti_secure_image_check_binary(void **p_image, size_t *p_size) > > if (get_device_type() == K3_DEVICE_TYPE_GP) { > if (ti_secure_cert_detected(*p_image)) { > - printf("Warning: Detected image signing certificate on GP device. " > + debug("Warning: Detected image signing certificate on GP device. " > "Skipping certificate to prevent boot failure. " > "This will fail if the image was also encrypted\n"); > > @@ -60,6 +60,7 @@ void ti_secure_image_check_binary(void **p_image, size_t *p_size) > return; > } > > + printf("Skipping authentication on GP device\n"); > *p_image += cert_length; > *p_size -= cert_length; > } > -- > 2.39.2 Would be nice if it only emitted the message once! Tested-by: Jonathan Humphreys