From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 461EBD43370 for ; Thu, 7 Nov 2024 15:49:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89E2D88DFA; Thu, 7 Nov 2024 16:49:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="t4b7tReR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8E9C888DFA; Thu, 7 Nov 2024 16:49:43 +0100 (CET) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A794D88E2D for ; Thu, 7 Nov 2024 16:49:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=j-humphreys@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4A7FnF1x124412; Thu, 7 Nov 2024 09:49:15 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1730994555; bh=URw1KKIwwwAZ6al6tEpQWtrLjsu0qtL+yhD0t2lY7CE=; h=From:To:CC:Subject:In-Reply-To:References:Date; b=t4b7tReR+387RSsEeWnghoZFNXvpKw3gHXfLhVL4uvqh09v36J94zrTBV/9xV0K9+ jCjfp1RX9+neJemDrpOLXyFH5OkbaYFXIDDGU5zDdQoJ+fzeqDIZTQFam46S3K6pNa UQ+LwfMC+4AT4ncIapM0JQSfyOceWzc6IZwTkyX4= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4A7FnFLW031270 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Nov 2024 09:49:15 -0600 Received: from lewvowa02.ent.ti.com (10.180.75.80) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 7 Nov 2024 09:49:14 -0600 Received: from DLEE104.ent.ti.com (157.170.170.34) by lewvowa02.ent.ti.com (10.180.75.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.34; Thu, 7 Nov 2024 09:49:14 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 7 Nov 2024 09:49:14 -0600 Received: from localhost (udb0321960.dhcp.ti.com [128.247.79.44]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4A7FnEPs113089; Thu, 7 Nov 2024 09:49:14 -0600 From: Jon Humphreys To: Marek Vasut , Michal Simek , , Tom Rini CC: Andre Przywara , Ashok Reddy Soma , Jagan Teki , "Michael Walle" , Patrice Chotard , Patrick Delaunay , Pratyush Yadav , Quentin Schulz , Sean Anderson , Simon Glass , Takahiro Kuwano , Tudor Ambarus , Venkatesh Yadav Abbarapu , Subject: Re: [PATCH 1/6] Revert "spi: zynq_qspi: Add parallel memories support in QSPI driver" In-Reply-To: References: <20241022210633.271534-1-marek.vasut+renesas@mailbox.org> <86v7x05fyd.fsf@udb0321960.dhcp.ti.com> <86ses458k3.fsf@udb0321960.dhcp.ti.com> Date: Thu, 7 Nov 2024 09:49:14 -0600 Message-ID: <86pln759j9.fsf@udb0321960.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Marek Vasut writes: > On 11/6/24 10:58 PM, Jon Humphreys wrote: >> Marek Vasut writes: >> >>> On 11/6/24 8:18 PM, Jon Humphreys wrote: >>>> Marek Vasut writes: >>>> >>>>> On 10/23/24 10:17 AM, Michal Simek wrote: >>>>>> >>>>>> >>>>>> On 10/22/24 23:06, Marek Vasut wrote: >>>>>>> This reverts commit 1e36d34b52e7a1ebe5a2a5339d6905540f4253aa. >>>>>>> >>>>>>> This parallel/stacked support breaks basic SPI NOR support, >>>>>>> e.g. this no longer works: >>>>>>> >>>>>>> => sf probe && sf update 0x50000000 0 0x160000 >>>>>>> SF: Detected s25fs512s with page size 256 Bytes, erase size 256 KiB, >>>>>>> total 64 MiB >>>>>>> device 0 offset 0x0, size 0x160000 >>>>>>> SPI flash failed in read step >>>>>> >>>>>> Reverting everything seems to me too much. Tom has tested it on his HW >>>>>> and didn't see any issue. That's why better to look at code which is >>>>>> causing this. >>>>>> You are reverting everything but likely there is specific patch which is >>>>>> causing this. Which one is it? >>>>>> Which board was used for your testing? Likely we don't have access to it. >>>>>> Is there any QEMU available which can be used for debugging? >>>>> >>>>> The testcase including the exact SPI NOR model is above. >>>>> >>>>> iMX6 with w25q16dw seems to be broken too. >>>>> >>>>> Basically every board I have access no longer has a working "sf probe ; >>>>> sf update" combination ... so yeah, this means this patchset is >>>>> fundamentally broken. >>>>> >>>> >>>> I can also confirm that the patch series: >>>> >>>> f8efc68b30e Merge patch series "spi-nor: Add parallel and stacked memories >>>> support" >>>> >>>> breaks SPI NOR on TI platforms, particularly SK-AM62 and SK-AM62P: >>>> >>>> U-Boot 2024.10-00752-gf8efc68b30e2 (Nov 06 2024 - 12:25:13 -0600) >>>> >>>> SoC: AM62X SR1.0 HS-FS >>>> Model: Texas Instruments AM625 SK >>>> ... >>>> Hit any key to stop autoboot: 0 >>>> => sf probe && sf update ${loadaddr} 0x400000 0x10 >>>> SF: Detected s28hs512t with page size 256 Bytes, erase size 256 KiB, total 64 MiB >>>> device 0 offset 0x400000, size 0x10 >>>> SPI flash failed in read step >>>> => >>> Sigh ... can you please test current u-boot/master and see if the error >>> is fixed there ? >>> >> >> Yes I had verified it also fails against master, although the behavior was >> a bit different. The .'s below are our DMA engine waiting indefinitely. >> >> => sf probe && sf update ${loadaddr} 0x400000 0x10 >> SF: Detected s28hs512t with page size 256 Bytes, erase size 256 KiB, total 64 MiB >> device 0 offset 0x400000, size 0x10 >> ..................................................... >> >> I have not investigated further. > > Can you try and run some 'git bisect' to find out exactly which commit > broke your use case ? There is a bunch of fixes for the worst breakage > that landed recently, but clearly there is more. > > Full revert seems increasingly appealing ... commit 5d40b3d384d Jon